Re: removing some code from the SVN

Posted by David E. Jones on Jun 24, 2006; 3:22am
URL: http://ofbiz.116.s1.nabble.com/removing-some-code-from-the-SVN-tp168716p168717.html


For entities that are now longer used: they should be prefixed with "Old" and then the table-name attribute should be used to point to the original default table name.

For code that is deprecated and no longer used in the project: just kill it and put a good comment in the commit log, unless perhaps there is some suspicion that the code is widely used of course... If there is anyone using it they will have been using it for a while, and as long as it is fairly loosely coupled and isolated then they can always pull the stuff from previous SVN versions as needed.

-David


Si Chen wrote:
> Hi.  What should be our policy for removing code when we have a better
> implementation?  We originally put some code in OrderServices for
> auto-exploding marketing packages, but now with Jacopo's new auto
> production run that code is no longer needed by us at least.  I was also
> never fully satisfied with the code -- it caused all sorts of problems
> when there were fractions or adjustments, so I'd like to remove.  Is
> that OK?
>
> Si