Login  Register

Re: removing some code from the SVN

Posted by BJ Freeman on Jun 23, 2006; 8:05pm
URL: http://ofbiz.116.s1.nabble.com/removing-some-code-from-the-SVN-tp168716p168718.html

I would like to see both on additions, changes, removing, a comment left
in the code.
in your case a simple removed see such and such.
Also like to see a Jira with the deleted code so someone could uses it
if they wanted.

Si Chen sent the following on 6/23/06 12:07 PM:

> Hi.  What should be our policy for removing code when we have a  better
> implementation?  We originally put some code in OrderServices  for
> auto-exploding marketing packages, but now with Jacopo's new auto  
> production run that code is no longer needed by us at least.  I was  
> also never fully satisfied with the code -- it caused all sorts of  
> problems when there were fractions or adjustments, so I'd like to  
> remove.  Is that OK?
>
> Si
>