Re: best practices for contributors

Posted by Adrian Crum on Jun 27, 2006; 6:36pm
URL: http://ofbiz.116.s1.nabble.com/best-practices-for-contributors-tp168876p168887.html

Si Chen wrote:
> 7.  Put your contributions on JIRA instead of emailing it directly to  
> the committers, so everybody can review and comment on it.

One of the side effects I like about this approach is - if the comitters don't
have time to review the code, users can still download the patches and use them
on their local copies.

Contributing to OFBiz can be confusing at times. I'll share some of my confusion
  with the hope that it will help you compose guidelines.

I've suggested ideas on the mailing lists. One or two people will express an
interest in my ideas. I started out posting my ideas on the Wiki - so everyone
can comment on them and use the Wiki as a whiteboard. I was chastised for doing
that - the Wiki is to be used for "Official OFBiz Purposes Only."

Then I tried using Jira. That seemed to go over better. There seems to be times
when Jira submissions are accepted favorably, and other times when I've been
told that I should have discussed it in the mailing lists first.

Personally, I would prefer the latter - make a suggestion on the mailing list,
and if there is any interest, discuss it further as a Jira issue. I like being
able to post patches, have people download them and leave comments, and have
them upload changes or enhancements to the patches. It can be very interactive.
If the idea goes nowhere, then just close the Jira issue.

-Adrian