Re: how about adding a paymentMethodName to PaymentMethod?

Posted by Si Chen-2 on Jun 28, 2006; 10:26pm
URL: http://ofbiz.116.s1.nabble.com/how-about-adding-a-paymentMethodName-to-PaymentMethod-tp169026p169028.html

I disagree.  This is a descriptive note that applies to all  
PaymentMethods so why put it in the child entities.  If you had a  
parent class which had a field that all inherited classes should  
have, shouldn't be in the parent class?



On Jun 28, 2006, at 1:35 PM, Chris Howe wrote:

> "Bank A general account" does not describe the
> PaymentMethod, it describes the credit card, the
> company account, the gift card, etc so that field
> should go on the CreditCard, etc entity.  Now if
> you're using it as an alias for the Payment Method,
> then you should create a PaymentMethodAttribute entity
> and make a relationship between the two.
>
>
> On a side note.  I've noticed a couple of fields
> getting added onto entities in svn that are quick
> fixes to gain functionality but cause a loss of the
> entity's meaning.  PaymentMethod.partyId is one that
> quickly comes to mind.
>
> --- Si Chen <[hidden email]> wrote:
>
>> Hi everybody.
>>
>> What do you think of adding a field
>> "paymentMethodName" to
>> PaymentMethod, so a company can identify that method
>> A is "Bank A
>> general account", etc. etc.
>>
>> Si
>>