Login  Register

[jira] Commented: (OFBIZ-156) JavaMailContainer.checkMessages doesn't handle exceptions well

Posted by Nicolas Malin (Jira) on Aug 13, 2006; 8:51pm
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-156-JavaMailContainer-checkMessages-doesn-t-handle-exceptions-well-tp170622p170624.html

    [ http://issues.apache.org/jira/browse/OFBIZ-156?page=comments#action_12427778 ]
           
David E. Jones commented on OFBIZ-156:
--------------------------------------

I took a quick peek at this and it looks fine, though I don't know that using the finally block is necessary (it should be okay though).

I don't really have a test scenario for this. Is there anyone who would like to volunteer to test and comment?

> JavaMailContainer.checkMessages doesn't handle exceptions well
> --------------------------------------------------------------
>
>                 Key: OFBIZ-156
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-156
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: JMailException.txt
>
>
> If an exception is thrown during checkMessages in the JavaMailContainer, the store is not closed which prevents subsequent attempts to connect and ultimately seems to lockup the poller.  The attached patch should be an improvement, but I'm not much of a programmer so it would be great if someone could look it over.
> Thanks
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira