Posted by
Nicolas Malin (Jira) on
Aug 18, 2006; 12:14am
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-164-rateProductTaxCalcForDisplay-returns-incorrect-priceWithTax-tp170796p170802.html
[
http://issues.apache.org/jira/browse/OFBIZ-164?page=comments#action_12428824 ]
Si Chen commented on OFBIZ-164:
-------------------------------
Erik,
We have an arithmetic.properties file in applications/accounting/config/
I think it is better to use the rounding properties in that file rather than directly inline like this.
I know some existing code may not be doing that, but it's nice to start doing things the right way whenever possible.
Also, would you mind sending in patch files rather than just pasting in the comments section?
> rateProductTaxCalcForDisplay returns incorrect priceWithTax
> -----------------------------------------------------------
>
> Key: OFBIZ-164
> URL:
http://issues.apache.org/jira/browse/OFBIZ-164> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Reporter: Eriks Dobelis
>
> priceWithTax from rateProductTaxCalcForDisplay is returned incorrectly as the total tax. This is a simple diff that solves it.
> Index: applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java
> ===================================================================
> --- applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (revision 431541)
> +++ applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java (working copy)
> @@ -108,7 +108,7 @@
> taxPercentage = taxPercentage.add(taxAdjustment.getBigDecimal("sourcePercentage"));
> BigDecimal adjAmount = taxAdjustment.getBigDecimal("amount");
> taxTotal = taxTotal.add(adjAmount);
> - priceWithTax = priceWithTax.add(adjAmount);
> + priceWithTax = priceWithTax.add(adjAmount.divide(quantity));
> Debug.logInfo("For productId [" + productId + "] added [" + adjAmount + "] of tax to price for geoId [" + taxAdjustment.getString("taxAuthGeoId") + "], new price is [" + priceWithTax + "]", module);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira