Re: svn commit: r441292 - Si Chen - /applications/product/widget/facility/FacilityScreens.xml

Posted by Ray Barlow on Oct 23, 2006; 12:01pm
URL: http://ofbiz.116.s1.nabble.com/Re-svn-commit-r441292-Si-Chen-applications-product-widget-facility-FacilityScreens-xml-tp173507.html

Hi Si,

Any reason in this commit you commented out the picklistActiveList
condition? It was committed a bit over a month ago but I've just hit an
error on the PicklistManage.ftl page where line 113 is trying to use the
picklistActiveList value and crashing out. I wasn't sure if you meant to
commit the <!-- --> tags as you have also added the PACKED status
condition and there is no comment about why you've commented it out,
just a bit confusing really.

I've not really dug deep on this one but I think it occurs if you have
an assigned/picked list and then also add a new one in the input status.

Thanks,

Ray


[hidden email] wrote:

> Author: sichen
> Date: Thu Sep  7 16:07:19 2006
> New Revision: 441292
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=441292
> Log:
> Fixed bug where accepted shipment route segments would show up on list of shipments to be scheduled
>
> Modified:
>     incubator/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml
>
> Modified: incubator/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml
> URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml?view=diff&rev=441292&r1=441291&r2=441292
> ==============================================================================
> --- incubator/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml (original)
> +++ incubator/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml Thu Sep  7 16:07:19 2006
> @@ -546,6 +546,7 @@
>                      <condition-list combine="and">
>                          <condition-expr field-name="facilityId" operator="equals" env-name="parameters.facilityId"/>
>                          <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PICKED"/>
> +                        <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PACKED"/>
>                          <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_CANCELLED"/>
>                      </condition-list>
>                      <order-by field-name="picklistDate"/>
> @@ -577,14 +578,17 @@
>                  <entity-condition entity-name="PartyRoleAndPartyDetail" list-name="partyRoleAndPartyDetailList" use-cache="true">
>                      <condition-expr field-name="roleTypeId" value="PICKER"/>
>                  </entity-condition>
> +                <!--
>                  <entity-condition entity-name="Picklist" list-name="picklistActiveList">
>                      <condition-list combine="and">
>                          <condition-expr field-name="facilityId" operator="equals" env-name="parameters.facilityId"/>
>                          <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PICKED"/>
> +                        <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PACKED"/>
>                          <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_CANCELLED"/>
>                      </condition-list>
>                      <order-by field-name="picklistDate"/>
>                  </entity-condition>
> +                -->
>              </actions>
>              <widgets>
>                  <decorator-screen name="CommonFacilityDecorator">
> @@ -720,6 +724,7 @@
>                          <condition-expr field-name="originFacilityId" operator="equals" env-name="parameters.facilityId"/>
>                          <condition-expr field-name="statusId" operator="equals" value="SHIPMENT_PACKED"/>
>                          <condition-expr field-name="carrierServiceStatusId" operator="not-equals" value="SHRSCS_CONFIRMED"/>
> +                        <condition-expr field-name="carrierServiceStatusId" operator="not-equals" value="SHRSCS_ACCEPTED"/>
>                      </condition-list>
>                      <order-by field-name="shipmentId DESC"/>
>                  </entity-condition>
>
>
>
>