Login  Register

[jira] Created: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

Posted by Nicolas Malin (Jira) on Nov 20, 2006; 3:02pm
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-484-Wrong-total-of-offline-payments-received-is-calculated-by-the-org-ofbiz-orderd-tp174671.html

Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
----------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-484
                 URL: http://issues.apache.org/jira/browse/OFBIZ-484
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Jacopo Cappellato


It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
I think that the new amount received is summed two times to the total of already received offline amounts.
For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
Could you please review the attached patch (that fix the issue)?


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira