Proposed change to the InventoryItem entity

Posted by Jacopo Cappellato on
URL: http://ofbiz.116.s1.nabble.com/Proposed-change-to-the-InventoryItem-entity-tp175562.html

What about defining the following InventoryItem fields as id-ne instead
of id (see attached patch)?

currencyUomId
ownerPartyId
facilityId

The "createInventoryItem" service already performs the checks and
returns an error if it the values are not passed in and there is not a
way to provide default values for them... so it is just to enforce an
existing rule.

Jacopo

Index: applications/product/entitydef/entitymodel.xml
===================================================================
--- applications/product/entitydef/entitymodel.xml (revision 487955)
+++ applications/product/entitydef/entitymodel.xml (working copy)
@@ -1009,11 +1009,11 @@
       <field name="inventoryItemTypeId" type="id"></field>
       <field name="productId" type="id"></field>
       <field name="partyId" type="id"></field>
-      <field name="ownerPartyId" type="id"><description>The owner of the inventory item.</description></field>
+      <field name="ownerPartyId" type="id-ne"><description>The owner of the inventory item.</description></field>
       <field name="statusId" type="id"></field>
       <field name="datetimeReceived" type="date-time"></field>
       <field name="expireDate" type="date-time"></field>
-      <field name="facilityId" type="id"></field>
+      <field name="facilityId" type="id-ne"></field>
       <field name="containerId" type="id"></field>
       <field name="lotId" type="id"></field>
       <field name="uomId" type="id"></field>
@@ -1026,7 +1026,7 @@
       <field name="oldAvailableToPromise" col-name="AVAILABLE_TO_PROMISE" type="floating-point"></field>
       <field name="serialNumber" type="value"></field>
       <field name="unitCost" type="floating-point"><description>Higher precision in case it is a calculated number</description></field>
-      <field name="currencyUomId" type="id"><description>The currency Uom of the unit cost.</description></field>
+      <field name="currencyUomId" type="id-ne"><description>The currency Uom of the unit cost.</description></field>
       <prim-key field="inventoryItemId"/>
       <relation type="one" fk-name="INV_ITEM_TYPE" rel-entity-name="InventoryItemType">
         <key-map field-name="inventoryItemTypeId"/>