Re: Please review the attached patch fro the HtmlFormRenderer class

Posted by Adrian Crum on Jan 08, 2007; 5:42pm
URL: http://ofbiz.116.s1.nabble.com/Please-review-the-attached-patch-fro-the-HtmlFormRenderer-class-tp176227p176228.html

It would be nice if the 'align' property was removed too. Right-to-Left
languages would want it left-aligned.


Jacopo Cappellato wrote:

> Please review the attached patch fro the HtmlFormRenderer class:
>
> it simply changes the <td> elements to <th> elements when used in
> headers (for list based forms) and as field names for single forms.
>
> Can I commit it?
>
> Jacopo
>
>
> ------------------------------------------------------------------------
>
> Index: framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java
> ===================================================================
> --- framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java (revision 494101)
> +++ framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java (working copy)
> @@ -1170,7 +1170,7 @@
>       * @see org.ofbiz.widget.form.FormStringRenderer#renderFormatHeaderRowCellOpen(java.lang.StringBuffer, java.util.Map, org.ofbiz.widget.form.ModelForm, org.ofbiz.widget.form.ModelFormField)
>       */
>      public void renderFormatHeaderRowCellOpen(StringBuffer buffer, Map context, ModelForm modelForm, ModelFormField modelFormField) {
> -        buffer.append("<td");
> +        buffer.append("<th align=\"right\"");
>          String areaStyle = modelFormField.getTitleAreaStyle();
>          if (UtilValidate.isNotEmpty(areaStyle)) {
>              buffer.append(" class=\"");
> @@ -1185,12 +1185,12 @@
>       * @see org.ofbiz.widget.form.FormStringRenderer#renderFormatHeaderRowCellClose(java.lang.StringBuffer, java.util.Map, org.ofbiz.widget.form.ModelForm, org.ofbiz.widget.form.ModelFormField)
>       */
>      public void renderFormatHeaderRowCellClose(StringBuffer buffer, Map context, ModelForm modelForm, ModelFormField modelFormField) {
> -        buffer.append("</td>");
> +        buffer.append("</th>");
>          this.appendWhitespace(buffer);
>      }
>  
>      public void renderFormatHeaderRowFormCellOpen(StringBuffer buffer, Map context, ModelForm modelForm) {
> -        buffer.append("<td align=\"center\"");
> +        buffer.append("<th align=\"center\"");
>          String areaStyle = modelForm.getFormTitleAreaStyle();
>          if (UtilValidate.isNotEmpty(areaStyle)) {
>              buffer.append(" class=\"");
> @@ -1205,7 +1205,7 @@
>       * @see org.ofbiz.widget.form.FormStringRenderer#renderFormatHeaderRowFormCellClose(java.lang.StringBuffer, java.util.Map, org.ofbiz.widget.form.ModelForm)
>       */
>      public void renderFormatHeaderRowFormCellClose(StringBuffer buffer, Map context, ModelForm modelForm) {
> -        buffer.append("</td>");
> +        buffer.append("</th>");
>          this.appendWhitespace(buffer);
>      }
>  
> @@ -1348,7 +1348,7 @@
>       * @see org.ofbiz.widget.form.FormStringRenderer#renderFormatFieldRowTitleCellOpen(java.lang.StringBuffer, java.util.Map, org.ofbiz.widget.form.ModelFormField)
>       */
>      public void renderFormatFieldRowTitleCellOpen(StringBuffer buffer, Map context, ModelFormField modelFormField) {
> -        buffer.append("<td width=\"20%\" align=\"right\"");
> +        buffer.append("<th width=\"20%\" align=\"right\"");
>          String areaStyle = modelFormField.getTitleAreaStyle();
>          if (UtilValidate.isNotEmpty(areaStyle)) {
>              buffer.append(" class=\"");
> @@ -1363,7 +1363,7 @@
>       * @see org.ofbiz.widget.form.FormStringRenderer#renderFormatFieldRowTitleCellClose(java.lang.StringBuffer, java.util.Map, org.ofbiz.widget.form.ModelFormField)
>       */
>      public void renderFormatFieldRowTitleCellClose(StringBuffer buffer, Map context, ModelFormField modelFormField) {
> -        buffer.append("</td>");
> +        buffer.append("</th>");
>          this.appendWhitespace(buffer);
>      }
>