Re: Please review the attached patch fro the HtmlFormRenderer class

Posted by Adrian Crum on Jan 09, 2007; 12:32am
URL: http://ofbiz.116.s1.nabble.com/Please-review-the-attached-patch-fro-the-HtmlFormRenderer-class-tp176227p176234.html

Jacopo,

I've attached a patch for the HtmlFormRenderer class that has your patch
applied. I have also added comments on what changes need to be made to use css
classes instead of hard-coded style properties. Search the patched file for "//
css upgrade:" to see my comments. If my suggestestions seem okay, then I will
create the necessary css classes and update the HtmlFormRenderer.java file.

I know this is more than what you intended, but my thinking is to fix it all
while we're at it.

-Adrian

Jacopo Cappellato wrote:

> Adrian,
>
> about combining the two files into one file, for me it would be fine.
>
> I'd like to get a bit more feedback before applying this patch, but in
> the meantime, if you want to test it, here is the 'correct' one (attached).
>
> Thanks for your help.
>
> Jacopo