Re: Please review the attached patch fro the HtmlFormRenderer class

Posted by Jacopo Cappellato on Jan 08, 2007; 7:04pm
URL: http://ofbiz.116.s1.nabble.com/Please-review-the-attached-patch-fro-the-HtmlFormRenderer-class-tp176227p176249.html

First of all, just to avoid confusion, the alignment in my patch was
wrong and the correct one would be:

buffer.append("<th align=\"left\"");

Without it the column headers (that are now by default left aligned
because they are rendered with <td>) would be centered in all the
generated lists.

Jacopo


Chris Howe wrote:

> My only concern then is why the first change in the
> patch _adds the align attribute (it's obvious the rest
> of them were already there).  I think the "step in the
> right direction" is a fine approach and doesn't need
> to "fix" everything but it shouldn't throw another
> wrench into it.  I'm not sure we have enough people to
> apply the patch (as opposed to simply reviewing it) to
> their development to be sure it's not throwing form
> widget uses out of alignment in use cases that use the
> areastyle to define their alignment.
>
>