[jira] Created: (OFBIZ-668) UtilValidate.isEmail has incorrect logic
Posted by
Nicolas Malin (Jira) on
Jan 29, 2007; 6:09pm
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-668-UtilValidate-isEmail-has-incorrect-logic-tp177595.html
UtilValidate.isEmail has incorrect logic
----------------------------------------
Key: OFBIZ-668
URL:
https://issues.apache.org/jira/browse/OFBIZ-668 Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Environment: all
Reporter: John Martin
Priority: Minor
Two problems:
1. The isEmail(String email, boolean requireDot) test for an empty/null string and will return true. Obviously both these conditions should return false.
2. the isEmail(String email) default is to not test for a dot in the domain. Being that most tests would be for real email address (not something like admin@localhost), that the default should be true.
I'm also suggesting that we wrapper the Java Commons email validator class which is much more precise
org.apache.commons.validator.EmailValidator
http://www.koders.com/java/fid2F1364A91DBBCED0B3D0DB88F5AA0499FD29A77F.aspxAny thoughts?
Will implement after comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.