Posted by
Nicolas Malin (Jira) on
Oct 09, 2007; 9:53am
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-668-UtilValidate-isEmail-has-incorrect-logic-tp177595p177598.html
[
https://issues.apache.org/jira/browse/OFBIZ-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato updated OFBIZ-668:
------------------------------------
Attachment: emailvalidation.patch
Can I commit the attached patch?
Summary:
1) replaced the logic inside the isEmail method with a call to org.apache.commons.validator.EmailValidator.isValid(...)
2) however I've left the code that returns true if the string is empty; here is the method as is now:
public static boolean isEmail(String s) {
if (isEmpty(s)) return defaultEmptyOK;
return EmailValidator.getInstance().isValid(s);
}
3) the only remarkable difference is that the original code was accepting (by default) a domain without dots (user@localhost); the new code requires a real domain (
[hidden email])
Is this acceptable?
> UtilValidate.isEmail has incorrect logic
> ----------------------------------------
>
> Key: OFBIZ-668
> URL:
https://issues.apache.org/jira/browse/OFBIZ-668> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: all
> Reporter: John Martin
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: emailvalidation.patch
>
>
> Two problems:
> 1. The isEmail(String email, boolean requireDot) test for an empty/null string and will return true. Obviously both these conditions should return false.
> 2. the isEmail(String email) default is to not test for a dot in the domain. Being that most tests would be for real email address (not something like admin@localhost), that the default should be true.
> I'm also suggesting that we wrapper the Java Commons email validator class which is much more precise
> org.apache.commons.validator.EmailValidator
>
http://www.koders.com/java/fid2F1364A91DBBCED0B3D0DB88F5AA0499FD29A77F.aspx> Any thoughts?
> Will implement after comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.