Posted by
Nicolas Malin (Jira) on
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-776-Couple-of-misc-fixes-i-e-unused-return-values-leading-to-bugs-type-in-assignmt-tp178860p178862.html
[
https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481925 ]
Scott Gray commented on OFBIZ-776:
----------------------------------
Thanks Stefan, I've commited your first patch in rev. 519584.
Someone else will have to commit the second patch, I've reviewed and it's ok but I don't have permissions to commit to the framework.
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL:
https://issues.apache.org/jira/browse/OFBIZ-776> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Scott Gray
> Priority: Minor
> Attachments: ofbiz_misc1.diff, ofbiz_misc2.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.