Login  Register

Re: svn commit: r815268 - in /ofbiz/trunk: framework/common/webcommon/includes/helplink.ftl themes/flatgrey/includes/header.ftl

Posted by hans_bakker on Sep 25, 2009; 6:44am
URL: http://ofbiz.116.s1.nabble.com/Re-svn-commit-r815268-in-ofbiz-trunk-framework-common-webcommon-includes-helplink-ftl-themes-flatgrel-tp208022p208024.html

Hi Jacques,

please feel free to play with this, it also need to be added to the
business theme....

Regards,
Hans

On Fri, 2009-09-25 at 07:58 +0200, Jacques Le Roux wrote:

> Actually I had a look at this, and I'd suggest rather to use an icon (as initially Bruno suggested) instead.
> This for 2 reasons :
> 1) an icon (especially if colored) attracts more eyes than text and is immediatly perceived by brain (think about roadsigns),
> 2) could be used in any theme.
>
> I just quickly searched and found only this one http://www.freeiconsweb.com/Gif_icons/black_icons.jpg (information icon)
> Bruno suggested to use a blue Atlassian(?)'s icon (Opentaps uses it I think) but we did not
>
> Jacques
> PS : on Jira https://issues.apache.org/jira/images/icons/help_blue.gif
>
> From: "Jacques Le Roux" <[hidden email]>
> > Hans,
> >
> > I just had my 1st look at the Help and this help button.
> >
> > This is truly great, really cool stuff, I like it!
> >
> > I would just suggest green instead of red, and maybe red in other cases.
> >
> > Thanks
> >
> > Jacques
> > PS : Thanks also to Sharan for her very appreciated help on the help feature.
> >
> >
> >> Author: hansbak
> >> Date: Tue Sep 15 10:46:46 2009
> >> New Revision: 815268
> >>
> >> URL: http://svn.apache.org/viewvc?rev=815268&view=rev
> >> Log:
> >> make help button red when help screen available in the flatgrey scheme...could not get it to work in the business
> >> theme....anybody?
> >>
> >> Modified:
> >>    ofbiz/trunk/framework/common/webcommon/includes/helplink.ftl
> >>    ofbiz/trunk/themes/flatgrey/includes/header.ftl
> >>
> >> Modified: ofbiz/trunk/framework/common/webcommon/includes/helplink.ftl
> >> URL:
> >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/helplink.ftl?rev=815268&r1=815267&r2=815268&view=diff
> >> ==============================================================================
> >> --- ofbiz/trunk/framework/common/webcommon/includes/helplink.ftl (original)
> >> +++ ofbiz/trunk/framework/common/webcommon/includes/helplink.ftl Tue Sep 15 10:46:46 2009
> >> @@ -26,10 +26,11 @@
> >> ${helpTopic}
> >> -->
> >>   <#if Static["org.ofbiz.base.component.ComponentConfig"].componentExists("content")>
> >> -    <#assign helpContent = "Y"> <!-- content in ofbiz -->
> >> +    <#assign helpContent = "Y"/>
> >> +    <#assign pageAvail = delegator.findByAnd("ContentAssoc", {"mapKey" : helpTopic})/>
> >>   </#if>
> >>
> >> -  <!-- content in confluence -->
> >> +  <#-- content in confluence -->
> >>   <#if helpUrlsMap["Prefix"] != "Prefix">
> >>     <#assign helpUrlPrefix = helpUrlsMap["Prefix"] />
> >>   </#if>
> >>
> >> Modified: ofbiz/trunk/themes/flatgrey/includes/header.ftl
> >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/includes/header.ftl?rev=815268&r1=815267&r2=815268&view=diff
> >> ==============================================================================
> >> --- ofbiz/trunk/themes/flatgrey/includes/header.ftl (original)
> >> +++ ofbiz/trunk/themes/flatgrey/includes/header.ftl Tue Sep 15 10:46:46 2009
> >> @@ -183,7 +183,7 @@
> >>             <#if webSiteId?exists && requestAttributes._CURRENT_VIEW_?exists>
> >>               <#include "component://common/webcommon/includes/helplink.ftl" />
> >>               <#if helpContent?has_content ||  helpTopic == "navigateHelp" || (parameters.portalPageId?exists && helpTopic ==
> >> "MYPORTAL_showPortalP")>
> >> -                <li><a
> >> href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&amp;portalPageId=${parameters.portalPageId?if_exists}','help'
> >> ,500,500);">${uiLabelMap.CommonHelp}</a></li>
> >> +                <li><a <#if pageAvail?has_content>class="alert"</#if>
> >> href="javascript:lookup_popup2('showHelp?helpTopic=${helpTopic}&amp;portalPageId=${parameters.portalPageId?if_exists}','help'
> >> ,500,500);">${uiLabelMap.CommonHelp}</a></li>
> >>               <#else>
> >>                 <li><a href="${helpUrlPrefix}${helpUrlTopic}${helpUrlSuffix}" target="_blank">${uiLabelMap.CommonHelp}</a></li>
> >>               </#if>
> >>
> >>
> >
> >
>
>
--
Antwebsystems.com: Quality OFBiz services for competitive rates