[jira] [Closed] (OFBIZ-4410) breadcrumbs.ftl code is not efficient

Posted by Nicolas Malin (Jira) on Sep 24, 2011; 8:45am
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-4410-breadcrumbs-ftl-code-is-not-efficient-tp3808963p3838966.html


     [ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4410.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Kiran,

Your patch is in trunk at r1175127

Just a little remark: when you provide a patch from Eclipse (using Subclipse), please follow [these recommendations|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] : "Eclipse internal command (don't use finish but rather select project to avoid the 2 1st lines in the patch)", ie
{code}
### Eclipse Workspace Patch 1.0
#P ofbiz-trunk
{code}
Else when applying from eclipse we get a project conflict. Not a big deal, but faster for us ;)

BTW at r1175130, I have also fixed a bug introduced at r737506, for a better formatting of breadcrumbs

> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
>                 Key: OFBIZ-4410
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4410
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Release Branch 10.04
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch, OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira