Posted by
Nicolas Malin (Jira) on
Feb 04, 2012; 10:17pm
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-4602-Null-values-are-not-synchronized-in-http-mode-tp4145573p4358024.html
[
https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200574#comment-13200574 ]
Divesh Dutta commented on OFBIZ-4602:
-------------------------------------
Hello Jacques,
I was testing credit card transactions and found that in some specific cases, paymentgateway responses are not getting saved. This is due to commits: trunk r1226055
R11.04 r1226056
To explain issue in more detail. When we place an Order, and then edit order, and add additional adjustment in Order (say additional shipping and handling.)
Now order is authorized with original amount . And we set flag ProductStore.shipIfCaptureFails to "Y". Now when we fulfill Order, original amount is captured but additional amount is not yet captured. So ProductStore.shipIfCaptureFails works in PaymentGatewayServices and return error as total amount is not captured yet.
Now when this error is returned, Original amount is captured by Credit Card but it is not logged in OFBiz.
Reason behind above bug:
In savePgr method of PaymentGatewayServices,
{code}
dispatcher.addRollbackService("savePaymentGatewayResponse", context, true);
{code}
is written. So this gets triggered when captureOrderPayments return error due to flag ProductStore.shipIfCaptureFails. But above code does not work successfully. Because it schedules a job. And RuntimeData is prepared for this job and "runTimeInfo" is created where xml value of PaymentGatewayResponse is prepared and saved. But when this job gets executed, it fails because it tries to save "null-field" String for fields which are actually null.
Now because of this we are facing trouble in our current Production systems as we are using 11.04 . It will be great if you look into this and fix this.
> Null values are not synchronized in http mode
> ---------------------------------------------
>
> Key: OFBIZ-4602
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4602> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
> Environment: Using entity synchronization over HTTP (not RMI)
> Reporter: Patrick Antivackis
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspaFor more information on JIRA, see:
http://www.atlassian.com/software/jira