Login  Register

[jira] [Closed] (OFBIZ-4780) Auto-completer request should be async.

Posted by Nicolas Malin (Jira) on Apr 06, 2012; 9:55am
URL: http://ofbiz.116.s1.nabble.com/jira-Created-OFBIZ-4780-Auto-completer-request-should-be-async-tp4528063p4537046.html


     [ https://issues.apache.org/jira/browse/OFBIZ-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4780.
----------------------------------

    Resolution: Fixed

Thanks Deepak,

Good catch, I forgot the response callback need for cleaning (quoting http://jqueryui.com/demos/autocomplete/#overview-main)
{quote}
A response callback, which expects a single argument to contain the data to suggest to the user. This data should be filtered based on the provided term, and can be in any of the formats described above for simple local data (String-Array or Object-Array with label/value/both properties). *It's important when providing a custom source callback to handle errors during the request. You must always call the response callback even if you encounter an error. This ensures that the widget always has the correct state.*
{quote}

Your patch is in
trunk r1310266
R11.04 r1310267


               

> Auto-completer request should be async.
> ---------------------------------------
>
>                 Key: OFBIZ-4780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4780
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: OFBIZ-4780.patch, selectAll.patch
>
>
> Currently auto-completer uses sync call to prepare auto-completer source (result list).
> Due to this user can't perform any other operation on lookup field and user should have to wait until response came.
> In general, synchronous requests should never be used because they tend to block the execution of anything else on the page (or even the entire browser UI), which isn't good.
> Also ajax-loader image not display on google chrome browser due to sync request.
> Need to use async request for auto-completer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira