Re: svn commit: r1311214 - /ofbiz/trunk/framework/base/config/test-containers.xml

Posted by Jacopo Cappellato-4 on
URL: http://ofbiz.116.s1.nabble.com/Re-svn-commit-r1311214-ofbiz-trunk-framework-base-config-test-containers-xml-tp4543699p4545460.html

It may be completely unrelated to this... but I have two tests failing now; does it work for you? It could be as I am doing some local tests

Jacopo

On Apr 10, 2012, at 1:22 PM, Jacques Le Roux wrote:

> Pierre,
>
> I think you did not get my point. I don't want to restrict the use of the Geronimo approach I suggested (please read
> http://markmail.org/message/i4u5pijlclgtzwrm as I said in https://issues.apache.org/jira/browse/OFBIZ-4794) to the test-containers.
> But want to be able to use it on all ports (like also url.properties and so on)
>
> For the Geronimo we need to use ports below 10000 since we will add 10000 to 50000 with this approach (having at most 5 instances of
> OFBiz and test on the same machine seems acceptable to me).
> So I suggest you to randomly  pick some other ports for your own setting.
>
> If you see another way of doing (like proposed in https://issues.apache.org/jira/browse/OFBIZ-4763 following
> http://markmail.org/message/mgmhrqchjjmo776q) please share your thoughts;
>
> We could have a specific shift for the test component for instance, like +28 or what not. Would be better to quickly find a right
> setting for all ports than +1 harcoded like I did or +10000 like you did.... Then please contribute the mechanism, because your
> OFBIZ-4794 patch would prevent the generalised Geronimo way, as I see it (ie +10000 to +50000, max 5 instances ) ...
>
> I must say I did not put a lot of thoughts in this yet. There are maybe more clever ways of doing, I just picked the easiest one
>
> Jacques
>
> From: "Pierre Smits" <[hidden email]>
>> Hi Jacques,
>>
>> What annoyed me was that you bluntly upped the port numbers in
>> test-containers.xml with +1, while I was under the impression that we were
>> still discussing what ports to use. Especially when you mentioned in a
>> previous message the Geronimo approach. Which is totally suitable for me.
>>
>> Unfortunately, now I see a lot of statements in my Jenkins build jobs that
>> ports 8010,9081 and 8445 are already in use by other application servers.
>> Like many others I also have these these ports used by other servers.
>>
>> Regards,
>>
>> Pierre
>>
>> Op 10 april 2012 12:16 schreef Jacques Le Roux <[hidden email]
>>> het volgende:
>>
>>> Mmm sorry Pierre,
>>>
>>> Not sure to get you, does something annoy you there? I'm open for
>>> discussion, of course...
>>>
>>> Jacques
>>>
>>> From: "Pierre Smits" <[hidden email]>
>>>
>>> Jee, Jacques,
>>>>
>>>> Thanks for seeking consensus and NOT pushing your own agenda!
>>>>
>>>>
>>>>
>>>> Op 9 april 2012 15:08 schreef <[hidden email]> het volgende:
>>>>
>>>> Author: jleroux
>>>>> Date: Mon Apr  9 13:08:37 2012
>>>>> New Revision: 1311214
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?**rev=1311214&view=rev<http://svn.apache.org/viewvc?rev=1311214&view=rev>
>>>>> Log:
>>>>> Adds 1 to all ports in order to be able to run concurrently an OFBiz
>>>>> instance and a test instance on the same machine.
>>>>>
>>>>> This closes "set different ports for testing in a CI environment (e.g.
>>>>> Jenkins)" https://issues.apache.org/**jira/browse/OFBIZ-4794<https://issues.apache.org/jira/browse/OFBIZ-4794>
>>>>>
>>>>> Modified:
>>>>>  ofbiz/trunk/framework/base/**config/test-containers.xml
>>>>>
>>>>> Modified: ofbiz/trunk/framework/base/**config/test-containers.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/base/**
>>>>> config/test-containers.xml?**rev=1311214&r1=1311213&r2=**
>>>>> 1311214&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/test-containers.xml?rev=1311214&r1=1311213&r2=1311214&view=diff>
>>>>>
>>>>> ==============================**==============================**
>>>>> ==================
>>>>> --- ofbiz/trunk/framework/base/**config/test-containers.xml (original)
>>>>> +++ ofbiz/trunk/framework/base/**config/test-containers.xml Mon Apr  9
>>>>> 13:08:37 2012
>>>>> @@ -31,14 +31,14 @@ under the License.
>>>>>
>>>>>   <!-- load the naming (JNDI) server -->
>>>>>   <container name="naming-container"
>>>>> class="org.ofbiz.base.**container.**NamingServiceContainer">
>>>>> -        <property name="port" value="1099"/>
>>>>> +        <property name="port" value="1100"/>
>>>>>   </container>
>>>>>
>>>>>   <!-- RMI Service Dispatcher -->
>>>>>   <container name="rmi-dispatcher"
>>>>> class="org.ofbiz.service.rmi.**RmiServiceContainer">
>>>>>       <property name="bound-name" value="RMIDispatcher"/>
>>>>>       <property name="bound-host" value="127.0.0.1"/>
>>>>> -        <property name="bound-port" value="1099"/>
>>>>> +        <property name="bound-port" value="1100"/>
>>>>>       <property name="delegator-name" value="test"/>
>>>>>       <property name="client-factory"
>>>>> value="org.ofbiz.service.rmi.**socket.ssl.**SSLClientSocketFactory"/>
>>>>>       <property name="server-factory"
>>>>> value="org.ofbiz.service.rmi.**socket.ssl.**SSLServerSocketFactory"/>
>>>>> @@ -58,7 +58,7 @@ under the License.
>>>>>       <property name="admin-user" value="system"/>
>>>>>       <property name="admin-pass" value="ofbiz"/>
>>>>>       <property name="iiop-host" value="127.0.0.1"/>
>>>>> -        <property name="iiop-port" value="2000"/>
>>>>> +        <property name="iiop-port" value="2001"/>
>>>>>   </container>
>>>>>    -->
>>>>>
>>>>> @@ -134,7 +134,7 @@ under the License.
>>>>>           <property name="maxSpareThreads" value="50"/>
>>>>>           <property name="maxThreads" value="200"/>
>>>>>           <property name="minSpareThreads" value="4"/>
>>>>> -            <property name="port" value="8009"/>
>>>>> +            <property name="port" value="8010"/>
>>>>>           <property name="tcpNoDelay" value="true"/>
>>>>>           <property name="soTimeout" value="60000"/>
>>>>>           <property name="tomcatAuthentication" value="true"/>
>>>>> @@ -169,7 +169,7 @@ under the License.
>>>>>           <property name="maxThreads" value="100"/>
>>>>>           <property name="minSpareThreads" value="4"/>
>>>>>           <property name="noCompressionUserAgents" value=""/>
>>>>> -            <property name="port" value="8080"/>
>>>>> +            <property name="port" value="8081"/>
>>>>>           <property name="restrictedUserAgents" value=""/>
>>>>>           <property name="server" value=""/>
>>>>>           <property name="socketBuffer" value="9000"/>
>>>>> @@ -207,7 +207,7 @@ under the License.
>>>>>           <property name="maxThreads" value="100"/>
>>>>>           <property name="minSpareThreads" value="4"/>
>>>>>           <property name="noCompressionUserAgents" value=""/>
>>>>> -            <property name="port" value="8443"/>
>>>>> +            <property name="port" value="8444"/>
>>>>>           <property name="restrictedUserAgents" value=""/>
>>>>>           <property name="server" value=""/>
>>>>>           <property name="socketBuffer" value="9000"/>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>