Re: svn commit: r1530876 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

Posted by Jacopo Cappellato-4 on
URL: http://ofbiz.116.s1.nabble.com/Re-svn-commit-r1530876-ofbiz-trunk-applications-accounting-script-org-ofbiz-accounting-ledger-General-tp4644601p4644613.html

Thanks Adrian; implemented in rev. 1530972 (and 1530973 for 13.07)

Jacopo

On Oct 10, 2013, at 12:48 PM, Adrian Crum <[hidden email]> wrote:

> The result-name attribute is required and the field attribute is optional. So, it would have been better to rename the field attribute to result-name.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 10/10/2013 3:28 AM, Adrian Crum wrote:
>> The extra attribute shouldn't be necessary. I will look into it.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 10/10/2013 1:42 AM, [hidden email] wrote:
>>> Author: jacopoc
>>> Date: Thu Oct 10 08:42:36 2013
>>> New Revision: 1530876
>>>
>>> URL: http://svn.apache.org/r1530876
>>> Log:
>>> Fixed Minilang validation error (missing result-name attributes)
>>> introduced by my recent commit rev. 1530273
>>>
>>> Modified:
>>>
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1530876&r1=1530875&r2=1530876&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>> Thu Oct 10 08:42:36 2013
>>> @@ -943,10 +943,10 @@ under the License.
>>>          <set field="inMap.customTimePeriodId"
>>> from-field="parameters.customTimePeriodId"/>
>>>          <set field="inMap.glAccountId"
>>> from-field="parameters.glAccountId"/>
>>>          <call-service
>>> service-name="computeGlAccountBalanceForTimePeriod" in-map-name="inMap">
>>> -            <result-to-field field="openingBalance"/>
>>> -            <result-to-field field="endingBalance"/>
>>> -            <result-to-field field="postedDebits"/>
>>> -            <result-to-field field="postedCredits"/>
>>> +            <result-to-field field="openingBalance"
>>> result-name="openingBalance"/>
>>> +            <result-to-field field="endingBalance"
>>> result-name="endingBalance"/>
>>> +            <result-to-field field="postedDebits"
>>> result-name="postedDebits"/>
>>> +            <result-to-field field="postedCredits"
>>> result-name="postedCredits"/>
>>>          </call-service>
>>>          <!-- persist the balances -->
>>>          <set field="glAccountHistory.openingBalance"
>>> from-field="openingBalance"/>
>>>
>>>