http://ofbiz.116.s1.nabble.com/Re-ofbiz-framework-branch-trunk-updated-Improved-Marked-unused-HTML-renderers-as-deprecated-tp4763864.html
1. trivial: we prefer to put the Jira number on the title line
2. Upcoming Branch is actually another name for trunk. It's always evolving and never released. Better put a date when deprecating. That seems quite
easier to me. Else you have no idea when it was deprecated, apart referring to git-blame.
> This is an automated email from the ASF dual-hosted git repository.
>
> danwatford pushed a commit to branch trunk
> in repository
https://gitbox.apache.org/repos/asf/ofbiz-framework.git>
>
> The following commit(s) were added to refs/heads/trunk by this push:
> new 406f51d Improved: Marked unused HTML renderers as deprecated
> 406f51d is described below
>
> commit 406f51d032ba4012aed6a5e6253b524a31364e42
> Author: Daniel Watford <
[hidden email]>
> AuthorDate: Thu Jan 14 17:30:03 2021 +0000
>
> Improved: Marked unused HTML renderers as deprecated
>
> (OFBIZ-11927)
> ---
> .../org/apache/ofbiz/widget/renderer/html/HtmlMenuRendererImage.java | 4 +++-
> .../org/apache/ofbiz/widget/renderer/html/HtmlMenuWrapperImage.java | 3 +++
> .../java/org/apache/ofbiz/widget/renderer/html/HtmlTreeRenderer.java | 3 +++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuRendererImage.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuRendererImage.java
> index 1c72d66..8ee989d 100644
> --- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuRendererImage.java
> +++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuRendererImage.java
> @@ -35,8 +35,10 @@ import org.apache.ofbiz.widget.model.ModelMenuItem;
>
> /**
> * Widget Library - HTML Menu Renderer implementation
> + *
> + * @deprecated since Upcoming Branch
> */
> -
> +@Deprecated
> public class HtmlMenuRendererImage extends HtmlMenuRenderer {
>
> protected HtmlMenuRendererImage() { }
> diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuWrapperImage.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuWrapperImage.java
> index 3558b68..4205e27 100644
> --- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuWrapperImage.java
> +++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlMenuWrapperImage.java
> @@ -36,7 +36,10 @@ import org.xml.sax.SAXException;
>
> /**
> * Widget Library - HTML Menu Wrapper class - makes it easy to do the setup and render of a menu
> + *
> + * @deprecated since Upcoming Branch
> */
> +@Deprecated
> public class HtmlMenuWrapperImage extends HtmlMenuWrapper {
>
> private static final String MODULE = HtmlMenuWrapperImage.class.getName();
> diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlTreeRenderer.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlTreeRenderer.java
> index 3658028..5d1196a 100644
> --- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlTreeRenderer.java
> +++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html/HtmlTreeRenderer.java
> @@ -47,7 +47,10 @@ import freemarker.template.TemplateException;
>
> /**
> * Widget Library - HTML Tree Renderer implementation
> + *
> + * @deprecated since Upcoming Branch
> */
> +@Deprecated
> public class HtmlTreeRenderer extends HtmlWidgetRenderer implements TreeStringRenderer {
>
> private ScreenStringRenderer screenStringRenderer = null;
>