http://ofbiz.116.s1.nabble.com/Re-svn-commit-r833114-in-ofbiz-branches-release09-04-applications-party-entitydef-entitymodel-xml-apl-tp534035p547624.html
You are right, I have reverted in both trunk and R9.04 and also removed the title as suggested Erwan.
I want to design the fact that we may have multiple geopoints at a postal address (flats) or facility (offices, etc.).
BTW maybe elevation is not enough because we may have several flats, office, etc. at the same elevation, ie with the same (latitude,
Except if we consider that we have enough accuracy for these values, which is not quite true nowadays, mmm...
So it's late and I need to think more about it, exchange ideas on this ML and finally redesign. I will do later...
creates the possibility of having one. A design flaw is not in itself
case here. Additionally the change is broken as I mentioned on the
other commit and should never have been backported as is anyway. I
> Scott,
>
> Actually it's a bug in the modelidation as we forgot the elevation field which allows a many relationship betwen PostalAddress
> and GeoPoint (flats in building). Same for Facility as Adrian suggested.
> I may revert but we will then lose this ability in R9.04
>
> Jacques
>
> From: "Scott Gray" <
[hidden email]>
> Hi Jacques,
>
> I don't agree with back porting the data model change, I think
> changing the relationship title is fine but changing the relationship
> from one to many (which I don't think is right anyway) shouldn't be
> backported unless it is addressing a bug.
>
> Regards
> Scott
>
> HotWax Media
>
http://www.hotwaxmedia.com>
> On 6/11/2009, at 7:29 AM,
[hidden email] wrote:
>
>> Author: jleroux
>> Date: Thu Nov 5 18:29:15 2009
>> New Revision: 833114
>>
>> URL:
http://svn.apache.org/viewvc?rev=833114&view=rev>> Log:
>> "Applied fix from trunk for revision: 833113"
>> ------------------------------------------------------------------------
>> r833113 | jleroux | 2009-11-05 19:26:27 +0100 (jeu. 05 nov. 2009) | 3 lignes
>>
>> Change "Geo Point" title to "Point"
>> Change the type of relation for Postal Address to GeoPoint from one to many. Because of the elevation field in GeoPoint. A bit
>> scifi for now, but maybe useful one day...)
>> Thanks to a discussion with Erwan "Relation title not needed on Facility entity" at
https://issues.apache.org/jira/browse/
>> OFBIZ-3153 - OFBIZ-3153
>> ------------------------------------------------------------------------
>>
>>
>> Modified:
>> ofbiz/branches/release09.04/ (props changed)
>> ofbiz/branches/release09.04/applications/party/entitydef/ entitymodel.xml
>> ofbiz/branches/release09.04/applications/product/entitydef/ entitymodel.xml
>>
>> Propchange: ofbiz/branches/release09.04/
>> ------------------------------------------------------------------------------
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Thu Nov 5 18:29:15 2009
>> @@ -1 +1 @@
>> -/ofbiz/trunk:
>> 765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,808786-808787,808792,809141,810370,810438,810465,810807,810809,810
>> 814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908
>> +/ofbiz/trunk:
>> 765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,777768,777792,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,808786-808787,808792,809141,810370,810438,810465,810807,810809,810
>> 814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908,833113
>>
>> Modified: ofbiz/branches/release09.04/applications/party/entitydef/ entitymodel.xml
>> URL:
>>
http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/party/entitydef/entitymodel.xml?rev=833114&r1=833113&r2=833114&view=diff>> = = = = = = = = = =====================================================================
>> --- ofbiz/branches/release09.04/applications/party/entitydef/ entitymodel.xml (original)
>> +++ ofbiz/branches/release09.04/applications/party/entitydef/ entitymodel.xml Thu Nov 5 18:29:15 2009
>> @@ -1167,7 +1167,7 @@
>> <relation type="one" fk-name="POST_ADDR_PCGEO" title="PostalCode" rel-entity-name="Geo">
>> <key-map field-name="postalCodeGeoId" rel-field-name="geoId"/>
>> </relation>
>> - <relation type="one" fk-name="POST_ADDR_GEOPT" title="Geo Point" rel-entity-name="GeoPoint">
>> + <relation type="many" fk-name="POST_ADDR_GEOPT" title="Point" rel-entity-name="GeoPoint"> <!-- because of the elevation
>> field in GeoPoint we may face a many relationship in future -->
>> <key-map field-name="geoPointId"/>
>> </relation>
>> <index name="ADDRESS1_IDX">
>>
>> Modified: ofbiz/branches/release09.04/applications/product/ entitydef/ entitymodel.xml
>> URL:
>>
http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/product/entitydef/entitymodel.xml?rev=833114&r1=833113&r2=833114&view=diff>> = = = = = = = = = =====================================================================
>> --- ofbiz/branches/release09.04/applications/product/entitydef/ entitymodel.xml (original)
>> +++ ofbiz/branches/release09.04/applications/product/entitydef/ entitymodel.xml Thu Nov 5 18:29:15 2009
>> @@ -984,7 +984,7 @@
>> <relation type="many" rel-entity-name="FacilityTypeAttr">
>> <key-map field-name="facilityTypeId"/>
>> </relation>
>> - <relation type="one" fk-name="FACILITY_GEOPT" title="Geo Point" rel-entity-name="GeoPoint">
>> + <relation type="one" fk-name="FACILITY_GEOPT" title="Point" rel-entity-name="GeoPoint">
>> <key-map field-name="geoPointId"/>
>> </relation>
>> </entity>
>>
>>
>
>
>