http://ofbiz.116.s1.nabble.com/Formatting-controllers-tp623986p624492.html
Would it make sense to make optional/implicit all the request-map entries that are associated to a view-map entry with the same name and don't trigger any event?
For all of these entries the view-map could be enough (but we have to provide a default value for the https and auth attributes).
> Thanks David, Tim,
>
> Yes, actually I'd like to have them consistent.
> Not for the sake of consistency but because it's easier to read when there is a sole pattern used.
> Your eyes don't have to adapt from a line to the other, less eyeballs work.
> And I find it easier to not have all on one line.
>
> This said, I was expecting to use Oxygen in Eclipse to format blocks, but this seems not possible, I found only Ctrl+Shft+F which formats all the file
> Using regexp is then the solution but much more harder and risky...
>
> I will see, I have some issues with Oxygen and it's hard to get them fixed.
> You have to make a lot of exchange and to explain all things wich much much details.
> To such an extent that the work is almost done...
>
> I'm good to find frustration :/
>
> Jacques
>
> From: "Tim Ruppert" <
[hidden email]>
>> "consistent enough" is tough when it slips thru the crack and it's not always consistent. I have to admit to liking it being explicit - but it's really trivial enough to go either way. Some people put the bracket on the same line - some the next. You really just have to pick a guideline and stick to it as far as I'm concerned.
>>
>> Cheers,
>> Ruppert
>>
>> On Nov 19, 2009, at 11:44 PM, David E Jones wrote:
>>
>>>
>>> On Nov 19, 2009, at 6:46 AM, Ashish Vijaywargiya wrote:
>>>
>>>> Hello Jacques,
>>>>
>>>> The following changes are good:
>>>> - <request-map uri="FindSubscriptionResource"><security https="true"
>>>> auth="true"/><response name="success" type="view"
>>>> value="FindSubscriptionResource"/></request-map>
>>>> - <request-map uri="EditSubscriptionResource"><security https="true"
>>>> auth="true"/><response name="success" type="view"
>>>> value="EditSubscriptionResource"/></request-map>
>>>> + <request-map uri="FindSubscriptionResource">
>>>> + <security https="true" auth="true"/>
>>>> + <response name="success" type="view"
>>>> value="FindSubscriptionResource"/>
>>>> + </request-map>
>>>> + <request-map uri="EditSubscriptionResource">
>>>> + <security https="true" auth="true"/>
>>>> + <response name="success" type="view"
>>>> value="EditSubscriptionResource"/>
>>>> + </request-map>
>>>
>>> I disagree. That change turns one line into four, and the pattern for those entries is generally consistent enough that reading beyond the first 50 characters or so it totally redundant information.
>>>
>>> -David
>>>
>>>
>>>
>>>
>>>>
>>>> *But* I don't like the changes for moving "invoke" attribute to the new
>>>> line:
>>>>
>>>> - <event type="java" path="org.ofbiz.product.product.ProductEvents"
>>>> invoke="updateProductQuickAdminShipping"/>
>>>> + <event type="java" path="org.ofbiz.product.product.ProductEvents"
>>>> + invoke="updateProductQuickAdminShipping"/>
>>>>
>>>> And for view map entries - +1.
>>>>
>>>>
>>>> --
>>>> Ashish
>>>>
>>>>
>>>> On Thu, Nov 19, 2009 at 6:44 PM, Jacques Le Roux <
>>>>
[hidden email]> wrote:
>>>>
>>>>>
>>>>> Hi devs,
>>>>>
>>>>> I often found myself in difficulties when reading controllers files.
>>>>>
>>>>> I would like to format them all as it's done on the attached example
>>>>>
http://n4.nabble.com/file/n623986/controller.patch controller.patch , but
>>>>> the view-maps which I would prefer to keep on one line.
>>>>>
>>>>> Opinions ?
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>> --
>>>>> View this message in context:
>>>>>
http://n4.nabble.com/Formatting-controllers-tp623986p623986.html>>>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>>>>
>>>
>>
>
>