Re: svn commit: r883017 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

Posted by Jacques Le Roux on Nov 26, 2009; 7:21pm
URL: http://ofbiz.116.s1.nabble.com/Re-svn-commit-r883017-ofbiz-trunk-framework-common-src-org-ofbiz-common-CommonWorkers-java-tp717785p788397.html

From: "Jacques Le Roux" <[hidden email]>
> BTW, you did not mention anyting about
>    if (countriesAvailable != null) {
> This would be my main concern. I want to refactor StringUtil .split (and uses) so that it renders an empty list when now it's
> rendering null. To avoid this useless check when using an enhanced for loop (lists often use enhanced for loops) and mostly
> because it's cleaner IMO. I have to check current uses though...

136 occurences, on the 1st teen I looked at, only one relies "on ==null", but anyway it's too much work and risk for what it is
worth

Jacques