Hello Taher,
Yeah, it's a big code replacement removing uneeded (un)boxing data
types. Thus this has been done with Intellij IDE, and the pattern seems
quite simple, i guess there won't be issues.
I did run integration tests, no issue there.
I looked for some examples, some are very old (pre-Apache) and some are
not so old (2015), i'm not sure why there were introduice that way.
I'll look for some testable recent changes, but i'm quite confident.
Thanks for your feedback.
Gil
Le vendredi 03 août 2018 à 15:38:24 (+0300), Taher Alkhateeb a écrit :
> Hi Gil,
>
> Looking quickly at this patch, I see a large find / replace of code
> happening all over the place. While I agree with the general
> philosophy and direction of this patch, are we 100% confident that it
> won't introduce any side effects or new bugs? What was the reason this
> code existed in the first place and now it is unnecessary? Did the
> code exist in an older version of Java where boxing was manual back in
> the day?
>
> On Fri, Aug 3, 2018 at 1:17 PM, Gil Portenseigne
> <
[hidden email]> wrote:
> > Hello !
> >
> > Just to point a Jira i just created with a big patch that will clean up
> > unnecessary code. I'll wait some days to let you review it, and will
> > commit it on monday if nobody stands against.
> >
> >
https://issues.apache.org/jira/browse/OFBIZ-10504> >
> > Thanks
> >
> > Gil
Locked
