OFBiz › OFBiz - Dev

A tiny update in ftpservices

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 9 messages Options
madppiper-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

A tiny update in ftpservices

madppiper-2
Hey,

I would argue for the following slight modifications in FtpServices.java and Framework/Common/servicedef/services.xml:

Services.xml:

Replace:
<service name="ftpInterface" engine="interface" location="" invoke="">
        <attribute name="hostname" type="String" mode="IN" optional="false"/>
        <attribute name="username" type="String" mode="IN" optional="false"/>
        <attribute name="password" type="String" mode="IN" optional="false"/>
        <attribute name="localFilename" type="String" mode="IN" optional="false"/>
        <attribute name="remoteFilename" type="String" mode="IN" optional="false"/>
        <attribute name="binaryTransfer" type="Boolean" mode="IN" optional="true"/>
        <attribute name="passiveMode" type="Boolean" mode="IN" optional="true"/>
    </service>

with

<service name="ftpInterface" engine="interface" location="" invoke="">
        <attribute name="hostname" type="String" mode="IN" optional="false"/>
        <attribute name="username" type="String" mode="IN" optional="false"/>
        <attribute name="password" type="String" mode="IN" optional="false"/>
        <attribute name="localFilename" type="String" mode="IN" optional="false"/>
        <attribute name="remoteFilename" type="String" mode="IN" optional="false"/>
        <attribute name="binaryTransfer" type="Boolean" mode="IN" optional="true"/>
        <attribute name="port" type="String" mode="IN" optional="true"/> 
        <attribute name="passiveMode" type="Boolean" mode="IN" optional="true"/>
    </service>



and  in FtpServices.java:

replace line 65                  

ftp.connect((String) context.get("hostname"));

with

  if(Integer.parseInt((String) context.get("port"))!=0 || context.get("port")!= null){
                ftp.connect((String) context.get("hostname"),Integer.parseInt((String) context.get("port")));
            }else{
                ftp.connect((String) context.get("hostname"));
            }



This allows the specification of a port if needed...
BJ Freeman
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: A tiny update in ftpservices

BJ Freeman
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Submit a patch in the jira

madppiper sent the following on 3/25/2009 6:30 AM:

> Hey,
>
> I would argue for the following slight modifications in FtpServices.java and
> Framework/Common/servicedef/services.xml:
>
> Services.xml:
>
> Replace:
> <service name="ftpInterface" engine="interface" location="" invoke="">
>         <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>         <attribute name="username" type="String" mode="IN"
> optional="false"/>
>         <attribute name="password" type="String" mode="IN"
> optional="false"/>
>         <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>         <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>     </service>
>
> with
>
> <service name="ftpInterface" engine="interface" location="" invoke="">
>         <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>         <attribute name="username" type="String" mode="IN"
> optional="false"/>
>         <attribute name="password" type="String" mode="IN"
> optional="false"/>
>         <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>         <attribute name="port" type="String" mode="IN" optional="true"/>
>         <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>     </service>
>
>
>
> and  in FtpServices.java:
>
> replace line 65                  
>
> ftp.connect((String) context.get("hostname"));
>
> with
>
>   if(Integer.parseInt((String) context.get("port"))!=0 ||
> context.get("port")!= null){
>                 ftp.connect((String)
> context.get("hostname"),Integer.parseInt((String) context.get("port")));
>             }else{
>                 ftp.connect((String) context.get("hostname"));
>             }
>
>
>
> This allows the specification of a port if needed...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJyl9hrP3NbaWWqE4RAk3QAKC6/p+gp3D9Yqwo09gmePUmh1F3fgCgyKYB
xJkzqw3+jFoptze88Uh7HkU=
=SheT
-----END PGP SIGNATURE-----
madppiper-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

AW: A tiny update in ftpservices

madppiper-2
Hey,

I don't have permission to create a new issue yet, so I guess someone would have to either hook me up with that or apply the improvements himself :(

-------------------------------------------------------------------------------------------------------
Paul M. Piper
- IT & E-Commerce -

Mutschler Ventures AG
Pfingstweidstrasse 60
8005 Zürich
Schweiz

Tel.: +41 - (0) - 44 268 18 - 58
Fax : +41 - (0) - 44 268 18 - 66
Mobil: +41 - (0) - 77 460 38 58

Skype: paul.piper
E-Mail: [hidden email]
XING: https://www.xing.com/profile/Paul_Piper
-------------------------------------------------------------------------------------------------------

Der Inhalt dieser E-Mail ist ausschließlich fuer den bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.
The information contained in this email is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any form of disclosure, reproduction, distribution or any action taken or refrained from in reliance on it is prohibited and may be unlawful. Please notify the sender immediately.

-----Ursprüngliche Nachricht-----
Von: BJ Freeman [mailto:[hidden email]]
Gesendet: Mittwoch, 25. März 2009 17:44
An: [hidden email]
Betreff: Re: A tiny update in ftpservices

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Submit a patch in the jira

madppiper sent the following on 3/25/2009 6:30 AM:

> Hey,
>
> I would argue for the following slight modifications in FtpServices.java and
> Framework/Common/servicedef/services.xml:
>
> Services.xml:
>
> Replace:
> <service name="ftpInterface" engine="interface" location="" invoke="">
>         <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>         <attribute name="username" type="String" mode="IN"
> optional="false"/>
>         <attribute name="password" type="String" mode="IN"
> optional="false"/>
>         <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>         <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>     </service>
>
> with
>
> <service name="ftpInterface" engine="interface" location="" invoke="">
>         <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>         <attribute name="username" type="String" mode="IN"
> optional="false"/>
>         <attribute name="password" type="String" mode="IN"
> optional="false"/>
>         <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>         <attribute name="port" type="String" mode="IN" optional="true"/>
>         <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>     </service>
>
>
>
> and  in FtpServices.java:
>
> replace line 65                  
>
> ftp.connect((String) context.get("hostname"));
>
> with
>
>   if(Integer.parseInt((String) context.get("port"))!=0 ||
> context.get("port")!= null){
>                 ftp.connect((String)
> context.get("hostname"),Integer.parseInt((String) context.get("port")));
>             }else{
>                 ftp.connect((String) context.get("hostname"));
>             }
>
>
>
> This allows the specification of a port if needed...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJyl9hrP3NbaWWqE4RAk3QAKC6/p+gp3D9Yqwo09gmePUmh1F3fgCgyKYB
xJkzqw3+jFoptze88Uh7HkU=
=SheT
-----END PGP SIGNATURE-----

Adrian Crum
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: AW: A tiny update in ftpservices

Adrian Crum
Just create an account in Jira. There is no special permission needed to
create new issues.

-Adrian

Paul Piper wrote:

> Hey,
>
> I don't have permission to create a new issue yet, so I guess someone would have to either hook me up with that or apply the improvements himself :(
>
> -------------------------------------------------------------------------------------------------------
> Paul M. Piper
> - IT & E-Commerce -
>
> Mutschler Ventures AG
> Pfingstweidstrasse 60
> 8005 Zürich
> Schweiz
>
> Tel.: +41 - (0) - 44 268 18 - 58
> Fax : +41 - (0) - 44 268 18 - 66
> Mobil: +41 - (0) - 77 460 38 58
>
> Skype: paul.piper
> E-Mail: [hidden email]
> XING: https://www.xing.com/profile/Paul_Piper
> -------------------------------------------------------------------------------------------------------
>
> Der Inhalt dieser E-Mail ist ausschließlich fuer den bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.
> The information contained in this email is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any form of disclosure, reproduction, distribution or any action taken or refrained from in reliance on it is prohibited and may be unlawful. Please notify the sender immediately.
>
> -----Ursprüngliche Nachricht-----
> Von: BJ Freeman [mailto:[hidden email]]
> Gesendet: Mittwoch, 25. März 2009 17:44
> An: [hidden email]
> Betreff: Re: A tiny update in ftpservices
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Submit a patch in the jira
>
> madppiper sent the following on 3/25/2009 6:30 AM:
>> Hey,
>>
>> I would argue for the following slight modifications in FtpServices.java and
>> Framework/Common/servicedef/services.xml:
>>
>> Services.xml:
>>
>> Replace:
>> <service name="ftpInterface" engine="interface" location="" invoke="">
>>         <attribute name="hostname" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="username" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="password" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="localFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="remoteFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
>> optional="true"/>
>>         <attribute name="passiveMode" type="Boolean" mode="IN"
>> optional="true"/>
>>     </service>
>>
>> with
>>
>> <service name="ftpInterface" engine="interface" location="" invoke="">
>>         <attribute name="hostname" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="username" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="password" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="localFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="remoteFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
>> optional="true"/>
>>         <attribute name="port" type="String" mode="IN" optional="true"/>
>>         <attribute name="passiveMode" type="Boolean" mode="IN"
>> optional="true"/>
>>     </service>
>>
>>
>>
>> and  in FtpServices.java:
>>
>> replace line 65                  
>>
>> ftp.connect((String) context.get("hostname"));
>>
>> with
>>
>>   if(Integer.parseInt((String) context.get("port"))!=0 ||
>> context.get("port")!= null){
>>                 ftp.connect((String)
>> context.get("hostname"),Integer.parseInt((String) context.get("port")));
>>             }else{
>>                 ftp.connect((String) context.get("hostname"));
>>             }
>>
>>
>>
>> This allows the specification of a port if needed...
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFJyl9hrP3NbaWWqE4RAk3QAKC6/p+gp3D9Yqwo09gmePUmh1F3fgCgyKYB
> xJkzqw3+jFoptze88Uh7HkU=
> =SheT
> -----END PGP SIGNATURE-----
>
>
BJ Freeman
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: AW: A tiny update in ftpservices

BJ Freeman
In reply to this post by madppiper-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

https://issues.apache.org/jira/secure/Signup!default.jspa

Paul Piper sent the following on 3/25/2009 9:54 AM:

> Hey,
>
> I don't have permission to create a new issue yet, so I guess someone would have to either hook me up with that or apply the improvements himself :(
>
> -------------------------------------------------------------------------------------------------------
> Paul M. Piper
> - IT & E-Commerce -
>
> Mutschler Ventures AG
> Pfingstweidstrasse 60
> 8005 Zürich
> Schweiz
>
> Tel.: +41 - (0) - 44 268 18 - 58
> Fax : +41 - (0) - 44 268 18 - 66
> Mobil: +41 - (0) - 77 460 38 58
>
> Skype: paul.piper
> E-Mail: [hidden email]
> XING: https://www.xing.com/profile/Paul_Piper
> -------------------------------------------------------------------------------------------------------
>
> Der Inhalt dieser E-Mail ist ausschließlich fuer den bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.
> The information contained in this email is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any form of disclosure, reproduction, distribution or any action taken or refrained from in reliance on it is prohibited and may be unlawful. Please notify the sender immediately.
>
> -----Ursprüngliche Nachricht-----
> Von: BJ Freeman [mailto:[hidden email]]
> Gesendet: Mittwoch, 25. März 2009 17:44
> An: [hidden email]
> Betreff: Re: A tiny update in ftpservices
>
> Submit a patch in the jira
>
> madppiper sent the following on 3/25/2009 6:30 AM:
>> Hey,
>
>> I would argue for the following slight modifications in FtpServices.java and
>> Framework/Common/servicedef/services.xml:
>
>> Services.xml:
>
>> Replace:
>> <service name="ftpInterface" engine="interface" location="" invoke="">
>>         <attribute name="hostname" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="username" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="password" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="localFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="remoteFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
>> optional="true"/>
>>         <attribute name="passiveMode" type="Boolean" mode="IN"
>> optional="true"/>
>>     </service>
>
>> with
>
>> <service name="ftpInterface" engine="interface" location="" invoke="">
>>         <attribute name="hostname" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="username" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="password" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="localFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="remoteFilename" type="String" mode="IN"
>> optional="false"/>
>>         <attribute name="binaryTransfer" type="Boolean" mode="IN"
>> optional="true"/>
>>         <attribute name="port" type="String" mode="IN" optional="true"/>
>>         <attribute name="passiveMode" type="Boolean" mode="IN"
>> optional="true"/>
>>     </service>
>
>
>
>> and  in FtpServices.java:
>
>> replace line 65                  
>
>> ftp.connect((String) context.get("hostname"));
>
>> with
>
>>   if(Integer.parseInt((String) context.get("port"))!=0 ||
>> context.get("port")!= null){
>>                 ftp.connect((String)
>> context.get("hostname"),Integer.parseInt((String) context.get("port")));
>>             }else{
>>                 ftp.connect((String) context.get("hostname"));
>>             }
>
>
>
>> This allows the specification of a port if needed...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJynnqrP3NbaWWqE4RAnikAJ9QQrYmnTy2XyYjBDCGr+3PmAY2dQCeMw3F
0tKon5bqJxvQ+m26niKi78k=
=eW13
-----END PGP SIGNATURE-----
Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: A tiny update in ftpservices

Jacques Le Roux
Administrator
In reply to this post by madppiper-2
Hi Paul,

I'd suggest a patch in a Jira issue (if it works again for you, not problem for me)

Thanks

Jacques

From: "madppiper" <[hidden email]>

>
> Hey,
>
> I would argue for the following slight modifications in FtpServices.java and
> Framework/Common/servicedef/services.xml:
>
> Services.xml:
>
> Replace:
> <service name="ftpInterface" engine="interface" location="" invoke="">
>        <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>        <attribute name="username" type="String" mode="IN"
> optional="false"/>
>        <attribute name="password" type="String" mode="IN"
> optional="false"/>
>        <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>        <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>        <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>        <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>    </service>
>
> with
>
> <service name="ftpInterface" engine="interface" location="" invoke="">
>        <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
>        <attribute name="username" type="String" mode="IN"
> optional="false"/>
>        <attribute name="password" type="String" mode="IN"
> optional="false"/>
>        <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
>        <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
>        <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
>        <attribute name="port" type="String" mode="IN" optional="true"/>
>        <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
>    </service>
>
>
>
> and  in FtpServices.java:
>
> replace line 65                  
>
> ftp.connect((String) context.get("hostname"));
>
> with
>
>  if(Integer.parseInt((String) context.get("port"))!=0 ||
> context.get("port")!= null){
>                ftp.connect((String)
> context.get("hostname"),Integer.parseInt((String) context.get("port")));
>            }else{
>                ftp.connect((String) context.get("hostname"));
>            }
>
>
>
> This allows the specification of a port if needed...
>
> --
> View this message in context: http://www.nabble.com/A-tiny-update-in-ftpservices-tp22701814p22701814.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>

madppiper-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: A tiny update in ftpservices

madppiper-2
Hey everyone,

say is there any implementation of SFTP instead of FTP available?  (I didn't feel like opening up a new thread for this simple topic)
BJ Freeman
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: A tiny update in ftpservices

BJ Freeman
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Linux already has a ftp server.
is configure the FTP server to have a folder in the ofbiz space and have
a job that reads that folder and imports. or exports to that folder for
them to ftp from.
I use WarFtp for Windows boxes.

madppiper sent the following on 3/28/2009 6:29 AM:
> Hey everyone,
>
> say is there any implementation of SFTP instead of FTP available?  (I didn't
> feel like opening up a new thread for this simple topic)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJzllOrP3NbaWWqE4RAuB2AKCeL6QR7iJ4WyN3omcIVHeYn33DhQCdGhUr
aX/QfA1tsbZnwwcfwYh5ZaI=
=Ue6P
-----END PGP SIGNATURE-----
BJ Freeman
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: A tiny update in ftpservices

BJ Freeman
In reply to this post by madppiper-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

But don't let me stop you from contributing a secure version.
:D

madppiper sent the following on 3/28/2009 6:29 AM:
> Hey everyone,
>
> say is there any implementation of SFTP instead of FTP available?  (I didn't
> feel like opening up a new thread for this simple topic)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJzlpHrP3NbaWWqE4RAgfsAJ9tD7/nDY0TXt1TMuLA2qyoL9WVFgCeI4by
L4Dtbi+VG6eIdxFCPysguEI=
=QsT8
-----END PGP SIGNATURE-----
Free forum by Nabble Edit this page