About OFBIZ-5338

[Jacques Le Roux]

Hi,

I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338

Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map

I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map. It's more an error prone stuff IMO

Opinions?

Jacques

[Jacques Le Roux]

Any opinions?

Jacques

Jacques Le Roux wrote:

> Hi,
>
> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
>
> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map
>
> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map.
> It's more an error prone stuff IMO
>
> Opinions?
>
> Jacques

[Jacopo Cappellato-4]

On Oct 5, 2013, at 11:02 AM, Jacques Le Roux <[hidden email]> wrote:

> Hi,
>
> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
>
> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map

In this case it may be a better approach to modify the behavior of field-to-result: skip the field if it is not part of the OUT attributes and print instead a warning message.

Jacopo

>
> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map. It's more an error prone stuff IMO
>
> Opinions?
>
> Jacques

[Jacques Le Roux]

Thanks Jacopo,

I agree, I will revert r1529415 and will rather do that, much cleaner

Jacques

Jacopo Cappellato wrote:

> On Oct 5, 2013, at 11:02 AM, Jacques Le Roux <[hidden email]> wrote:
>
>> Hi,
>>
>> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
>>
>> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map
>
> In this case it may be a better approach to modify the behavior of field-to-result: skip the field if it is not part of the OUT
> attributes and print instead a warning message.
>
> Jacopo
>
>>
>> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
>> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map.
>> It's more an error prone stuff IMO
>>
>> Opinions?
>>
>> Jacques