Add "ASF Granted License" column as a default column inside "File Attachment" section

[Ashish Vijaywargiya-5]

This email is in context of jira:

Inside the "File Attachment" block do we have option to update the fields? and add another field "ASF Granted License" as the default option when someone view any jira issue.
It may happen that Committer don't click on "File Attachment" link and see whether "ASF Granted License" flag is been set or not.

This will make committer life little easy and we can ask for uploading another patch if "ASF Granted License" flag is not been checked while uploading the patch.
IMO this changes can be done by Administrator but I am not sure whether it can be done or not.

Thoughts?

--
Ashish

[BJ Freeman]

the other side is alot of times I upload to have a review.
I don't select the License so it will not be committed.
so if default I would have to unselect and have the same problem.


Ashish Vijaywargiya sent the following on 6/22/2009 6:24 AM:

> This email is in context of jira:
>
> Inside the "File Attachment" block do we have option to update the
> fields? and add another field "*ASF Granted License*" as the default
> option when someone view any jira issue.
> It may happen that Committer don't click on "File Attachment" link and
> see whether "ASF Granted License" flag is been set or not.
>
> This will make committer life little easy and we can ask for uploading
> another patch if "ASF Granted License" flag is not been checked while
> uploading the patch.
> IMO this changes can be done by Administrator but I am not sure whether
> it can be done or not.
>
> Thoughts?
>
> --
> Ashish
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Ashish Vijaywargiya]

If you are sharing code for review then its fine if you select the Granting
flag most of the time.
In your email you can mention that this code is for review only. Granting
flag doesn't mean that your code will become part of OFBiz trunk.
IMO it means that you are fine if all the code or part of code is committed
into trunk and you are also fine if someone take your code (complete or
partial) and use in his/ her custom application then you might not be having
any objection with that.

In most of the cases(proportion remains 80% for inclusion - 20% for review)
it happens that user submits patch and that are considered to become part of
trunk. So adding "ASF Granted License" block will help developer as well as
contributer to see whether that flag has been set or not.

Lets see what other has to say about this.

--
Ashish

On Mon, Jun 22, 2009 at 9:57 PM, BJ Freeman <[hidden email]> wrote:

> the other side is alot of times I upload to have a review.
> I don't select the License so it will not be committed.
> so if default I would have to unselect and have the same problem.
>
> --
> BJ Freeman
> http://www.businessesnetwork.com/automation
> http://bjfreeman.elance.com
>
> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
> Systems Integrator.
>
>

[BJ Freeman]

There seems to be a expectation from a lot that I, putting code in the
Jira,  will get into ofbiz code.

Just for the record, i have my own SVN so it does not matter if my code
ever gets into ofbiz. I contribute because ofbiz, the code, gives me
income and I wish to give back.

so far, from email. I only see 50%/50% not sure where 80/20% comes from.
:D
so if you want to change it really does not matter. as usual, I am just
stating another view point.
I really have no vote in this.



Ashish Vijaywargiya sent the following on 6/22/2009 11:19 PM:

> If you are sharing code for review then its fine if you select the Granting
> flag most of the time.
> In your email you can mention that this code is for review only. Granting
> flag doesn't mean that your code will become part of OFBiz trunk.
> IMO it means that you are fine if all the code or part of code is committed
> into trunk and you are also fine if someone take your code (complete or
> partial) and use in his/ her custom application then you might not be having
> any objection with that.
>
> In most of the cases(proportion remains 80% for inclusion - 20% for review)
> it happens that user submits patch and that are considered to become part of
> trunk. So adding "ASF Granted License" block will help developer as well as
> contributer to see whether that flag has been set or not.
>
> Lets see what other has to say about this.
>
> --
> Ashish
>
> On Mon, Jun 22, 2009 at 9:57 PM, BJ Freeman <[hidden email]> wrote:
>
>> the other side is alot of times I upload to have a review.
>> I don't select the License so it will not be committed.
>> so if default I would have to unselect and have the same problem.
>>
>> --
>> BJ Freeman
>> http://www.businessesnetwork.com/automation
>> http://bjfreeman.elance.com
>>
>> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
>> Systems Integrator.
>>
>>
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Jacques Le Roux]

Hi Ashish,

If the file is ASF licence granted a feather icon shows in the 1t column. An example https://issues.apache.org/jira/browse/OFBIZ-2554

Jacques
  ----- Original Message -----
  From: Ashish Vijaywargiya
  To: OFBiz Dev ML
  Sent: Monday, June 22, 2009 3:24 PM
  Subject: Add "ASF Granted License" column as a default column inside "File Attachment" section


  This email is in context of jira:

  Inside the "File Attachment" block do we have option to update the fields? and add another field "ASF Granted License" as the default option when someone view any jira issue.
  It may happen that Committer don't click on "File Attachment" link and see whether "ASF Granted License" flag is been set or not.

  This will make committer life little easy and we can ask for uploading another patch if "ASF Granted License" flag is not been checked while uploading the patch.
  IMO this changes can be done by Administrator but I am not sure whether it can be done or not.

  Thoughts?

  --
  Ashish

[Ashish Vijaywargiya]

Ok cool.
Thanks Jacques for sharing the tip - I was really not aware about this
feature.

--
Ashish

On Tue, Aug 18, 2009 at 1:54 PM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Ashish,
>
> If the file is ASF licence granted a feather icon shows in the 1t column.
> An example https://issues.apache.org/jira/browse/OFBIZ-2554
>
> Jacques
>   ----- Original Message -----
>  From: Ashish Vijaywargiya
>  To: OFBiz Dev ML
>  Sent: Monday, June 22, 2009 3:24 PM
>  Subject: Add "ASF Granted License" column as a default column inside "File
> Attachment" section
>
>
>  This email is in context of jira:
>
>  Inside the "File Attachment" block do we have option to update the fields?
> and add another field "ASF Granted License" as the default option when
> someone view any jira issue.
>  It may happen that Committer don't click on "File Attachment" link and see
> whether "ASF Granted License" flag is been set or not.
>
>  This will make committer life little easy and we can ask for uploading
> another patch if "ASF Granted License" flag is not been checked while
> uploading the patch.
>  IMO this changes can be done by Administrator but I am not sure whether it
> can be done or not.
>
>  Thoughts?
>
>  --
>  Ashish
>