Add border and file name on content rendered from ftl

[James Yong-2]

Hi all,

There are comments containing file names around contents generated from ftl files.
But we need to open the page source from browser to see these comments.
The browser will re-fetch the page source from the server and hit error if the page is expecting a POST submission.

It would be easier to add border and filename on the ftl-generated content, to reduce the need to view the page source from the browser.

Created OFBIZ-12002. Patch is provided.

Regards,
James

[Jacques Le Roux]

+1

Jacques

Le 11/09/2020 à 17:13, James Yong a écrit :

> Hi all,
>
> There are comments containing file names around contents generated from ftl files.
> But we need to open the page source from browser to see these comments.
> The browser will re-fetch the page source from the server and hit error if the page is expecting a POST submission.
>
> It would be easier to add border and filename on the ftl-generated content, to reduce the need to view the page source from the browser.
>
> Created OFBIZ-12002. Patch is provided.
>
> Regards,
> James

[Michael Brohl-3]

Hi James,

this should be a feature which is configurable *additionally* to the
existing rendering in the page source.

As a developer, you should be able to deploy in a testing environment
where the page displays exactly as it would be in a production
environment. Rendered borders/comments should not disturb user testing
or change the display/design.

For debugging it would be still helpful to have the comments in the
source view of the browser.

My advice would be to leave existing functionality as it is and
additionally add a feature/configuration to show the borders in the UI
if it is configured. It should then be programmed in a way that it does
not disturb the original UI layout as good as possible.

IMO it is also possible to view the iriginally loaded source code in the
web developer tools inside the browser without reloading as it is done
in the view source feature.

Thanks,

Michael


Am 11.09.20 um 17:13 schrieb James Yong:

> Hi all,
>
> There are comments containing file names around contents generated from ftl files.
> But we need to open the page source from browser to see these comments.
> The browser will re-fetch the page source from the server and hit error if the page is expecting a POST submission.
>
> It would be easier to add border and filename on the ftl-generated content, to reduce the need to view the page source from the browser.
>
> Created OFBIZ-12002. Patch is provided.
>
> Regards,
> James

[James Yong-2]

Hi Michael,

Thanks for the feedback.
My replies inline.

Regards,
James

On 2020/09/13 10:18:51, Michael Brohl <[hidden email]> wrote:
> Hi James,
>
> this should be a feature which is configurable *additionally* to the
> existing rendering in the page source.

Ok, will modify to use an independent property for the rendering.

>
> As a developer, you should be able to deploy in a testing environment
> where the page displays exactly as it would be in a production
> environment. Rendered borders/comments should not disturb user testing
> or change the display/design.

The filename labels and borders are removed from DOM after showing for a few seconds,
after which the display will be same as production.

>
> For debugging it would be still helpful to have the comments in the
> source view of the browser.

There will be no change to comments in source view.

>
> My advice would be to leave existing functionality as it is and
> additionally add a feature/configuration to show the borders in the UI
> if it is configured. It should then be programmed in a way that it does
> not disturb the original UI layout as good as possible.
>
> IMO it is also possible to view the iriginally loaded source code in the
> web developer tools inside the browser without reloading as it is done
> in the view source feature.

>
> Thanks,
>
> Michael
>
>
> Am 11.09.20 um 17:13 schrieb James Yong:
> > Hi all,
> >
> > There are comments containing file names around contents generated from ftl files.
> > But we need to open the page source from browser to see these comments.
> > The browser will re-fetch the page source from the server and hit error if the page is expecting a POST submission.
> >
> > It would be easier to add border and filename on the ftl-generated content, to reduce the need to view the page source from the browser.
> >
> > Created OFBIZ-12002. Patch is provided.
> >
> > Regards,
> > James
>
>