Adding fromDate and thruDate in GoodIdentification Entity

[Aishwary Shrivastava]

Hello, Devs

We should add support of fromDate and thruDate in the GoodIdentification
entity for tracking and history purpose.

As of now, if we need to update any Good Identification record for a
product, then we have to replace its value and this history isn't
maintained.
It will also enable the user to maintain multiple goodIdentifications of a
product.

Best,
*Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>

[Arun Patidar-2]

+1, looks good to me.

This will require changes in existing CRUD operations related to
GoodIdentifications. Also may need migration service or SQL scripts.


--
Best Regards,
Arun Patidar
www.hotwax.co



On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
[hidden email]> wrote:

> Hello, Devs
>
> We should add support of fromDate and thruDate in the GoodIdentification
> entity for tracking and history purpose.
>
> As of now, if we need to update any Good Identification record for a
> product, then we have to replace its value and this history isn't
> maintained.
> It will also enable the user to maintain multiple goodIdentifications of a
> product.
>
> Best,
> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
>

[Deepak Dixit-4]

Hi Aishwarys,

On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
[hidden email]> wrote:

> Hello, Devs
>
> We should add support of fromDate and thruDate in the GoodIdentification
> entity for tracking and history purpose.
>
>
Sounds good.




> As of now, if we need to update any Good Identification record for a
> product, then we have to replace its value and this history isn't
> maintained.
>

Could you please give us an example of this use case? Why and when we have
to update the Good Identification?


> It will also enable the user to maintain multiple goodIdentifications of a
> product.
>

I am not sure why we need to maintain multiple goodIdentifications of the
same type.


Kind Regards,
Deepak Dixit



> Best,
> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
>

[Suraj Khurana-2]

+1 with fromDate as part of primary key.

--
Best Regards,
Suraj Khurana







On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
[hidden email]> wrote:

> Hello, Devs
>
> We should add support of fromDate and thruDate in the GoodIdentification
> entity for tracking and history purpose.
>
> As of now, if we need to update any Good Identification record for a
> product, then we have to replace its value and this history isn't
> maintained.
> It will also enable the user to maintain multiple goodIdentifications of a
> product.
>
> Best,
> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
>

[Nicolas Malin-2]

I'm mixed about that idea.

GoodIdentification like PartyIdentification are useful to search on
multiple identification shared by other system.  Add life-stamp will add
complexity the resolve quickly a element. Like a name 99% case it's more
important to have the current identification list. Maybe a history
entity (as GoodIdentificationHistory) would be more simple to implement
and sufficient to your problematic ?

Nicolas

On 27/04/2019 09:22, Arun Patidar wrote:

> +1, looks good to me.
>
> This will require changes in existing CRUD operations related to
> GoodIdentifications. Also may need migration service or SQL scripts.
>
>
> --
> Best Regards,
> Arun Patidar
> www.hotwax.co
>
>
>
> On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
> [hidden email]> wrote:
>
>> Hello, Devs
>>
>> We should add support of fromDate and thruDate in the GoodIdentification
>> entity for tracking and history purpose.
>>
>> As of now, if we need to update any Good Identification record for a
>> product, then we have to replace its value and this history isn't
>> maintained.
>> It will also enable the user to maintain multiple goodIdentifications of a
>> product.
>>
>> Best,
>> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
>>

[Aishwary Shrivastava]

Hello Deepak,

We might need to change good identification value anytime due to change in
the third-party system or due to other reason. So to track the previous/old
value we may need to maintain it by date constraint. At a time only one
identification will be active for a product of the same type.

Best,
*Aishwary Shrivastava*


On Sat, Apr 27, 2019 at 1:17 PM Nicolas Malin <[hidden email]>
wrote:

> I'm mixed about that idea.
>
> GoodIdentification like PartyIdentification are useful to search on
> multiple identification shared by other system.  Add life-stamp will add
> complexity the resolve quickly a element. Like a name 99% case it's more
> important to have the current identification list. Maybe a history
> entity (as GoodIdentificationHistory) would be more simple to implement
> and sufficient to your problematic ?
>
> Nicolas
>
> On 27/04/2019 09:22, Arun Patidar wrote:
> > +1, looks good to me.
> >
> > This will require changes in existing CRUD operations related to
> > GoodIdentifications. Also may need migration service or SQL scripts.
> >
> >
> > --
> > Best Regards,
> > Arun Patidar
> > www.hotwax.co
> >
> >
> >
> > On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
> > [hidden email]> wrote:
> >
> >> Hello, Devs
> >>
> >> We should add support of fromDate and thruDate in the GoodIdentification
> >> entity for tracking and history purpose.
> >>
> >> As of now, if we need to update any Good Identification record for a
> >> product, then we have to replace its value and this history isn't
> >> maintained.
> >> It will also enable the user to maintain multiple goodIdentifications
> of a
> >> product.
> >>
> >> Best,
> >> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
> >>
>

[Pritam Kute]

+1 Nicolas for maintaining history(if we are going to maintain it) in
separate entity rather than adding fromDate, thruDate to GoodIdentification
table. The purpose of this entity is to store the identification codes for
the product. I don't find any use case where product identifications codes
are frequently changed and need to maintain the history of it.

Kind Regards,
--
Pritam Kute


On Sat, Apr 27, 2019 at 1:17 PM Nicolas Malin <[hidden email]>
wrote:

> I'm mixed about that idea.
>
> GoodIdentification like PartyIdentification are useful to search on
> multiple identification shared by other system.  Add life-stamp will add
> complexity the resolve quickly a element. Like a name 99% case it's more
> important to have the current identification list. Maybe a history
> entity (as GoodIdentificationHistory) would be more simple to implement
> and sufficient to your problematic ?
>
> Nicolas
>
> On 27/04/2019 09:22, Arun Patidar wrote:
> > +1, looks good to me.
> >
> > This will require changes in existing CRUD operations related to
> > GoodIdentifications. Also may need migration service or SQL scripts.
> >
> >
> > --
> > Best Regards,
> > Arun Patidar
> > www.hotwax.co
> >
> >
> >
> > On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava <
> > [hidden email]> wrote:
> >
> >> Hello, Devs
> >>
> >> We should add support of fromDate and thruDate in the GoodIdentification
> >> entity for tracking and history purpose.
> >>
> >> As of now, if we need to update any Good Identification record for a
> >> product, then we have to replace its value and this history isn't
> >> maintained.
> >> It will also enable the user to maintain multiple goodIdentifications
> of a
> >> product.
> >>
> >> Best,
> >> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
> >>
>

[Michael Brohl-3]

Hi Aishwary,

can you elaborate a bit more why a history of GoodIdentification is needed?

It is used for identification numbers as ISBN, EAN etc.. Those numbers
are rarely subject to change for the same product.

I don't see any use case for history tracking so I would appreciate some
examples.

Thanks,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:

> Hello, Devs
>
> We should add support of fromDate and thruDate in the GoodIdentification
> entity for tracking and history purpose.
>
> As of now, if we need to update any Good Identification record for a
> product, then we have to replace its value and this history isn't
> maintained.
> It will also enable the user to maintain multiple goodIdentifications of a
> product.
>
> Best,
> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
>

[Rishi Solanki]

-1 for the proposal.
For a product identification code will be one of one type. The universal
data model book by Len Silverston suggested the same.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: [phone]


On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl <[hidden email]>
wrote:

> Hi Aishwary,
>
> can you elaborate a bit more why a history of GoodIdentification is needed?
>
> It is used for identification numbers as ISBN, EAN etc.. Those numbers
> are rarely subject to change for the same product.
>
> I don't see any use case for history tracking so I would appreciate some
> examples.
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > Hello, Devs
> >
> > We should add support of fromDate and thruDate in the GoodIdentification
> > entity for tracking and history purpose.
> >
> > As of now, if we need to update any Good Identification record for a
> > product, then we have to replace its value and this history isn't
> > maintained.
> > It will also enable the user to maintain multiple goodIdentifications of
> a
> > product.
> >
> > Best,
> > *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
> >
>
>

[Aishwary Shrivastava]

Thanks so much, everyone for the valuable feedback.

This indeed increases my understanding.  Based on inputs I will have more
look into this.
For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in
the future if required.


[1] https://issues.apache.org/jira/browse/OFBIZ-10963


Kind Regards,
*Aishwary Shrivastava* | Senior Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Cell phone: [phone]
Linkedin: *Aishwary Shrivastava*
<https://www.linkedin.com/in/aishwaryshrivastava/>


On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki <[hidden email]>
wrote:

> -1 for the proposal.
> For a product identification code will be one of one type. The universal
> data model book by Len Silverston suggested the same.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: [phone]
>
>
> On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl <[hidden email]>
> wrote:
>
> > Hi Aishwary,
> >
> > can you elaborate a bit more why a history of GoodIdentification is
> needed?
> >
> > It is used for identification numbers as ISBN, EAN etc.. Those numbers
> > are rarely subject to change for the same product.
> >
> > I don't see any use case for history tracking so I would appreciate some
> > examples.
> >
> > Thanks,
> >
> > Michael Brohl
> >
> > ecomify GmbH - www.ecomify.de
> >
> >
> > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > > Hello, Devs
> > >
> > > We should add support of fromDate and thruDate in the
> GoodIdentification
> > > entity for tracking and history purpose.
> > >
> > > As of now, if we need to update any Good Identification record for a
> > > product, then we have to replace its value and this history isn't
> > > maintained.
> > > It will also enable the user to maintain multiple goodIdentifications
> of
> > a
> > > product.
> > >
> > > Best,
> > > *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/
> >
> > >
> >
> >
>

[Devanshu Vyas-2]

Agree with Rishi here, and a -1 for the proposal.

The GoodIdentification or the PartyIdentification entity should only
contain the information to uniquely identify a product(which said by
everyone, is rarely), so adding fromDate/thruDate will not be much
beneficial.
On the other hand, the GoodIdentificationHistory could be a good
alternative approach to what you are suggesting here.

Thanks & Regards,
Devanshu Vyas.


On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki <[hidden email]>
wrote:

> -1 for the proposal.
> For a product identification code will be one of one type. The universal
> data model book by Len Silverston suggested the same.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: [phone]
>
>
> On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl <[hidden email]>
> wrote:
>
> > Hi Aishwary,
> >
> > can you elaborate a bit more why a history of GoodIdentification is
> needed?
> >
> > It is used for identification numbers as ISBN, EAN etc.. Those numbers
> > are rarely subject to change for the same product.
> >
> > I don't see any use case for history tracking so I would appreciate some
> > examples.
> >
> > Thanks,
> >
> > Michael Brohl
> >
> > ecomify GmbH - www.ecomify.de
> >
> >
> > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > > Hello, Devs
> > >
> > > We should add support of fromDate and thruDate in the
> GoodIdentification
> > > entity for tracking and history purpose.
> > >
> > > As of now, if we need to update any Good Identification record for a
> > > product, then we have to replace its value and this history isn't
> > > maintained.
> > > It will also enable the user to maintain multiple goodIdentifications
> of
> > a
> > > product.
> > >
> > > Best,
> > > *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/
> >
> > >
> >
> >
>

[Aishwary Shrivastava]

Thanks so much, everyone for the valuable feedback.

This indeed increases my understanding.  Based on inputs I will have more
look into this.
For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in
the future if required.


[1] https://issues.apache.org/jira/browse/OFBIZ-10963

Kind Regards,
*Aishwary Shrivastava* | Senior Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Cell phone: [phone]
Linkedin: *Aishwary Shrivastava*
<https://www.linkedin.com/in/aishwaryshrivastava/>


On Sat, Apr 27, 2019 at 8:08 PM Devanshu Vyas <[hidden email]>
wrote:

> Agree with Rishi here, and a -1 for the proposal.
>
> The GoodIdentification or the PartyIdentification entity should only
> contain the information to uniquely identify a product(which said by
> everyone, is rarely), so adding fromDate/thruDate will not be much
> beneficial.
> On the other hand, the GoodIdentificationHistory could be a good
> alternative approach to what you are suggesting here.
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki <[hidden email]>
> wrote:
>
> > -1 for the proposal.
> > For a product identification code will be one of one type. The universal
> > data model book by Len Silverston suggested the same.
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: [phone]
> >
> >
> > On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl <[hidden email]>
> > wrote:
> >
> > > Hi Aishwary,
> > >
> > > can you elaborate a bit more why a history of GoodIdentification is
> > needed?
> > >
> > > It is used for identification numbers as ISBN, EAN etc.. Those numbers
> > > are rarely subject to change for the same product.
> > >
> > > I don't see any use case for history tracking so I would appreciate
> some
> > > examples.
> > >
> > > Thanks,
> > >
> > > Michael Brohl
> > >
> > > ecomify GmbH - www.ecomify.de
> > >
> > >
> > > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > > > Hello, Devs
> > > >
> > > > We should add support of fromDate and thruDate in the
> > GoodIdentification
> > > > entity for tracking and history purpose.
> > > >
> > > > As of now, if we need to update any Good Identification record for a
> > > > product, then we have to replace its value and this history isn't
> > > > maintained.
> > > > It will also enable the user to maintain multiple goodIdentifications
> > of
> > > a
> > > > product.
> > > >
> > > > Best,
> > > > *Aishwary Shrivastava* | HotWax Systems <
> http://www.hotwaxsystems.com/
> > >
> > > >
> > >
> > >
> >
>

[Aishwary Shrivastava]

Thanks so much, everyone for the valuable feedback.

This indeed increases my understanding.  Based on inputs I will have more
look into this.
For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in
the future if required.


[1] https://issues.apache.org/jira/browse/OFBIZ-10963

Best,
*Aishwary Shrivastava*



On Sat, Apr 27, 2019 at 8:08 PM Devanshu Vyas <[hidden email]>
wrote:

> Agree with Rishi here, and a -1 for the proposal.
>
> The GoodIdentification or the PartyIdentification entity should only
> contain the information to uniquely identify a product(which said by
> everyone, is rarely), so adding fromDate/thruDate will not be much
> beneficial.
> On the other hand, the GoodIdentificationHistory could be a good
> alternative approach to what you are suggesting here.
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki <[hidden email]>
> wrote:
>
> > -1 for the proposal.
> > For a product identification code will be one of one type. The universal
> > data model book by Len Silverston suggested the same.
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Linkedin: *Rishi Solanki*
> > <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> > Direct: [phone]
> >
> >
> > On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl <[hidden email]>
> > wrote:
> >
> > > Hi Aishwary,
> > >
> > > can you elaborate a bit more why a history of GoodIdentification is
> > needed?
> > >
> > > It is used for identification numbers as ISBN, EAN etc.. Those numbers
> > > are rarely subject to change for the same product.
> > >
> > > I don't see any use case for history tracking so I would appreciate
> some
> > > examples.
> > >
> > > Thanks,
> > >
> > > Michael Brohl
> > >
> > > ecomify GmbH - www.ecomify.de
> > >
> > >
> > > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava:
> > > > Hello, Devs
> > > >
> > > > We should add support of fromDate and thruDate in the
> > GoodIdentification
> > > > entity for tracking and history purpose.
> > > >
> > > > As of now, if we need to update any Good Identification record for a
> > > > product, then we have to replace its value and this history isn't
> > > > maintained.
> > > > It will also enable the user to maintain multiple goodIdentifications
> > of
> > > a
> > > > product.
> > > >
> > > > Best,
> > > > *Aishwary Shrivastava* | HotWax Systems <
> http://www.hotwaxsystems.com/
> > >
> > > >
> > >
> > >
> >
>