Application menu visibility

[Bruno Busco]

Hi,
I was investigating on the reason why the applications menus have each one a
different behaviour regarding the items visibility for a logged/not logged
user.
I mean that when I am not logged in (and system wait for a valid login) some
but not all menu options are hidden, then logging in as admin all options
become visible.
At the moment the following menu items are hidden when the user is not
logged in:
Accounting: Transactions
Manufacturing: All items
Orders: Requests, Quotes, Order list, Find orders, Order entry, Returns,
Requirements, Order tasks
Pary: Create, Linkparty, Security
Project: Resources, Timesheet, Skilltime, Requestlist

The other applications have all items always enabled.
I think that all applications should work like the Manufacturing application
that do not show any option in the menu if the option is not available to
the user.

Do someone agree on this?

[Bilgin Ibryam]

> Do someone agree on this?

I agree with you. Please feel free to open a Jira issue for it.
I can review/commit.

Bilgin

[Bruno Busco]

Done:
https://issues.apache.org/jira/browse/OFBIZ-1753

-Bruno

2008/4/15, Bilgin Ibryam <[hidden email]>:

>
> > Do someone agree on this?
>
>
> I agree with you. Please feel free to open a Jira issue for it.
> I can review/commit.
>
>
> Bilgin
>
>

[BJ Freeman]

+1
it has been a manpower problem.
once someone commits to do it then it will be as someone originally
intended it.

Bruno Busco sent the following on 4/14/2008 11:00 AM:

> Hi,
> I was investigating on the reason why the applications menus have each one a
> different behaviour regarding the items visibility for a logged/not logged
> user.
> I mean that when I am not logged in (and system wait for a valid login) some
> but not all menu options are hidden, then logging in as admin all options
> become visible.
> At the moment the following menu items are hidden when the user is not
> logged in:
> Accounting: Transactions
> Manufacturing: All items
> Orders: Requests, Quotes, Order list, Find orders, Order entry, Returns,
> Requirements, Order tasks
> Pary: Create, Linkparty, Security
> Project: Resources, Timesheet, Skilltime, Requestlist
>
> The other applications have all items always enabled.
> I think that all applications should work like the Manufacturing application
> that do not show any option in the menu if the option is not available to
> the user.
>
> Do someone agree on this?
>

[Adrian Crum]

OFBiz was set up originally so that all application menu items were
visible, even if the user is logged out. Lately, some developers have
made changes so that only the login menu item is visible when a user is
logged out.

I don't know what the best practice is, or if one has been defined.
Maybe this is a good time to discuss it and add it to the developer
documentation.

-Adrian

BJ Freeman wrote:

> +1
> it has been a manpower problem.
> once someone commits to do it then it will be as someone originally
> intended it.
>
> Bruno Busco sent the following on 4/14/2008 11:00 AM:
>> Hi,
>> I was investigating on the reason why the applications menus have each one a
>> different behaviour regarding the items visibility for a logged/not logged
>> user.
>> I mean that when I am not logged in (and system wait for a valid login) some
>> but not all menu options are hidden, then logging in as admin all options
>> become visible.
>> At the moment the following menu items are hidden when the user is not
>> logged in:
>> Accounting: Transactions
>> Manufacturing: All items
>> Orders: Requests, Quotes, Order list, Find orders, Order entry, Returns,
>> Requirements, Order tasks
>> Pary: Create, Linkparty, Security
>> Project: Resources, Timesheet, Skilltime, Requestlist
>>
>> The other applications have all items always enabled.
>> I think that all applications should work like the Manufacturing application
>> that do not show any option in the menu if the option is not available to
>> the user.
>>
>> Do someone agree on this?
>>
>
>

[Bruno Busco]

A rule of thumb could be "Never display a link that will not take you
anywhere".
So no menu items at all for not logged in and only the available commands
menu items (according to user privileges) for logged in users.

-Bruno


2008/4/15, Adrian Crum <[hidden email]>:

>
> OFBiz was set up originally so that all application menu items were
> visible, even if the user is logged out. Lately, some developers have made
> changes so that only the login menu item is visible when a user is logged
> out.
>
> I don't know what the best practice is, or if one has been defined. Maybe
> this is a good time to discuss it and add it to the developer documentation.
>
> -Adrian
>
> BJ Freeman wrote:
>
> > +1
> > it has been a manpower problem.
> > once someone commits to do it then it will be as someone originally
> > intended it.
> >
> > Bruno Busco sent the following on 4/14/2008 11:00 AM:
> >
> > > Hi,
> > > I was investigating on the reason why the applications menus have each
> > > one a
> > > different behaviour regarding the items visibility for a logged/not
> > > logged
> > > user.
> > > I mean that when I am not logged in (and system wait for a valid
> > > login) some
> > > but not all menu options are hidden, then logging in as admin all
> > > options
> > > become visible.
> > > At the moment the following menu items are hidden when the user is not
> > > logged in:
> > > Accounting: Transactions
> > > Manufacturing: All items
> > > Orders: Requests, Quotes, Order list, Find orders, Order entry,
> > > Returns,
> > > Requirements, Order tasks
> > > Pary: Create, Linkparty, Security
> > > Project: Resources, Timesheet, Skilltime, Requestlist
> > >
> > > The other applications have all items always enabled.
> > > I think that all applications should work like the Manufacturing
> > > application
> > > that do not show any option in the menu if the option is not available
> > > to
> > > the user.
> > >
> > > Do someone agree on this?
> > >
> > >
> >
> >

[Adrian Crum]

+1

Bruno Busco wrote:

> A rule of thumb could be "Never display a link that will not take you
> anywhere".
> So no menu items at all for not logged in and only the available commands
> menu items (according to user privileges) for logged in users.
>
> -Bruno
>
>
> 2008/4/15, Adrian Crum <[hidden email]>:
>> OFBiz was set up originally so that all application menu items were
>> visible, even if the user is logged out. Lately, some developers have made
>> changes so that only the login menu item is visible when a user is logged
>> out.
>>
>> I don't know what the best practice is, or if one has been defined. Maybe
>> this is a good time to discuss it and add it to the developer documentation.
>>
>> -Adrian
>>
>> BJ Freeman wrote:
>>
>>> +1
>>> it has been a manpower problem.
>>> once someone commits to do it then it will be as someone originally
>>> intended it.
>>>
>>> Bruno Busco sent the following on 4/14/2008 11:00 AM:
>>>
>>>> Hi,
>>>> I was investigating on the reason why the applications menus have each
>>>> one a
>>>> different behaviour regarding the items visibility for a logged/not
>>>> logged
>>>> user.
>>>> I mean that when I am not logged in (and system wait for a valid
>>>> login) some
>>>> but not all menu options are hidden, then logging in as admin all
>>>> options
>>>> become visible.
>>>> At the moment the following menu items are hidden when the user is not
>>>> logged in:
>>>> Accounting: Transactions
>>>> Manufacturing: All items
>>>> Orders: Requests, Quotes, Order list, Find orders, Order entry,
>>>> Returns,
>>>> Requirements, Order tasks
>>>> Pary: Create, Linkparty, Security
>>>> Project: Resources, Timesheet, Skilltime, Requestlist
>>>>
>>>> The other applications have all items always enabled.
>>>> I think that all applications should work like the Manufacturing
>>>> application
>>>> that do not show any option in the menu if the option is not available
>>>> to
>>>> the user.
>>>>
>>>> Do someone agree on this?
>>>>
>>>>
>>>
>

[Mridul Pathak-2]

+1

Either show all or none. And I think the best approach is to show none.
--
Thanks & Regards,

Mridul Pathak
Senior Manager
Enterprise Software Development
HotWax Media, Inc.
http://www.hotwaxmedia.com
[hidden email]
-------------------------------------------
Office    : +91 - 509.855.4113
Mobile   : +91 - 942.592.6892





On Apr 15, 2008, at 11:03 PM, Adrian Crum wrote:

> +1
>
> Bruno Busco wrote:
>> A rule of thumb could be "Never display a link that will not take you
>> anywhere".
>> So no menu items at all for not logged in and only the available  
>> commands
>> menu items (according to user privileges) for logged in users.
>> -Bruno
>> 2008/4/15, Adrian Crum <[hidden email]>:
>>> OFBiz was set up originally so that all application menu items were
>>> visible, even if the user is logged out. Lately, some developers  
>>> have made
>>> changes so that only the login menu item is visible when a user is  
>>> logged
>>> out.
>>>
>>> I don't know what the best practice is, or if one has been  
>>> defined. Maybe
>>> this is a good time to discuss it and add it to the developer  
>>> documentation.
>>>
>>> -Adrian
>>>
>>> BJ Freeman wrote:
>>>
>>>> +1
>>>> it has been a manpower problem.
>>>> once someone commits to do it then it will be as someone originally
>>>> intended it.
>>>>
>>>> Bruno Busco sent the following on 4/14/2008 11:00 AM:
>>>>
>>>>> Hi,
>>>>> I was investigating on the reason why the applications menus  
>>>>> have each
>>>>> one a
>>>>> different behaviour regarding the items visibility for a logged/
>>>>> not
>>>>> logged
>>>>> user.
>>>>> I mean that when I am not logged in (and system wait for a valid
>>>>> login) some
>>>>> but not all menu options are hidden, then logging in as admin all
>>>>> options
>>>>> become visible.
>>>>> At the moment the following menu items are hidden when the user  
>>>>> is not
>>>>> logged in:
>>>>> Accounting: Transactions
>>>>> Manufacturing: All items
>>>>> Orders: Requests, Quotes, Order list, Find orders, Order entry,
>>>>> Returns,
>>>>> Requirements, Order tasks
>>>>> Pary: Create, Linkparty, Security
>>>>> Project: Resources, Timesheet, Skilltime, Requestlist
>>>>>
>>>>> The other applications have all items always enabled.
>>>>> I think that all applications should work like the Manufacturing
>>>>> application
>>>>> that do not show any option in the menu if the option is not  
>>>>> available
>>>>> to
>>>>> the user.
>>>>>
>>>>> Do someone agree on this?
>>>>>
>>>>>
>>>>

[Jacques Le Roux]

+1 for none

Jacques

From: "Mridul Pathak" <[hidden email]>

> +1
>
> Either show all or none. And I think the best approach is to show none.
> --
> Thanks & Regards,
>
> Mridul Pathak
> Senior Manager
> Enterprise Software Development
> HotWax Media, Inc.
> http://www.hotwaxmedia.com
> [hidden email]
> -------------------------------------------
> Office    : +91 - 509.855.4113
> Mobile   : +91 - 942.592.6892
>
>
>
>
>
> On Apr 15, 2008, at 11:03 PM, Adrian Crum wrote:
>
>> +1
>>
>> Bruno Busco wrote:
>>> A rule of thumb could be "Never display a link that will not take you
>>> anywhere".
>>> So no menu items at all for not logged in and only the available  
>>> commands
>>> menu items (according to user privileges) for logged in users.
>>> -Bruno
>>> 2008/4/15, Adrian Crum <[hidden email]>:
>>>> OFBiz was set up originally so that all application menu items were
>>>> visible, even if the user is logged out. Lately, some developers  
>>>> have made
>>>> changes so that only the login menu item is visible when a user is  
>>>> logged
>>>> out.
>>>>
>>>> I don't know what the best practice is, or if one has been  
>>>> defined. Maybe
>>>> this is a good time to discuss it and add it to the developer  
>>>> documentation.
>>>>
>>>> -Adrian
>>>>
>>>> BJ Freeman wrote:
>>>>
>>>>> +1
>>>>> it has been a manpower problem.
>>>>> once someone commits to do it then it will be as someone originally
>>>>> intended it.
>>>>>
>>>>> Bruno Busco sent the following on 4/14/2008 11:00 AM:
>>>>>
>>>>>> Hi,
>>>>>> I was investigating on the reason why the applications menus  
>>>>>> have each
>>>>>> one a
>>>>>> different behaviour regarding the items visibility for a logged/
>>>>>> not
>>>>>> logged
>>>>>> user.
>>>>>> I mean that when I am not logged in (and system wait for a valid
>>>>>> login) some
>>>>>> but not all menu options are hidden, then logging in as admin all
>>>>>> options
>>>>>> become visible.
>>>>>> At the moment the following menu items are hidden when the user  
>>>>>> is not
>>>>>> logged in:
>>>>>> Accounting: Transactions
>>>>>> Manufacturing: All items
>>>>>> Orders: Requests, Quotes, Order list, Find orders, Order entry,
>>>>>> Returns,
>>>>>> Requirements, Order tasks
>>>>>> Pary: Create, Linkparty, Security
>>>>>> Project: Resources, Timesheet, Skilltime, Requestlist
>>>>>>
>>>>>> The other applications have all items always enabled.
>>>>>> I think that all applications should work like the Manufacturing
>>>>>> application
>>>>>> that do not show any option in the menu if the option is not  
>>>>>> available
>>>>>> to
>>>>>> the user.
>>>>>>
>>>>>> Do someone agree on this?
>>>>>>
>>>>>>
>>>>>
>
>

[Bilgin Ibryam]

I checked the menu items and found that some of the menu items are visualized after permission check, some after valid userLogin check and the rest are visualized in all cases, even for not logged users, in which case these menu links are not accessible.

Is it OK if I add a userLogin check for the last mentioned menu items?
WDYT?

[Bruno Busco]

Bilgin,
I think it is OK as far as there is no specific permission for the command
linked to the menu.
If a specific permission is defined than, in my opinion, the menu
visualization should be conditioned to that permission (and thus it will not
be visible for not logged in users also).

In any case, if you do what you are proposing, we will improve the interface
in the 90% of cases.

Thank you for looking into this issue:
https://issues.apache.org/jira/browse/OFBIZ-1753

-Bruno




2008/6/3 Bilgin Ibryam <[hidden email]>:

>
> I checked the menu items and found that some of the menu items are
> visualized
> after permission check, some after valid userLogin check and the rest are
> visualized in all cases, even for not logged users, in which case these
> menu
> links are not accessible.
>
> Is it OK if I add a userLogin check for the last mentioned menu items?
> WDYT?
> --
> View this message in context:
> http://www.nabble.com/Application-menu-visibility-tp16685561p17621521.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>
>