Bootstrap in framework folder
Locked
 
|
Hello,
I'm working on the bootstrap theme branch and I have a question that seems to need a full topic. I want to move the bootstrap framework from the theme folder to ofbizroot/framework/image/webapp/image. Why ? Just because if we need any bootstrap rendering, it will be available in the framework. Even if it's for core tools. I don't want to replace old theme but I want to be allow to use bootstrap framework anywhere in the software : - For the login page - For charts widget - For new theme Want do you think ? Thanks, Julien. |
Re: Bootstrap in framework folder
|
|
There is no need to put bootstrap in the framework folder. Any code that
needs it can use the one in the bootstrap theme. Adrian Crum Sandglass Software www.sandglass-software.com On 6/1/2015 12:45 PM, Julien NICOLAS wrote: > Hello, > > I'm working on the bootstrap theme branch and I have a question that > seems to need a full topic. > > I want to move the bootstrap framework from the theme folder to > ofbizroot/framework/image/webapp/image. > > Why ? > Just because if we need any bootstrap rendering, it will be available in > the framework. > Even if it's for core tools. > > I don't want to replace old theme but I want to be allow to use > bootstrap framework anywhere in the software : > - For the login page > - For charts widget > - For new theme > > Want do you think ? > > Thanks, > > Julien. > > |
|
Hi Julien,
I remember in the earlier days of discussion on integrating bootstrap that you were the one who initially hesitated about putting bootstrap in the framework and you wanted the whole thing isolated outside in the theme (the description of OFBIZ-5840 shows that). Are there any difficulties that you encountered which made you reconsider integrating at the framework level? Why not just apply classes to whatever you have in the framework (login screen etc) and then let CSS do its magic? Taher Alkhateeb ----- Original Message ----- From: "Adrian Crum" <[hidden email]> To: [hidden email] Sent: Tuesday, 2 June, 2015 8:07:45 AM Subject: Re: Bootstrap in framework folder There is no need to put bootstrap in the framework folder. Any code that needs it can use the one in the bootstrap theme. Adrian Crum Sandglass Software www.sandglass-software.com On 6/1/2015 12:45 PM, Julien NICOLAS wrote: > Hello, > > I'm working on the bootstrap theme branch and I have a question that > seems to need a full topic. > > I want to move the bootstrap framework from the theme folder to > ofbizroot/framework/image/webapp/image. > > Why ? > Just because if we need any bootstrap rendering, it will be available in > the framework. > Even if it's for core tools. > > I don't want to replace old theme but I want to be allow to use > bootstrap framework anywhere in the software : > - For the login page > - For charts widget > - For new theme > > Want do you think ? > > Thanks, > > Julien. > > |
Re: Bootstrap in framework folder
|
|
In reply to this post by JulienNicolas
Hi Julien
This idea was proposed before and it did not find favour with the community (including yourself). Anyway moving bootstrap theme resources to the framework container will not solve the login page issue. This is because the theme resources are linked to use preferences. So when there is no logged in session Ofbiz uses the default theme which is defined in general.properties. try changing you default theme to bootstrap. Regards Gavin On 01 Jun 2015 9:46 PM, "Julien NICOLAS" <[hidden email]> wrote: > > Hello, > > I'm working on the bootstrap theme branch and I have a question that seems to need a full topic. > > I want to move the bootstrap framework from the theme folder to ofbizroot/framework/image/webapp/image. > > Why ? > Just because if we need any bootstrap rendering, it will be available in the framework. > Even if it's for core tools. > > I don't want to replace old theme but I want to be allow to use bootstrap framework anywhere in the software : > - For the login page > - For charts widget > - For new theme > > Want do you think ? > > Thanks, > > Julien. > > |
Re: Bootstrap in framework folder
|
|
Having the theme behave as a self contained component gives you
configurability and flexibility. See https://issues.apache.org/jira/browse/OFBIZ-6362. The Bootstrap theme can be treated as such. Best regards, Pierre Smits *ORRTIZ.COM <http://www.orrtiz.com>* Services & Solutions for Cloud- Based Manufacturing, Professional Services and Retail & Trade http://www.orrtiz.com On Tue, Jun 2, 2015 at 8:03 AM, Gavin Mabie <[hidden email]> wrote: > Hi Julien > > This idea was proposed before and it did not find favour with the community > (including yourself). Anyway moving bootstrap theme resources to the > framework container will not solve the login page issue. This is because > the theme resources are linked to use preferences. So when there is no > logged in session Ofbiz uses the default theme which is defined in > general.properties. try changing you default theme to bootstrap. > > Regards > > Gavin > On 01 Jun 2015 9:46 PM, "Julien NICOLAS" <[hidden email]> wrote: > > > > Hello, > > > > I'm working on the bootstrap theme branch and I have a question that > seems to need a full topic. > > > > I want to move the bootstrap framework from the theme folder to > ofbizroot/framework/image/webapp/image. > > > > Why ? > > Just because if we need any bootstrap rendering, it will be available in > the framework. > > Even if it's for core tools. > > > > I don't want to replace old theme but I want to be allow to use bootstrap > framework anywhere in the software : > > - For the login page > > - For charts widget > > - For new theme > > > > Want do you think ? > > > > Thanks, > > > > Julien. > > > > > |
Re: Bootstrap in framework folder
|
|
In reply to this post by taher
Le 02/06/2015 07:16, Taher Alkhateeb a écrit : > Hi Julien, > > I remember in the earlier days of discussion on integrating bootstrap that you were the one who initially hesitated about putting bootstrap in the framework and you wanted the whole thing isolated outside in the theme No, I was against to have menu and other html standard structure in the framework. > (the description of OFBIZ-5840 shows that). > > Are there any difficulties that you encountered which made you reconsider integrating at the framework level? Why not just apply classes to whatever you have in the framework (login screen etc) and then let CSS do its magic? It could be interesting to have it in the framework to be able to add some tools. I just think about this kind of charts : http://ironsummitmedia.github.io/startbootstrap-sb-admin-2/pages/index.html (area chart, bar chart and donut chart) I plan to add each charts as a easy to use tool. And I think it could be logical to use a framework tool (bootstrap) and not a tool in an external theme for rendering... Maybe I have to know what are the criteria to add something in the framework :) Thanks for your help :) Julien. > > Taher Alkhateeb > > ----- Original Message ----- > > From: "Adrian Crum" <[hidden email]> > To: [hidden email] > Sent: Tuesday, 2 June, 2015 8:07:45 AM > Subject: Re: Bootstrap in framework folder > > There is no need to put bootstrap in the framework folder. Any code that > needs it can use the one in the bootstrap theme. > > Adrian Crum > Sandglass Software > www.sandglass-software.com > > On 6/1/2015 12:45 PM, Julien NICOLAS wrote: >> Hello, >> >> I'm working on the bootstrap theme branch and I have a question that >> seems to need a full topic. >> >> I want to move the bootstrap framework from the theme folder to >> ofbizroot/framework/image/webapp/image. >> >> Why ? >> Just because if we need any bootstrap rendering, it will be available in >> the framework. >> Even if it's for core tools. >> >> I don't want to replace old theme but I want to be allow to use >> bootstrap framework anywhere in the software : >> - For the login page >> - For charts widget >> - For new theme >> >> Want do you think ? >> >> Thanks, >> >> Julien. >> >> > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |