Bug in setPaymentStatus service?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in setPaymentStatus service?

Anne Jessel
Hi

I'm trying to learn my way around this part of OFBiz, and am finding the way payments work is totally different from my expectations. So I'm not completely sure this is a bug, but it looks very suspicious.

The setPaymentStatus service has the following:

        <entity-one entity-name="Payment" value-field="payment"/>
        <field-to-result field="payment.paymentId" result-name="oldStatusId"/>

(line 174, applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml, Release09.04)

Shouldn't the value for the attribute 'field' be 'payment.statusId'? Or is there a good reason that it isn't?

Cheers,
Anne.

--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Phone: (03) 9585 6788
Fax: (03) 9585 1086
Web: http://www.cohsoft.com.au/
Email: [hidden email]

Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/


signature.asc (278 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug in setPaymentStatus service?

Scott Gray-2
Hi Anne,

It certainly looks like a bug to me :-)

I haven't got time to look into it further right now, hopefully  
someone else can otherwise I would suggest creating a Jira issue in a  
day or two so it doesn't get lost.

Regards
Scott

On 4/08/2009, at 2:05 PM, [hidden email] wrote:

> Hi
>
> I'm trying to learn my way around this part of OFBiz, and am finding  
> the way payments work is totally different from my expectations. So  
> I'm not completely sure this is a bug, but it looks very suspicious.
>
> The setPaymentStatus service has the following:
>
>         <entity-one entity-name="Payment" value-field="payment"/>
>         <field-to-result field="payment.paymentId" result-
> name="oldStatusId"/>
>
> (line 174, applications/accounting/script/org/ofbiz/accounting/
> payment/PaymentServices.xml, Release09.04)
>
> Shouldn't the value for the attribute 'field' be 'payment.statusId'?  
> Or is there a good reason that it isn't?
>
> Cheers,
> Anne.
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Phone: (03) 9585 6788
> Fax: (03) 9585 1086
> Web: http://www.cohsoft.com.au/
> Email: [hidden email]
>
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
>


smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug in setPaymentStatus service?

Anne Jessel
Thanks Scott.

I'll create a Jira issue, and put in a patch. The patch reviewer can work out whether it's really a bug. :-)

Cheers,
Anne.

2009/8/4 Scott Gray <[hidden email]>
Hi Anne,

It certainly looks like a bug to me :-)

I haven't got time to look into it further right now, hopefully someone else can otherwise I would suggest creating a Jira issue in a day or two so it doesn't get lost.

Regards
Scott


On 4/08/2009, at 2:05 PM, [hidden email] wrote:

Hi

I'm trying to learn my way around this part of OFBiz, and am finding the way payments work is totally different from my expectations. So I'm not completely sure this is a bug, but it looks very suspicious.

The setPaymentStatus service has the following:

       <entity-one entity-name="Payment" value-field="payment"/>
       <field-to-result field="payment.paymentId" result-name="oldStatusId"/>

(line 174, applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml, Release09.04)

Shouldn't the value for the attribute 'field' be 'payment.statusId'? Or is there a good reason that it isn't?

Cheers,
Anne.

--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Phone: (03) 9585 6788
Fax: (03) 9585 1086
Web: http://www.cohsoft.com.au/
Email: [hidden email]

Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/





--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Phone: (03) 9585 6788
Fax: (03) 9585 1086
Web: http://www.cohsoft.com.au/
Email: [hidden email]

Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/


signature.asc (278 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug in setPaymentStatus service?

Scott Gray-2
Thanks Anne, I would say it is definitely a bug the only thing to  
possibly check is that nothing else will break when it gets fixed.

Regards
Scott

On 4/08/2009, at 3:18 PM, [hidden email] wrote:

> Thanks Scott.
>
> I'll create a Jira issue, and put in a patch. The patch reviewer can  
> work out whether it's really a bug. :-)
>
> Cheers,
> Anne.
>
> 2009/8/4 Scott Gray <[hidden email]>
> Hi Anne,
>
> It certainly looks like a bug to me :-)
>
> I haven't got time to look into it further right now, hopefully  
> someone else can otherwise I would suggest creating a Jira issue in  
> a day or two so it doesn't get lost.
>
> Regards
> Scott
>
>
> On 4/08/2009, at 2:05 PM, [hidden email] wrote:
>
> Hi
>
> I'm trying to learn my way around this part of OFBiz, and am finding  
> the way payments work is totally different from my expectations. So  
> I'm not completely sure this is a bug, but it looks very suspicious.
>
> The setPaymentStatus service has the following:
>
>        <entity-one entity-name="Payment" value-field="payment"/>
>        <field-to-result field="payment.paymentId" result-
> name="oldStatusId"/>
>
> (line 174, applications/accounting/script/org/ofbiz/accounting/
> payment/PaymentServices.xml, Release09.04)
>
> Shouldn't the value for the attribute 'field' be 'payment.statusId'?  
> Or is there a good reason that it isn't?
>
> Cheers,
> Anne.
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Phone: (03) 9585 6788
> Fax: (03) 9585 1086
> Web: http://www.cohsoft.com.au/
> Email: [hidden email]
>
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
>
>
>
>
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Phone: (03) 9585 6788
> Fax: (03) 9585 1086
> Web: http://www.cohsoft.com.au/
> Email: [hidden email]
>
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
>


smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug in setPaymentStatus service?

Sumit Pandit-3
In reply to this post by Anne Jessel
Hi Anne,

Thanks for reporting this, please create a jira issue and submit the  
patch at it. I'll verify if it will effect the system anywhere.

--
Regards
Sumit Pandit
On Aug 4, 2009, at 7:35 AM, [hidden email] wrote:

> Hi
>
> I'm trying to learn my way around this part of OFBiz, and am finding  
> the way payments work is totally different from my expectations. So  
> I'm not completely sure this is a bug, but it looks very suspicious.
>
> The setPaymentStatus service has the following:
>
>         <entity-one entity-name="Payment" value-field="payment"/>
>         <field-to-result field="payment.paymentId" result-
> name="oldStatusId"/>
>
> (line 174, applications/accounting/script/org/ofbiz/accounting/
> payment/PaymentServices.xml, Release09.04)
>
> Shouldn't the value for the attribute 'field' be 'payment.statusId'?  
> Or is there a good reason that it isn't?
>
> Cheers,
> Anne.
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Phone: (03) 9585 6788
> Fax: (03) 9585 1086
> Web: http://www.cohsoft.com.au/
> Email: [hidden email]
>
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
>