Check Style on release branches?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Check Style on release branches?

Jacques Le Roux
Administrator
Hi,

While discussing with Aditya at OFBIZ-11304 I asked

    <<What about checking branches? The hook is present in all branches but not checkstyle>>

He suggested, and I tend to agree:

    <<I think we should add it to all branches. We are not making any major change to OFBiz rather it is an add-on to the development process. Wdyt?>>

What are your opinions? There are more information if needed at OFBIZ-11304

Thanks

Jacques

Reply | Threaded
Open this post in threaded view
|

Re: Check Style on release branches?

adityasharma
Hi Jacques,

Thanks for initiating the discussion. Considering the lazy consensus, I
reopen OFBIZ-11251 <https://issues.apache.org/jira/browse/OFBIZ-11251>

Thanks and Regards,
Aditya Sharma

On Wed, Jun 17, 2020 at 1:44 PM Jacques Le Roux <
[hidden email]> wrote:

> Hi,
>
> While discussing with Aditya at OFBIZ-11304 I asked
>
>     <<What about checking branches? The hook is present in all branches
> but not checkstyle>>
>
> He suggested, and I tend to agree:
>
>     <<I think we should add it to all branches. We are not making any
> major change to OFBiz rather it is an add-on to the development process.
> Wdyt?>>
>
> What are your opinions? There are more information if needed at OFBIZ-11304
>
> Thanks
>
> Jacques
>
>