Common-theme next step
Locked
12
12
 
|
Hello;
To continue the common-theme subject, I haven't see negative return to the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same subject [2] and the additional theme xml definition [3], I suggest to create a documentation on the wiki how work the "theme engine" and commit the current git branch [4] [5] on trunk After that, the engine will be present on the trunk and we continue the work to : * Clean the common-theme and create a real theme * Migrate properly the current theme with the new structure * Analyze more how organize the screen api But don't panic, before that I'm listening to all suggest or remarks ;) Nicolas [1] https://issues.apache.org/jira/browse/OFBIZ-9138 [2] https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E [3] https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme [5] https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 -- logoNrd <https://nereide.fr/> Nicolas Malin The apache way <http://theapacheway.com/> : *Openness* Technical decisions are made publicly [hidden email] 8 rue des Déportés 37000 TOURS, 02 47 50 30 54 Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way <http://theapacheway.com/>|ofbiz-fr <http://www.ofbiz-fr.org/>|réseau LE <http://www.libre-entreprise.org/> |
|
|
Hi Nicolas,
thank you very much for your ongoing work on this topic, I greatly appreciate it :-) I'm looking forward to have a deeper look into your solutions but have to wait until my return on end of August. The concept, as I understand it, provides an extendable mechanism to build themes on base of other themes, which seems very flexible. I'm in favor to have you commit the changes to trunk as long as they don't break existing functionality and themes. It would be much easier to work together then. I'll have some detailed questions which I will put in another message to prevent confusion. Again, thank you very much for your efforts, Best regards, Michael Am 16.08.17 um 13:49 schrieb Nicolas Malin: > Hello; > > To continue the common-theme subject, I haven't see negative return to > the issue Create a common theme (OFBIZ-9138) [1] and on threads on the > same subject [2] and the additional theme xml definition [3], I > suggest to create a documentation on the wiki how work the "theme > engine" and commit the current git branch [4] [5] on trunk > > After that, the engine will be present on the trunk and we continue > the work to : > * Clean the common-theme and create a real theme > * Migrate properly the current theme with the new structure > * Analyze more how organize the screen api > > But don't panic, before that I'm listening to all suggest or remarks ;) > > Nicolas > > [1] https://issues.apache.org/jira/browse/OFBIZ-9138 > [2] > https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E > [3] > https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E > [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme > [5] > https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 > > |
smime.p7s (5K)
common-theme questions, was: Re: Common-theme next step
|
|
In reply to this post by Nicolas Malin-2
Hi Nicolas,
During my work on the bootstrap theme [1] (which got stuck due to other tasks) I stumbled upon some problems which possibly get solved by your approach or we can consider a solution for it during the work. In detail, I'm referring to [2] where you had the same problem I'm facing: Instead of displaying the application menu bar when it is active I want to have the menu items as sub level items in a global navigation sidebar. It does not seem to be possible completely dynamically because of the configuration inside the screen definitions but it might be better doable if we would have a configuration standard for the menus, using always the same patterns (convention over configuration). Do you already have an idea how to solve this/ will the new approach help with this? Another base question is how we can provide different style classes and ids to the base html code so that we can reuse the html but use different UI frameworks with their specific style class terminology. It would be great if users can choose their preferred UI framework like Bootstrap, Foundation & Co. to build new themes. Will this be covered by your approach? [1] https://lists.apache.org/thread.html/de49bb2fd2f9c82ab99bd08e603e9625c9c5a532a80b5226ccd5a4fc@%3Cdev.ofbiz.apache.org%3E [2] https://lists.apache.org/thread.html/91e3e5cab3b233f9587d69f0419eb652744cc5afcd39bc97df269ace@1444926106@%3Cuser.ofbiz.apache.org%3E Thanks, Michael Am 16.08.17 um 13:49 schrieb Nicolas Malin: > Hello; > > To continue the common-theme subject, I haven't see negative return to > the issue Create a common theme (OFBIZ-9138) [1] and on threads on the > same subject [2] and the additional theme xml definition [3], I > suggest to create a documentation on the wiki how work the "theme > engine" and commit the current git branch [4] [5] on trunk > > After that, the engine will be present on the trunk and we continue > the work to : > * Clean the common-theme and create a real theme > * Migrate properly the current theme with the new structure > * Analyze more how organize the screen api > > But don't panic, before that I'm listening to all suggest or remarks ;) > > Nicolas > > [1] https://issues.apache.org/jira/browse/OFBIZ-9138 > [2] > https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E > [3] > https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E > [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme > [5] > https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 > > |
Re: common-theme questions, was: Re: Common-theme next step
|
|
Hello Michael
Nice questions :) in line Le 17/08/2017 à 11:06, Michael Brohl a écrit : > Hi Nicolas, > > During my work on the bootstrap theme [1] (which got stuck due to > other tasks) I stumbled upon some problems which possibly get solved > by your approach or we can consider a solution for it during the work. > > In detail, I'm referring to [2] where you had the same problem I'm > facing: Instead of displaying the application menu bar when it is > active I want to have the menu items as sub level items in a global > navigation sidebar. It does not seem to be possible completely > dynamically because of the configuration inside the screen definitions > but it might be better doable if we would have a configuration > standard for the menus, using always the same patterns (convention > over configuration). > > Do you already have an idea how to solve this/ will the new approach > help with this? * access to the model * rendering the model The first aspect isn't manage by themes, we need to understand what missed on the modelScreen to improve it by technology or by convention. But for the second it's completely cover by themes. To do that, you can surcharge just the decorator definition or the macro ftl library that you need. > Another base question is how we can provide different style classes > and ids to the base html code so that we can reuse the html but use > different UI frameworks with their specific style class terminology. > It would be great if users can choose their preferred UI framework > like Bootstrap, Foundation & Co. to build new themes. Will this be > covered by your approach? The screen definition need to embed the minimum css set as convention and maximum ids element. After that, you can define your own decorator to load needed library or something like that and rewrite the macro ftl to adapt the rendering. With the theme dependency, you can also create a base theme like boostrap-base that implement common-theme for all non html macro, surchage all html macro library. Each new boostrap-theme can be implement boostrap-base for all specific technical rendering and just import their own class Cheers, Nicolas > > [1] > https://lists.apache.org/thread.html/de49bb2fd2f9c82ab99bd08e603e9625c9c5a532a80b5226ccd5a4fc@%3Cdev.ofbiz.apache.org%3E > > [2] > https://lists.apache.org/thread.html/91e3e5cab3b233f9587d69f0419eb652744cc5afcd39bc97df269ace@1444926106@%3Cuser.ofbiz.apache.org%3E > > Thanks, > Michael > > > Am 16.08.17 um 13:49 schrieb Nicolas Malin: >> Hello; >> >> To continue the common-theme subject, I haven't see negative return >> to the issue Create a common theme (OFBIZ-9138) [1] and on threads on >> the same subject [2] and the additional theme xml definition [3], I >> suggest to create a documentation on the wiki how work the "theme >> engine" and commit the current git branch [4] [5] on trunk >> >> After that, the engine will be present on the trunk and we continue >> the work to : >> * Clean the common-theme and create a real theme >> * Migrate properly the current theme with the new structure >> * Analyze more how organize the screen api >> >> But don't panic, before that I'm listening to all suggest or remarks ;) >> >> Nicolas >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >> [2] >> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >> [3] >> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >> [5] >> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >> >> > > |
|
|
In reply to this post by Michael Brohl-3
Hi Michael,
Le 17/08/2017 à 10:44, Michael Brohl a écrit : > Hi Nicolas, > > thank you very much for your ongoing work on this topic, I greatly > appreciate it :-) :) thanks, you escape me from the loneliness > > I'm looking forward to have a deeper look into your solutions but have > to wait until my return on end of August. The concept, as I understand > it, provides an extendable mechanism to build themes on base of other > themes, which seems very flexible. It's exactly the purpose with keep in mind to separate the model and convention on framework and all surcharge for the rendering or structure page in themes > > I'm in favor to have you commit the changes to trunk as long as they > don't break existing functionality and themes. It would be much easier > to work together then. Normally I haven't detected a major regression. Just detect a problem when you have some sessions already enabled, when you change your theme, it's updated only on the current session where you did it and the newer. But the others enabled session keep the previous theme. If some people are feedback on some regression, I'm really happy to understand and resolve it but I'm fear that we need to wait the commit in trunk. Cheers Nicolas > > I'll have some detailed questions which I will put in another message > to prevent confusion. > > Again, thank you very much for your efforts, > > Best regards, > > Michael > > > > Am 16.08.17 um 13:49 schrieb Nicolas Malin: >> Hello; >> >> To continue the common-theme subject, I haven't see negative return >> to the issue Create a common theme (OFBIZ-9138) [1] and on threads on >> the same subject [2] and the additional theme xml definition [3], I >> suggest to create a documentation on the wiki how work the "theme >> engine" and commit the current git branch [4] [5] on trunk >> >> After that, the engine will be present on the trunk and we continue >> the work to : >> * Clean the common-theme and create a real theme >> * Migrate properly the current theme with the new structure >> * Analyze more how organize the screen api >> >> But don't panic, before that I'm listening to all suggest or remarks ;) >> >> Nicolas >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >> [2] >> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >> [3] >> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >> [5] >> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >> >> > > |
|
|
In reply to this post by Nicolas Malin-2
Hello,
I started the documentation here https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md It's a begging, I hope improve it quickly Nicolas Le 16/08/2017 à 13:49, Nicolas Malin a écrit : > Hello; > > To continue the common-theme subject, I haven't see negative return to > the issue Create a common theme (OFBIZ-9138) [1] and on threads on the > same subject [2] and the additional theme xml definition [3], I > suggest to create a documentation on the wiki how work the "theme > engine" and commit the current git branch [4] [5] on trunk > > After that, the engine will be present on the trunk and we continue > the work to : > * Clean the common-theme and create a real theme > * Migrate properly the current theme with the new structure > * Analyze more how organize the screen api > > But don't panic, before that I'm listening to all suggest or remarks ;) > > Nicolas > > [1] https://issues.apache.org/jira/browse/OFBIZ-9138 > [2] > https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E > [3] > https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E > [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme > [5] > https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 > > |
Administrator
|
That sounds great,
Thanks Nicolas! Jacques Le 17/08/2017 à 22:00, Nicolas Malin a écrit : > Hello, > > I started the documentation here https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md > > It's a begging, I hope improve it quickly > > Nicolas > > > Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >> Hello; >> >> To continue the common-theme subject, I haven't see negative return to the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same >> subject [2] and the additional theme xml definition [3], I suggest to create a documentation on the wiki how work the "theme engine" and commit the >> current git branch [4] [5] on trunk >> >> After that, the engine will be present on the trunk and we continue the work to : >> * Clean the common-theme and create a real theme >> * Migrate properly the current theme with the new structure >> * Analyze more how organize the screen api >> >> But don't panic, before that I'm listening to all suggest or remarks ;) >> >> Nicolas >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >> [2] https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >> [3] https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >> [5] https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >> >> > > |
|
Like Michael, I also prefer to include the work into the code base and
test it over there. It seems like you put a lot of effort into this code so thank you! I like the fact that you brought all the artifacts into the theme along with the FTL macros. This is a good first step, and I believe continuing on this direction is where we need to go. +1 to committing into the code base and testing over there. On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux <[hidden email]> wrote: > That sounds great, > > Thanks Nicolas! > > Jacques > > > Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >> >> Hello, >> >> I started the documentation here >> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >> >> It's a begging, I hope improve it quickly >> >> Nicolas >> >> >> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>> >>> Hello; >>> >>> To continue the common-theme subject, I haven't see negative return to >>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same >>> subject [2] and the additional theme xml definition [3], I suggest to create >>> a documentation on the wiki how work the "theme engine" and commit the >>> current git branch [4] [5] on trunk >>> >>> After that, the engine will be present on the trunk and we continue the >>> work to : >>> * Clean the common-theme and create a real theme >>> * Migrate properly the current theme with the new structure >>> * Analyze more how organize the screen api >>> >>> But don't panic, before that I'm listening to all suggest or remarks ;) >>> >>> Nicolas >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>> [2] >>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>> [3] >>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>> [5] >>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>> >>> >> >> > |
|
|
Thanks,
I will commit on trunk after a second review of my code because i was concentrated to increase the flexibility with macro and screen but not manage correctly the VisualTheme concept. So I will take care about this, complete the documentation and commit on trunk. Nicolas Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : > Like Michael, I also prefer to include the work into the code base and > test it over there. It seems like you put a lot of effort into this > code so thank you! I like the fact that you brought all the artifacts > into the theme along with the FTL macros. This is a good first step, > and I believe continuing on this direction is where we need to go. > > +1 to committing into the code base and testing over there. > > On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux > <[hidden email]> wrote: >> That sounds great, >> >> Thanks Nicolas! >> >> Jacques >> >> >> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>> Hello, >>> >>> I started the documentation here >>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>> >>> It's a begging, I hope improve it quickly >>> >>> Nicolas >>> >>> >>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>> Hello; >>>> >>>> To continue the common-theme subject, I haven't see negative return to >>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same >>>> subject [2] and the additional theme xml definition [3], I suggest to create >>>> a documentation on the wiki how work the "theme engine" and commit the >>>> current git branch [4] [5] on trunk >>>> >>>> After that, the engine will be present on the trunk and we continue the >>>> work to : >>>> * Clean the common-theme and create a real theme >>>> * Migrate properly the current theme with the new structure >>>> * Analyze more how organize the screen api >>>> >>>> But don't panic, before that I'm listening to all suggest or remarks ;) >>>> >>>> Nicolas >>>> >>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>> [2] >>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>> [3] >>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>> [5] >>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>> >>>> >>> |
|
Administrator
|
Thanks Nicolas,
Looking forward Jacques Le 21/08/2017 à 09:55, Nicolas Malin a écrit : > Thanks, > > I will commit on trunk after a second review of my code because i was concentrated to increase the flexibility with macro and screen but not manage > correctly the VisualTheme concept. > > So I will take care about this, complete the documentation and commit on trunk. > > Nicolas > > Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >> Like Michael, I also prefer to include the work into the code base and >> test it over there. It seems like you put a lot of effort into this >> code so thank you! I like the fact that you brought all the artifacts >> into the theme along with the FTL macros. This is a good first step, >> and I believe continuing on this direction is where we need to go. >> >> +1 to committing into the code base and testing over there. >> >> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >> <[hidden email]> wrote: >>> That sounds great, >>> >>> Thanks Nicolas! >>> >>> Jacques >>> >>> >>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>> Hello, >>>> >>>> I started the documentation here >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>>> >>>> It's a begging, I hope improve it quickly >>>> >>>> Nicolas >>>> >>>> >>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>> Hello; >>>>> >>>>> To continue the common-theme subject, I haven't see negative return to >>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same >>>>> subject [2] and the additional theme xml definition [3], I suggest to create >>>>> a documentation on the wiki how work the "theme engine" and commit the >>>>> current git branch [4] [5] on trunk >>>>> >>>>> After that, the engine will be present on the trunk and we continue the >>>>> work to : >>>>> * Clean the common-theme and create a real theme >>>>> * Migrate properly the current theme with the new structure >>>>> * Analyze more how organize the screen api >>>>> >>>>> But don't panic, before that I'm listening to all suggest or remarks ;) >>>>> >>>>> Nicolas >>>>> >>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>> [2] >>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>> [3] >>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>> [5] >>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>>> >>>>> >>>> > > |
|
|
In reply to this post by Nicolas Malin-2
Hi Nicolas,
If it helps you, I suggest to isolate files / code where you are not very comfortable and put them in a separate patch (not the full patch) with an explanation of what you've done and where you feel a little hesitant or uneasy. I think if you make us focus with you on very specific pieces of code then our review will be faster and your confidence of the review will be better. On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin <[hidden email]> wrote: > Thanks, > > I will commit on trunk after a second review of my code because i was > concentrated to increase the flexibility with macro and screen but not > manage correctly the VisualTheme concept. > > So I will take care about this, complete the documentation and commit on > trunk. > > Nicolas > > > Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >> >> Like Michael, I also prefer to include the work into the code base and >> test it over there. It seems like you put a lot of effort into this >> code so thank you! I like the fact that you brought all the artifacts >> into the theme along with the FTL macros. This is a good first step, >> and I believe continuing on this direction is where we need to go. >> >> +1 to committing into the code base and testing over there. >> >> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >> <[hidden email]> wrote: >>> >>> That sounds great, >>> >>> Thanks Nicolas! >>> >>> Jacques >>> >>> >>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>> >>>> Hello, >>>> >>>> I started the documentation here >>>> >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>>> >>>> It's a begging, I hope improve it quickly >>>> >>>> Nicolas >>>> >>>> >>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>> >>>>> Hello; >>>>> >>>>> To continue the common-theme subject, I haven't see negative return to >>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the >>>>> same >>>>> subject [2] and the additional theme xml definition [3], I suggest to >>>>> create >>>>> a documentation on the wiki how work the "theme engine" and commit the >>>>> current git branch [4] [5] on trunk >>>>> >>>>> After that, the engine will be present on the trunk and we continue the >>>>> work to : >>>>> * Clean the common-theme and create a real theme >>>>> * Migrate properly the current theme with the new structure >>>>> * Analyze more how organize the screen api >>>>> >>>>> But don't panic, before that I'm listening to all suggest or remarks ;) >>>>> >>>>> Nicolas >>>>> >>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>> [2] >>>>> >>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>> [3] >>>>> >>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>> [5] >>>>> >>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>>> >>>>> >>>> > |
|
|
Hi Taher,
If you have few time to have a look on these three class : https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java ModelTheme is java class to load all Theme definition who interact with the system VisualTheme is java class regards the VisualTheme entity who interact with the user to exploit the modelTheme ThemeFactory is the factory to create both. I prepare my commits, but I need to separate properly each code modification to help other learn the work. Cheers, Nicolas Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : > Hi Nicolas, > > If it helps you, I suggest to isolate files / code where you are not > very comfortable and put them in a separate patch (not the full patch) > with an explanation of what you've done and where you feel a little > hesitant or uneasy. I think if you make us focus with you on very > specific pieces of code then our review will be faster and your > confidence of the review will be better. > > On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin > <[hidden email]> wrote: >> Thanks, >> >> I will commit on trunk after a second review of my code because i was >> concentrated to increase the flexibility with macro and screen but not >> manage correctly the VisualTheme concept. >> >> So I will take care about this, complete the documentation and commit on >> trunk. >> >> Nicolas >> >> >> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>> Like Michael, I also prefer to include the work into the code base and >>> test it over there. It seems like you put a lot of effort into this >>> code so thank you! I like the fact that you brought all the artifacts >>> into the theme along with the FTL macros. This is a good first step, >>> and I believe continuing on this direction is where we need to go. >>> >>> +1 to committing into the code base and testing over there. >>> >>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>> <[hidden email]> wrote: >>>> That sounds great, >>>> >>>> Thanks Nicolas! >>>> >>>> Jacques >>>> >>>> >>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>> Hello, >>>>> >>>>> I started the documentation here >>>>> >>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>>>> >>>>> It's a begging, I hope improve it quickly >>>>> >>>>> Nicolas >>>>> >>>>> >>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>> Hello; >>>>>> >>>>>> To continue the common-theme subject, I haven't see negative return to >>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the >>>>>> same >>>>>> subject [2] and the additional theme xml definition [3], I suggest to >>>>>> create >>>>>> a documentation on the wiki how work the "theme engine" and commit the >>>>>> current git branch [4] [5] on trunk >>>>>> >>>>>> After that, the engine will be present on the trunk and we continue the >>>>>> work to : >>>>>> * Clean the common-theme and create a real theme >>>>>> * Migrate properly the current theme with the new structure >>>>>> * Analyze more how organize the screen api >>>>>> >>>>>> But don't panic, before that I'm listening to all suggest or remarks ;) >>>>>> >>>>>> Nicolas >>>>>> >>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>> [2] >>>>>> >>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>> [3] >>>>>> >>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>> [5] >>>>>> >>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>>>> >>>>>> |
|
|
I started to load common-theme on trunk, at this time to resume :
r1806075, r1806076 : I loaded engine and documentation r1806084 : I moved all images folder to common-theme r1806091, r1806093: I moved all ftl template from common to common-theme and all macro ftl libraries. I hope to break nothing at this time. The next steps will load the dynamic theme load on session Cheers, Nicolas Le 22/08/2017 à 14:07, Nicolas Malin a écrit : > Hi Taher, > > If you have few time to have a look on these three class : > > https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java > > https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java > > https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java > > > ModelTheme is java class to load all Theme definition who interact > with the system > > VisualTheme is java class regards the VisualTheme entity who interact > with the user to exploit the modelTheme > > ThemeFactory is the factory to create both. > > I prepare my commits, but I need to separate properly each code > modification to help other learn the work. > > Cheers, > Nicolas > > Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : >> Hi Nicolas, >> >> If it helps you, I suggest to isolate files / code where you are not >> very comfortable and put them in a separate patch (not the full patch) >> with an explanation of what you've done and where you feel a little >> hesitant or uneasy. I think if you make us focus with you on very >> specific pieces of code then our review will be faster and your >> confidence of the review will be better. >> >> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin >> <[hidden email]> wrote: >>> Thanks, >>> >>> I will commit on trunk after a second review of my code because i was >>> concentrated to increase the flexibility with macro and screen but not >>> manage correctly the VisualTheme concept. >>> >>> So I will take care about this, complete the documentation and >>> commit on >>> trunk. >>> >>> Nicolas >>> >>> >>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>>> Like Michael, I also prefer to include the work into the code base and >>>> test it over there. It seems like you put a lot of effort into this >>>> code so thank you! I like the fact that you brought all the artifacts >>>> into the theme along with the FTL macros. This is a good first step, >>>> and I believe continuing on this direction is where we need to go. >>>> >>>> +1 to committing into the code base and testing over there. >>>> >>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>>> <[hidden email]> wrote: >>>>> That sounds great, >>>>> >>>>> Thanks Nicolas! >>>>> >>>>> Jacques >>>>> >>>>> >>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>>> Hello, >>>>>> >>>>>> I started the documentation here >>>>>> >>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>>>>> >>>>>> >>>>>> It's a begging, I hope improve it quickly >>>>>> >>>>>> Nicolas >>>>>> >>>>>> >>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>>> Hello; >>>>>>> >>>>>>> To continue the common-theme subject, I haven't see negative >>>>>>> return to >>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads >>>>>>> on the >>>>>>> same >>>>>>> subject [2] and the additional theme xml definition [3], I >>>>>>> suggest to >>>>>>> create >>>>>>> a documentation on the wiki how work the "theme engine" and >>>>>>> commit the >>>>>>> current git branch [4] [5] on trunk >>>>>>> >>>>>>> After that, the engine will be present on the trunk and we >>>>>>> continue the >>>>>>> work to : >>>>>>> * Clean the common-theme and create a real theme >>>>>>> * Migrate properly the current theme with the new structure >>>>>>> * Analyze more how organize the screen api >>>>>>> >>>>>>> But don't panic, before that I'm listening to all suggest or >>>>>>> remarks ;) >>>>>>> >>>>>>> Nicolas >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>>> [2] >>>>>>> >>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>>> >>>>>>> [3] >>>>>>> >>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>>> >>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>>> [5] >>>>>>> >>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>>>>> >>>>>>> >>>>>>> > > |
|
|
I loaded all my local :)
Le 25/08/2017 à 00:03, Nicolas Malin a écrit : > I started to load common-theme on trunk, at this time to resume : > > r1806075, r1806076 : I loaded engine and documentation > r1806084 : I moved all images folder to common-theme > r1806091, r1806093: I moved all ftl template from common to > common-theme and all macro ftl libraries. 1806134 : load VisualTheme and ModelTheme on different session and context 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit values from the theme definition 1806150 : migrate all other screen and scripts to exploit values from the theme definition 180615 : improve error message and announce the commit end :) Cheers, Nicolas > > I hope to break nothing at this time. > The next steps will load the dynamic theme load on session > > Cheers, > > Nicolas > > > Le 22/08/2017 à 14:07, Nicolas Malin a écrit : >> Hi Taher, >> >> If you have few time to have a look on these three class : >> >> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java >> >> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java >> >> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java >> >> >> ModelTheme is java class to load all Theme definition who interact >> with the system >> >> VisualTheme is java class regards the VisualTheme entity who interact >> with the user to exploit the modelTheme >> >> ThemeFactory is the factory to create both. >> >> I prepare my commits, but I need to separate properly each code >> modification to help other learn the work. >> >> Cheers, >> Nicolas >> >> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : >>> Hi Nicolas, >>> >>> If it helps you, I suggest to isolate files / code where you are not >>> very comfortable and put them in a separate patch (not the full patch) >>> with an explanation of what you've done and where you feel a little >>> hesitant or uneasy. I think if you make us focus with you on very >>> specific pieces of code then our review will be faster and your >>> confidence of the review will be better. >>> >>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin >>> <[hidden email]> wrote: >>>> Thanks, >>>> >>>> I will commit on trunk after a second review of my code because i was >>>> concentrated to increase the flexibility with macro and screen but not >>>> manage correctly the VisualTheme concept. >>>> >>>> So I will take care about this, complete the documentation and >>>> commit on >>>> trunk. >>>> >>>> Nicolas >>>> >>>> >>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>>>> Like Michael, I also prefer to include the work into the code base >>>>> and >>>>> test it over there. It seems like you put a lot of effort into this >>>>> code so thank you! I like the fact that you brought all the artifacts >>>>> into the theme along with the FTL macros. This is a good first step, >>>>> and I believe continuing on this direction is where we need to go. >>>>> >>>>> +1 to committing into the code base and testing over there. >>>>> >>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>>>> <[hidden email]> wrote: >>>>>> That sounds great, >>>>>> >>>>>> Thanks Nicolas! >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>>>> Hello, >>>>>>> >>>>>>> I started the documentation here >>>>>>> >>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >>>>>>> >>>>>>> >>>>>>> It's a begging, I hope improve it quickly >>>>>>> >>>>>>> Nicolas >>>>>>> >>>>>>> >>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>>>> Hello; >>>>>>>> >>>>>>>> To continue the common-theme subject, I haven't see negative >>>>>>>> return to >>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads >>>>>>>> on the >>>>>>>> same >>>>>>>> subject [2] and the additional theme xml definition [3], I >>>>>>>> suggest to >>>>>>>> create >>>>>>>> a documentation on the wiki how work the "theme engine" and >>>>>>>> commit the >>>>>>>> current git branch [4] [5] on trunk >>>>>>>> >>>>>>>> After that, the engine will be present on the trunk and we >>>>>>>> continue the >>>>>>>> work to : >>>>>>>> * Clean the common-theme and create a real theme >>>>>>>> * Migrate properly the current theme with the new structure >>>>>>>> * Analyze more how organize the screen api >>>>>>>> >>>>>>>> But don't panic, before that I'm listening to all suggest or >>>>>>>> remarks ;) >>>>>>>> >>>>>>>> Nicolas >>>>>>>> >>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>>>> [2] >>>>>>>> >>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>>>> >>>>>>>> [3] >>>>>>>> >>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>>>> >>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>>>> [5] >>>>>>>> >>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>>>>>>> >>>>>>>> >>>>>>>> >> >> > > |
|
|
Thanks Nicolas, Nice work.
I noticed some console warning while data load {quote} 2017-08-25 16:14:37,945 |main |UtilXml |E| XmlFileLoader: File file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml process error. Line: 20. Error message: TargetNamespace.2: Expecting no namespace, but the schema document has a target namespace of ' http://ofbiz.apache.org/Widget-Theme'. 2017-08-25 16:14:37,946 |main |UtilXml |E| XmlFileLoader: File file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml process error. Line: 23. Error message: cvc-elt.1: Cannot find the declaration of element 'theme'. {quote} Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <[hidden email]> wrote: > I loaded all my local :) > > Le 25/08/2017 à 00:03, Nicolas Malin a écrit : > >> I started to load common-theme on trunk, at this time to resume : >> >> r1806075, r1806076 : I loaded engine and documentation >> r1806084 : I moved all images folder to common-theme >> r1806091, r1806093: I moved all ftl template from common to common-theme >> and all macro ftl libraries. >> > 1806134 : load VisualTheme and ModelTheme on different session and context > 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit > values from the theme definition > 1806150 : migrate all other screen and scripts to exploit values from the > theme definition > 180615 : improve error message and announce the commit end :) > > Cheers, > Nicolas > > >> I hope to break nothing at this time. >> The next steps will load the dynamic theme load on session >> >> Cheers, >> >> Nicolas >> >> >> Le 22/08/2017 à 14:07, Nicolas Malin a écrit : >> >>> Hi Taher, >>> >>> If you have few time to have a look on these three class : >>> >>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>> model/ModelTheme.java >>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>> model/ThemeFactory.java >>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>> renderer/VisualTheme.java >>> >>> ModelTheme is java class to load all Theme definition who interact with >>> the system >>> >>> VisualTheme is java class regards the VisualTheme entity who interact >>> with the user to exploit the modelTheme >>> >>> ThemeFactory is the factory to create both. >>> >>> I prepare my commits, but I need to separate properly each code >>> modification to help other learn the work. >>> >>> Cheers, >>> Nicolas >>> >>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : >>> >>>> Hi Nicolas, >>>> >>>> If it helps you, I suggest to isolate files / code where you are not >>>> very comfortable and put them in a separate patch (not the full patch) >>>> with an explanation of what you've done and where you feel a little >>>> hesitant or uneasy. I think if you make us focus with you on very >>>> specific pieces of code then our review will be faster and your >>>> confidence of the review will be better. >>>> >>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin >>>> <[hidden email]> wrote: >>>> >>>>> Thanks, >>>>> >>>>> I will commit on trunk after a second review of my code because i was >>>>> concentrated to increase the flexibility with macro and screen but not >>>>> manage correctly the VisualTheme concept. >>>>> >>>>> So I will take care about this, complete the documentation and commit >>>>> on >>>>> trunk. >>>>> >>>>> Nicolas >>>>> >>>>> >>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>>>> >>>>>> Like Michael, I also prefer to include the work into the code base and >>>>>> test it over there. It seems like you put a lot of effort into this >>>>>> code so thank you! I like the fact that you brought all the artifacts >>>>>> into the theme along with the FTL macros. This is a good first step, >>>>>> and I believe continuing on this direction is where we need to go. >>>>>> >>>>>> +1 to committing into the code base and testing over there. >>>>>> >>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>>>>> <[hidden email]> wrote: >>>>>> >>>>>>> That sounds great, >>>>>>> >>>>>>> Thanks Nicolas! >>>>>>> >>>>>>> Jacques >>>>>>> >>>>>>> >>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>>>> >>>>>>>> Hello, >>>>>>>> >>>>>>>> I started the documentation here >>>>>>>> >>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>>>>>> themes/README.md >>>>>>>> >>>>>>>> It's a begging, I hope improve it quickly >>>>>>>> >>>>>>>> Nicolas >>>>>>>> >>>>>>>> >>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>>>> >>>>>>>>> Hello; >>>>>>>>> >>>>>>>>> To continue the common-theme subject, I haven't see negative >>>>>>>>> return to >>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on >>>>>>>>> the >>>>>>>>> same >>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest >>>>>>>>> to >>>>>>>>> create >>>>>>>>> a documentation on the wiki how work the "theme engine" and commit >>>>>>>>> the >>>>>>>>> current git branch [4] [5] on trunk >>>>>>>>> >>>>>>>>> After that, the engine will be present on the trunk and we >>>>>>>>> continue the >>>>>>>>> work to : >>>>>>>>> * Clean the common-theme and create a real theme >>>>>>>>> * Migrate properly the current theme with the new structure >>>>>>>>> * Analyze more how organize the screen api >>>>>>>>> >>>>>>>>> But don't panic, before that I'm listening to all suggest or >>>>>>>>> remarks ;) >>>>>>>>> >>>>>>>>> Nicolas >>>>>>>>> >>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>>>>> [2] >>>>>>>>> >>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15 >>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>>>>> [3] >>>>>>>>> >>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab >>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>>>>> [5] >>>>>>>>> >>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk... >>>>>>>>> nmalin:common-theme?expand=1 >>>>>>>>> >>>>>>>>> >>>>>>>>> >>> >>> >> >> > |
|
|
Hello
Le 25/08/2017 à 12:54, Deepak Dixit a écrit : > Thanks Nicolas, Nice work. Thanks Deepak, in line > I noticed some console warning while data load > {quote} > > 2017-08-25 16:14:37,945 |main |UtilXml > |E| XmlFileLoader: File > file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml > process error. Line: 20. Error message: TargetNamespace.2: Expecting no > namespace, but the schema document has a target namespace of ' > http://ofbiz.apache.org/Widget-Theme'. > > 2017-08-25 16:14:37,946 |main |UtilXml > |E| XmlFileLoader: File > file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml > process error. Line: 23. Error message: cvc-elt.1: Cannot find the > declaration of element 'theme'. > > {quote} on the website will be solve it. Else I will complete my knowledge with this mistake :) Nicolas > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <[hidden email]> > wrote: > >> I loaded all my local :) >> >> Le 25/08/2017 à 00:03, Nicolas Malin a écrit : >> >>> I started to load common-theme on trunk, at this time to resume : >>> >>> r1806075, r1806076 : I loaded engine and documentation >>> r1806084 : I moved all images folder to common-theme >>> r1806091, r1806093: I moved all ftl template from common to common-theme >>> and all macro ftl libraries. >>> >> 1806134 : load VisualTheme and ModelTheme on different session and context >> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit >> values from the theme definition >> 1806150 : migrate all other screen and scripts to exploit values from the >> theme definition >> 180615 : improve error message and announce the commit end :) >> >> Cheers, >> Nicolas >> >> >>> I hope to break nothing at this time. >>> The next steps will load the dynamic theme load on session >>> >>> Cheers, >>> >>> Nicolas >>> >>> >>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit : >>> >>>> Hi Taher, >>>> >>>> If you have few time to have a look on these three class : >>>> >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> model/ModelTheme.java >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> model/ThemeFactory.java >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> renderer/VisualTheme.java >>>> >>>> ModelTheme is java class to load all Theme definition who interact with >>>> the system >>>> >>>> VisualTheme is java class regards the VisualTheme entity who interact >>>> with the user to exploit the modelTheme >>>> >>>> ThemeFactory is the factory to create both. >>>> >>>> I prepare my commits, but I need to separate properly each code >>>> modification to help other learn the work. >>>> >>>> Cheers, >>>> Nicolas >>>> >>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : >>>> >>>>> Hi Nicolas, >>>>> >>>>> If it helps you, I suggest to isolate files / code where you are not >>>>> very comfortable and put them in a separate patch (not the full patch) >>>>> with an explanation of what you've done and where you feel a little >>>>> hesitant or uneasy. I think if you make us focus with you on very >>>>> specific pieces of code then our review will be faster and your >>>>> confidence of the review will be better. >>>>> >>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin >>>>> <[hidden email]> wrote: >>>>> >>>>>> Thanks, >>>>>> >>>>>> I will commit on trunk after a second review of my code because i was >>>>>> concentrated to increase the flexibility with macro and screen but not >>>>>> manage correctly the VisualTheme concept. >>>>>> >>>>>> So I will take care about this, complete the documentation and commit >>>>>> on >>>>>> trunk. >>>>>> >>>>>> Nicolas >>>>>> >>>>>> >>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>>>>> >>>>>>> Like Michael, I also prefer to include the work into the code base and >>>>>>> test it over there. It seems like you put a lot of effort into this >>>>>>> code so thank you! I like the fact that you brought all the artifacts >>>>>>> into the theme along with the FTL macros. This is a good first step, >>>>>>> and I believe continuing on this direction is where we need to go. >>>>>>> >>>>>>> +1 to committing into the code base and testing over there. >>>>>>> >>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>>>>>> <[hidden email]> wrote: >>>>>>> >>>>>>>> That sounds great, >>>>>>>> >>>>>>>> Thanks Nicolas! >>>>>>>> >>>>>>>> Jacques >>>>>>>> >>>>>>>> >>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>>>>> >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> I started the documentation here >>>>>>>>> >>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>>>>>>> themes/README.md >>>>>>>>> >>>>>>>>> It's a begging, I hope improve it quickly >>>>>>>>> >>>>>>>>> Nicolas >>>>>>>>> >>>>>>>>> >>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>>>>> >>>>>>>>>> Hello; >>>>>>>>>> >>>>>>>>>> To continue the common-theme subject, I haven't see negative >>>>>>>>>> return to >>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on >>>>>>>>>> the >>>>>>>>>> same >>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest >>>>>>>>>> to >>>>>>>>>> create >>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit >>>>>>>>>> the >>>>>>>>>> current git branch [4] [5] on trunk >>>>>>>>>> >>>>>>>>>> After that, the engine will be present on the trunk and we >>>>>>>>>> continue the >>>>>>>>>> work to : >>>>>>>>>> * Clean the common-theme and create a real theme >>>>>>>>>> * Migrate properly the current theme with the new structure >>>>>>>>>> * Analyze more how organize the screen api >>>>>>>>>> >>>>>>>>>> But don't panic, before that I'm listening to all suggest or >>>>>>>>>> remarks ;) >>>>>>>>>> >>>>>>>>>> Nicolas >>>>>>>>>> >>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>>>>>> [2] >>>>>>>>>> >>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15 >>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>>>>>> [3] >>>>>>>>>> >>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab >>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>>>>>> [5] >>>>>>>>>> >>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk... >>>>>>>>>> nmalin:common-theme?expand=1 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>> >>> |
|
|
I wanted to thank you again for this work Nicolas. Hopefully with a little
more time and refinement we can purge all "web" stuff outside the framework and make it a pure DSL infrastructure independent of the output technology. This also opens the door for selecting front end technology stacks without touching the core. On Aug 25, 2017 3:35 PM, "Nicolas Malin" <[hidden email]> wrote: Hello Le 25/08/2017 à 12:54, Deepak Dixit a écrit : > Thanks Nicolas, Nice work. > Thanks Deepak, in line I noticed some console warning while data load > {quote} > > 2017-08-25 16:14:37,945 |main |UtilXml > |E| XmlFileLoader: File > file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight > /widget/Theme.xml > process error. Line: 20. Error message: TargetNamespace.2: Expecting no > namespace, but the schema document has a target namespace of ' > http://ofbiz.apache.org/Widget-Theme'. > > 2017-08-25 16:14:37,946 |main |UtilXml > |E| XmlFileLoader: File > file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight > /widget/Theme.xml > process error. Line: 23. Error message: cvc-elt.1: Cannot find the > declaration of element 'theme'. > > {quote} > the website will be solve it. Else I will complete my knowledge with this mistake :) Nicolas > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <[hidden email]> > wrote: > > I loaded all my local :) >> >> Le 25/08/2017 à 00:03, Nicolas Malin a écrit : >> >> I started to load common-theme on trunk, at this time to resume : >>> >>> r1806075, r1806076 : I loaded engine and documentation >>> r1806084 : I moved all images folder to common-theme >>> r1806091, r1806093: I moved all ftl template from common to common-theme >>> and all macro ftl libraries. >>> >>> 1806134 : load VisualTheme and ModelTheme on different session and >> context >> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit >> values from the theme definition >> 1806150 : migrate all other screen and scripts to exploit values from the >> theme definition >> 180615 : improve error message and announce the commit end :) >> >> Cheers, >> Nicolas >> >> >> I hope to break nothing at this time. >>> The next steps will load the dynamic theme load on session >>> >>> Cheers, >>> >>> Nicolas >>> >>> >>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit : >>> >>> Hi Taher, >>>> >>>> If you have few time to have a look on these three class : >>>> >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> model/ModelTheme.java >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> model/ThemeFactory.java >>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>> framework/widget/src/main/java/org/apache/ofbiz/widget/ >>>> renderer/VisualTheme.java >>>> >>>> ModelTheme is java class to load all Theme definition who interact with >>>> the system >>>> >>>> VisualTheme is java class regards the VisualTheme entity who interact >>>> with the user to exploit the modelTheme >>>> >>>> ThemeFactory is the factory to create both. >>>> >>>> I prepare my commits, but I need to separate properly each code >>>> modification to help other learn the work. >>>> >>>> Cheers, >>>> Nicolas >>>> >>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit : >>>> >>>> Hi Nicolas, >>>>> >>>>> If it helps you, I suggest to isolate files / code where you are not >>>>> very comfortable and put them in a separate patch (not the full patch) >>>>> with an explanation of what you've done and where you feel a little >>>>> hesitant or uneasy. I think if you make us focus with you on very >>>>> specific pieces of code then our review will be faster and your >>>>> confidence of the review will be better. >>>>> >>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin >>>>> <[hidden email]> wrote: >>>>> >>>>> Thanks, >>>>>> >>>>>> I will commit on trunk after a second review of my code because i was >>>>>> concentrated to increase the flexibility with macro and screen but not >>>>>> manage correctly the VisualTheme concept. >>>>>> >>>>>> So I will take care about this, complete the documentation and commit >>>>>> on >>>>>> trunk. >>>>>> >>>>>> Nicolas >>>>>> >>>>>> >>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit : >>>>>> >>>>>> Like Michael, I also prefer to include the work into the code base and >>>>>>> test it over there. It seems like you put a lot of effort into this >>>>>>> code so thank you! I like the fact that you brought all the artifacts >>>>>>> into the theme along with the FTL macros. This is a good first step, >>>>>>> and I believe continuing on this direction is where we need to go. >>>>>>> >>>>>>> +1 to committing into the code base and testing over there. >>>>>>> >>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux >>>>>>> <[hidden email]> wrote: >>>>>>> >>>>>>> That sounds great, >>>>>>>> >>>>>>>> Thanks Nicolas! >>>>>>>> >>>>>>>> Jacques >>>>>>>> >>>>>>>> >>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >>>>>>>> >>>>>>>> Hello, >>>>>>>>> >>>>>>>>> I started the documentation here >>>>>>>>> >>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/ >>>>>>>>> themes/README.md >>>>>>>>> >>>>>>>>> It's a begging, I hope improve it quickly >>>>>>>>> >>>>>>>>> Nicolas >>>>>>>>> >>>>>>>>> >>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>>>>>>>> >>>>>>>>> Hello; >>>>>>>>>> >>>>>>>>>> To continue the common-theme subject, I haven't see negative >>>>>>>>>> return to >>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on >>>>>>>>>> the >>>>>>>>>> same >>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest >>>>>>>>>> to >>>>>>>>>> create >>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit >>>>>>>>>> the >>>>>>>>>> current git branch [4] [5] on trunk >>>>>>>>>> >>>>>>>>>> After that, the engine will be present on the trunk and we >>>>>>>>>> continue the >>>>>>>>>> work to : >>>>>>>>>> * Clean the common-theme and create a real theme >>>>>>>>>> * Migrate properly the current theme with the new structure >>>>>>>>>> * Analyze more how organize the screen api >>>>>>>>>> >>>>>>>>>> But don't panic, before that I'm listening to all suggest or >>>>>>>>>> remarks ;) >>>>>>>>>> >>>>>>>>>> Nicolas >>>>>>>>>> >>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>>>>>>>>> [2] >>>>>>>>>> >>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15 >>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>>>>>>>>> [3] >>>>>>>>>> >>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab >>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>>>>>>>>> [5] >>>>>>>>>> >>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk... >>>>>>>>>> nmalin:common-theme?expand=1 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>> >>> |
|
|
In reply to this post by Nicolas Malin-2
Le 25/08/2017 à 14:34, Nicolas Malin a écrit :
> Yes I detected it during my work, but I supposed to push the theme dtd > on the website will be solve it. > Else I will complete my knowledge with this mistake :) Ok it's a mistake, idea help me to resolve this issue because I not understand all. Commited at r1806170, can you confirm that it's solved ? Nicolas |
|
|
Thanks Nicolas for your effort.
I confirm that above reported warning has been fixed. I found some more console warning related to xml schema validation, those has been fixed at r# 1806206, 1806209, 1806211 Also updated the site xsd at r#1806208 and r#1806210 Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Fri, Aug 25, 2017 at 6:50 PM, Nicolas Malin <[hidden email]> wrote: > Le 25/08/2017 à 14:34, Nicolas Malin a écrit : > >> Yes I detected it during my work, but I supposed to push the theme dtd on >> the website will be solve it. >> Else I will complete my knowledge with this mistake :) >> > Ok it's a mistake, idea help me to resolve this issue because I not > understand all. Commited at r1806170, can you confirm that it's solved ? > > Nicolas > |
|
|
:) thanks Deepak for your support you fill my weaknesses.
Nicolas Le 25/08/2017 à 20:31, Deepak Dixit a écrit : > Thanks Nicolas for your effort. > I confirm that above reported warning has been fixed. > I found some more console warning related to xml schema validation, those > has been fixed at r# 1806206, 1806209, 1806211 > Also updated the site xsd at r#1806208 and r#1806210 > > > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Fri, Aug 25, 2017 at 6:50 PM, Nicolas Malin <[hidden email]> > wrote: > >> Le 25/08/2017 à 14:34, Nicolas Malin a écrit : >> >>> Yes I detected it during my work, but I supposed to push the theme dtd on >>> the website will be solve it. >>> Else I will complete my knowledge with this mistake :) >>> >> Ok it's a mistake, idea help me to resolve this issue because I not >> understand all. Commited at r1806170, can you confirm that it's solved ? >> >> Nicolas >> |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |