Dev - [Fwd: [OFBiz] SVN: r7165 - trunk/applications/accounting/script/org/ofbiz/accounting/invoice]

[Si Chen-2]

Hans,

I'm sorry but I don't think this is correct.  WRITE_OFF is not the same
as CANCELED.  Write off means that the invoice is good but cannot be
collected in full.  Canceled means invoice is wrong or otherwise in
valid.  If the invoice is written off, we would still need to know what
payments were made and applied against it, so we know what needs to be
collected through legal action, etc.

I don't imagine you've used write off a lot yet, since I just put in
last week.  If you have any issues, please let me know.

Si

Author: hansbak
Date: 2006-03-31 21:11:53 -0600 (Fri, 31 Mar 2006)
New Revision: 7165

Modified:
   trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
Log:
delete payment application if invoice status changes to 'writeoff', the same as cancelled

Modified: trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
===================================================================
--- trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 02:47:27 UTC (rev 7164)
+++ trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 03:11:53 UTC (rev 7165)
@@ -436,11 +436,19 @@
                 </if-empty>    
                 <create-value value-name="newEntity"/>
                 
-                <!-- if new status is cancelled delete existing payment applications. -->
-                <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED">
-                    <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
-                    <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
-                </if-compare>
+                <!-- if new status is cancelled/writeoff delete existing payment applications. -->
+                <if>
+                    <condition>
+                        <or>
+                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED"/>
+                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_WRITEOFF"/>
+                        </or>
+                    </condition>
+                    <then>
+                        <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
+                        <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
+                    </then>
+                </if>
             </else>  
             </if-empty>
         </if-compare-field>

 
_______________________________________________
Svn mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/svn



 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[David E. Jones]

I agree.

-David


Si Chen wrote:

> Hans,
>
> I'm sorry but I don't think this is correct.  WRITE_OFF is not the same
> as CANCELED.  Write off means that the invoice is good but cannot be
> collected in full.  Canceled means invoice is wrong or otherwise in
> valid.  If the invoice is written off, we would still need to know what
> payments were made and applied against it, so we know what needs to be
> collected through legal action, etc.
>
> I don't imagine you've used write off a lot yet, since I just put in
> last week.  If you have any issues, please let me know.
>
> Si
>
> ------------------------------------------------------------------------
>
> Subject:
> [OFBiz] SVN: r7165 -
> trunk/applications/accounting/script/org/ofbiz/accounting/invoice
> From:
> [hidden email]
> Date:
> 1 Apr 2006 03:12:02 -0000
> To:
> [hidden email]
>
> To:
> [hidden email]
>
>
> Author: hansbak
> Date: 2006-03-31 21:11:53 -0600 (Fri, 31 Mar 2006)
> New Revision: 7165
>
> Modified:
>    trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
> Log:
> delete payment application if invoice status changes to 'writeoff', the same as cancelled
>
> Modified: trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml
> ===================================================================
> --- trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 02:47:27 UTC (rev 7164)
> +++ trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml 2006-04-01 03:11:53 UTC (rev 7165)
> @@ -436,11 +436,19 @@
>                  </if-empty>    
>                  <create-value value-name="newEntity"/>
>                  
> -                <!-- if new status is cancelled delete existing payment applications. -->
> -                <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED">
> -                    <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
> -                    <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
> -                </if-compare>
> +                <!-- if new status is cancelled/writeoff delete existing payment applications. -->
> +                <if>
> +                    <condition>
> +                        <or>
> +                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_CANCELLED"/>
> +                            <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_WRITEOFF"/>
> +                        </or>
> +                    </condition>
> +                    <then>
> +                        <set field="removePaymentApplicationMap.invoiceId" from-field="parameters.invoiceId"/>
> +                        <remove-by-and entity-name="PaymentApplication" map-name="removePaymentApplicationMap"/>
> +                    </then>
> +                </if>
>              </else>  
>              </if-empty>
>          </if-compare-field>
>
>  
> _______________________________________________
> Svn mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/svn
>
>
>
>
> ------------------------------------------------------------------------
>
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Hans Bakker]

Si,

At the moment i am tracking om my system all 'open' payments and invoices. For
me 'open' means: not completely applied so not accounted for. I intent, if
you do not object :-) , to add a button to the invoice and payment find
screen to list these.

If we allow 'writeoff' invoices to have still payments applied, then these
payments will not appear in the open payment report and can only be listed
there with a lot of difficulty: I have to scan all payments which have
invoices applied with the status 'writeoff'

If you want to 'writeof' an invoice isn't it better to create a 'credit' i.e.
a negative or reverse invoice?

Hans

On Monday 03 April 2006 21:14, Si Chen wrote:

> Hans,
>
> I'm sorry but I don't think this is correct.  WRITE_OFF is not the same
> as CANCELED.  Write off means that the invoice is good but cannot be
> collected in full.  Canceled means invoice is wrong or otherwise in
> valid.  If the invoice is written off, we would still need to know what
> payments were made and applied against it, so we know what needs to be
> collected through legal action, etc.
>
> I don't imagine you've used write off a lot yet, since I just put in
> last week.  If you have any issues, please let me know.
>
> Si

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Si Chen-2]

Hans,

What you should be doing is tracking invoices whose status is not PAID or WRITEOFF, rather than not completely applied.

Payments which have been applied to invoices which are written off are not still open.  They have been received and applied.

No, it is not better to create a credit because write off is an official status of an invoice.  It implies that the invoice is ready for collection.

Si

Hans Bakker wrote:

Si,

At the moment i am tracking om my system all 'open' payments and invoices. For 
me 'open' means: not completely applied so not accounted for. I intent, if 
you do not object :-) , to add a button to the invoice and payment find 
screen to list these.

If we allow 'writeoff' invoices to have still payments applied, then these 
payments will not appear in the open payment report and can only be listed 
there with a lot of difficulty: I have to scan all payments which have 
invoices applied with the status 'writeoff'

If you want to 'writeof' an invoice isn't it better to create a 'credit' i.e. 
a negative or reverse invoice?

Hans

On Monday 03 April 2006 21:14, Si Chen wrote:
  

Hans,

I'm sorry but I don't think this is correct.  WRITE_OFF is not the same
as CANCELED.  Write off means that the invoice is good but cannot be
collected in full.  Canceled means invoice is wrong or otherwise in
valid.  If the invoice is written off, we would still need to know what
payments were made and applied against it, so we know what needs to be
collected through legal action, etc.

I don't imagine you've used write off a lot yet, since I just put in
last week.  If you have any issues, please let me know.

Si
    

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev