Dev - Product -> Inventory Screen with Virtual Products

[Scott Gray]

Hi All

Seems to me that an inventory screen for a virtual product is a bit of a
waste of space?  Anyone mind if i change it to display a summary of the
variant inventories with links to each?

Thanks
Scott
 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Jacopo Cappellato]

Hi Scott,

I think this is a very good idea.
In my opinion a good place for this is here:

https://localhost:8443/catalog/control/EditProductInventoryItems?productId=WG-9943

I mean, if the product is virtual, instead of showing the above screen
we could show the new screen with links to the above ones of its variants.

Does it make sense?

Jacopo

Scott Gray wrote:

> Hi All
>
> Seems to me that an inventory screen for a virtual product is a bit of a
> waste of space?  Anyone mind if i change it to display a summary of the
> variant inventories with links to each?
>
> Thanks
> Scott
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Scott Gray]

Hi Jacopo

I was thinking the same thing, but where is the best place to make the
change:
1. In the ProductTabBar.ftl check for virtual and link to a  new screen
with the same label
2. or should i run a condition in the screen itself
(EditProductInventoryItems) and have it load different forms?
i'm not sure if the latter is possible i haven't tried it yet.

Thanks
Scott

Jacopo Cappellato wrote:

> Hi Scott,
>
> I think this is a very good idea.
> In my opinion a good place for this is here:
>
> https://localhost:8443/catalog/control/EditProductInventoryItems?productId=WG-9943
>
> I mean, if the product is virtual, instead of showing the above screen
> we could show the new screen with links to the above ones of its variants.
>
> Does it make sense?
>
> Jacopo
>
> Scott Gray wrote:
>  
>> Hi All
>>
>> Seems to me that an inventory screen for a virtual product is a bit of a
>> waste of space?  Anyone mind if i change it to display a summary of the
>> variant inventories with links to each?
>>
>> Thanks
>> Scott
>>  
>> _______________________________________________
>> Dev mailing list
>> [hidden email]
>> http://lists.ofbiz.org/mailman/listinfo/dev
>>
>>    
>
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
>
>  

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Jacopo Cappellato]

Hi Scott,

#2 is the best approach in my opinion: in the attached patch you'll find
the draft of the screen definition with the placeholder for virtual layout.
Hope this helps. Let me know.
You can add java code for virtual products inside the
EditProductInventoryItems.bsh script.

Jacopo

Scott Gray wrote:

> Hi Jacopo
>
> I was thinking the same thing, but where is the best place to make the
> change:
> 1. In the ProductTabBar.ftl check for virtual and link to a  new screen
> with the same label
> 2. or should i run a condition in the screen itself
> (EditProductInventoryItems) and have it load different forms?
> i'm not sure if the latter is possible i haven't tried it yet.
>
> Thanks
> Scott
>
> Jacopo Cappellato wrote:
>> Hi Scott,
>>
>> I think this is a very good idea.
>> In my opinion a good place for this is here:
>>
>> https://localhost:8443/catalog/control/EditProductInventoryItems?productId=WG-9943
>>
>> I mean, if the product is virtual, instead of showing the above screen
>> we could show the new screen with links to the above ones of its variants.
>>
>> Does it make sense?
>>
>> Jacopo
>>
>> Scott Gray wrote:
>>  
>>> Hi All
>>>
>>> Seems to me that an inventory screen for a virtual product is a bit of a
>>> waste of space?  Anyone mind if i change it to display a summary of the
>>> variant inventories with links to each?
>>>
>>> Thanks
>>> Scott
>>>  
>>> _______________________________________________
>>> Dev mailing list
>>> [hidden email]
>>> http://lists.ofbiz.org/mailman/listinfo/dev
>>>
>>>    
>>  
>> _______________________________________________
>> Dev mailing list
>> [hidden email]
>> http://lists.ofbiz.org/mailman/listinfo/dev
>>
>>  
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
>

    <screen name="EditProductInventoryItems">
        <section>
            <actions>
                <set field="titleProperty" value="PageTitleEditProductInventoryItems"/>
                <set field="tabButtonItem" value="EditProductInventoryItems"/>
                <set field="labelTitleProperty" value="ProductInventorySummary"/>
   
                <set field="productId" from-field="parameters.productId"/>
                <entity-one entity-name="Product" value-name="product"/>
                <script location="component://product/webapp/catalog/WEB-INF/actions/product/EditProductInventoryItems.bsh"/>
            </actions>
            <widgets>
                <decorator-screen name="CommonProductDecorator" location="${parameters.mainDecoratorLocation}">
                    <decorator-section name="body">
                        <section>
                            <condition>
                                <if-compare field-name="product.isVirtual" operator="equals" type="String" value="Y"/>
                            </condition>
                            <widgets>
                                <!-- put the new screen elements for the virtual products here -->
                                <container><label style="head1">Virtual Product</label></container>
                            </widgets>
                            <fail-widgets>
                                <platform-specific>
                                    <html><html-template location="component://product/webapp/catalog/product/EditProductInventoryItems.ftl"/></html>
                                </platform-specific>
                                <container><label style="head1">${uiLabelMap.ProductOutstandingPurchaseOrders}</label></container>
                                <include-form name="OutstandingPurchaseOrders" location="component://product/webapp/catalog/product/ProductForms.xml"/>
                            </fail-widgets>
                        </section>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Scott Gray]

Thanks Jacopo, that'll make life easier :-)

Jacopo Cappellato wrote:

> Hi Scott,
>
> #2 is the best approach in my opinion: in the attached patch you'll
> find the draft of the screen definition with the placeholder for
> virtual layout.
> Hope this helps. Let me know.
> You can add java code for virtual products inside the
> EditProductInventoryItems.bsh script.
>
> Jacopo
>
> Scott Gray wrote:
>> Hi Jacopo
>>
>> I was thinking the same thing, but where is the best place to make
>> the change:
>> 1. In the ProductTabBar.ftl check for virtual and link to a  new
>> screen with the same label
>> 2. or should i run a condition in the screen itself
>> (EditProductInventoryItems) and have it load different forms? i'm not
>> sure if the latter is possible i haven't tried it yet.
>>
>> Thanks
>> Scott
>>
>> Jacopo Cappellato wrote:
>>> Hi Scott,
>>>
>>> I think this is a very good idea.
>>> In my opinion a good place for this is here:
>>>
>>> https://localhost:8443/catalog/control/EditProductInventoryItems?productId=WG-9943 
>>>
>>>
>>> I mean, if the product is virtual, instead of showing the above
>>> screen we could show the new screen with links to the above ones of
>>> its variants.
>>>
>>> Does it make sense?
>>>
>>> Jacopo
>>>
>>> Scott Gray wrote:
>>>  
>>>> Hi All
>>>>
>>>> Seems to me that an inventory screen for a virtual product is a bit
>>>> of a waste of space?  Anyone mind if i change it to display a
>>>> summary of the variant inventories with links to each?
>>>>
>>>> Thanks
>>>> Scott
>>>>  
>>>> _______________________________________________
>>>> Dev mailing list
>>>> [hidden email]
>>>> http://lists.ofbiz.org/mailman/listinfo/dev
>>>>
>>>>    
>>>  
>>> _______________________________________________
>>> Dev mailing list
>>> [hidden email]
>>> http://lists.ofbiz.org/mailman/listinfo/dev
>>>
>>>  
>>  
>> _______________________________________________
>> Dev mailing list
>> [hidden email]
>> http://lists.ofbiz.org/mailman/listinfo/dev
>>
>
> ------------------------------------------------------------------------
>
>     <screen name="EditProductInventoryItems">
>         <section>
>             <actions>
>                 <set field="titleProperty" value="PageTitleEditProductInventoryItems"/>
>                 <set field="tabButtonItem" value="EditProductInventoryItems"/>
>                 <set field="labelTitleProperty" value="ProductInventorySummary"/>
>    
>                 <set field="productId" from-field="parameters.productId"/>
>                 <entity-one entity-name="Product" value-name="product"/>
>                 <script location="component://product/webapp/catalog/WEB-INF/actions/product/EditProductInventoryItems.bsh"/>
>             </actions>
>             <widgets>
>                 <decorator-screen name="CommonProductDecorator" location="${parameters.mainDecoratorLocation}">
>                     <decorator-section name="body">
>                         <section>
>                             <condition>
>                                 <if-compare field-name="product.isVirtual" operator="equals" type="String" value="Y"/>
>                             </condition>
>                             <widgets>
>                                 <!-- put the new screen elements for the virtual products here -->
>                                 <container><label style="head1">Virtual Product</label></container>
>                             </widgets>
>                             <fail-widgets>
>                                 <platform-specific>
>                                     <html><html-template location="component://product/webapp/catalog/product/EditProductInventoryItems.ftl"/></html>
>                                 </platform-specific>
>                                 <container><label style="head1">${uiLabelMap.ProductOutstandingPurchaseOrders}</label></container>
>                                 <include-form name="OutstandingPurchaseOrders" location="component://product/webapp/catalog/product/ProductForms.xml"/>
>                             </fail-widgets>
>                         </section>
>                     </decorator-section>
>                 </decorator-screen>
>             </widgets>
>         </section>
>     </screen>
>  
> ------------------------------------------------------------------------
>
>  
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev