Duplicate code in TaxAuthorityServices#getTaxAuthorities method

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Duplicate code in TaxAuthorityServices#getTaxAuthorities method

rajsaini
Hi,

Line numbers 212-214 of the said method looks duplicate of 206-208. It
may not be harmful as Set can not have duplicate values.

Please confirm if it is a bug, I will create a Jira and patch.

Thanks,

Raj
Reply | Threaded
Open this post in threaded view
|

Re: Duplicate code in TaxAuthorityServices#getTaxAuthorities method

Jacques Le Roux
Administrator
Raj,

country is not county ;o)

Jacques

From: "Raj Saini" <[hidden email]>

> Hi,
>
> Line numbers 212-214 of the said method looks duplicate of 206-208. It
> may not be harmful as Set can not have duplicate values.
>
> Please confirm if it is a bug, I will create a Jira and patch.
>
> Thanks,
>
> Raj
>
Reply | Threaded
Open this post in threaded view
|

Re: Duplicate code in TaxAuthorityServices#getTaxAuthorities method

rajsaini
Thanks Jacques, seems I am getting older ;)

Raj
Jacques Le Roux wrote:

> Raj,
>
> country is not county ;o)
>
> Jacques
>
> From: "Raj Saini" <[hidden email]>
>> Hi,
>>
>> Line numbers 212-214 of the said method looks duplicate of 206-208.
>> It may not be harmful as Set can not have duplicate values.
>>
>> Please confirm if it is a bug, I will create a Jira and patch.
>>
>> Thanks,
>>
>> Raj
>>
>