Note to myself, There is something not so good in this commit, will
review and come back to it soon. Thanks and Regards Anil Patel HotWax Media Inc http://www.hotwaxmedia.com http://us.apachecon.com/c/acus2009/sponsors/sponsors Begin forwarded message: > From: [hidden email] > Date: October 24, 2009 11:49:24 AM EDT > To: [hidden email] > Subject: svn commit: r829392 - in /ofbiz/trunk/applications/ > accounting/widget: ap/CommonScreens.xml ar/CommonScreens.xml > Reply-To: [hidden email] > > Author: jleroux > Date: Sat Oct 24 15:49:23 2009 > New Revision: 829392 > > URL: http://svn.apache.org/viewvc?rev=829392&view=rev > Log: > A patch from Deepak Dixit "Could not find screen with name > [CommonPartyDecorator]." (https://issues.apache.org/jira/browse/OFBIZ-3080 > ) - OFBIZ-3080 > Steps to generate error: > 1) Go to AP/AR. > 2) Select Invoice. > 3) Search Invoices. > 4) Select an Invoice. > 5) Click on Acctg Trans Id > > Modified: > ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml > ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml > > Modified: ofbiz/trunk/applications/accounting/widget/ap/ > CommonScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml > (original) > +++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml > Sat Oct 24 15:49:23 2009 > @@ -344,4 +344,27 @@ > </widgets> > </section> > </screen> > + <screen name="CommonPartyDecorator"> > + <section> > + <actions> > + <set field="headerItem" value="companies"/> > + <set field="organizationPartyId" from- > field="parameters.organizationPartyId" global="true"/> > + </actions> > + <widgets> > + <decorator-screen name="main-decorator" location="$ > {parameters.mainDecoratorLocation}"> > + <decorator-section name="body"> > + <section> > + <condition> > + <not><if-empty > field="organizationPartyId"/></not> > + </condition> > + <widgets> > + <include-menu name="PartyTopTabBar" > location="component://accounting/widget/AccountingMenus.xml"/> > + <decorator-section-include > name="body"/> > + </widgets> > + </section> > + </decorator-section> > + </decorator-screen> > + </widgets> > + </section> > + </screen> > </screens> > \ No newline at end of file > > Modified: ofbiz/trunk/applications/accounting/widget/ar/ > CommonScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml > (original) > +++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml > Sat Oct 24 15:49:23 2009 > @@ -178,5 +178,28 @@ > </widgets> > </section> > </screen> > + <screen name="CommonPartyDecorator"> > + <section> > + <actions> > + <set field="headerItem" value="companies"/> > + <set field="organizationPartyId" from- > field="parameters.organizationPartyId" global="true"/> > + </actions> > + <widgets> > + <decorator-screen name="main-decorator" location="$ > {parameters.mainDecoratorLocation}"> > + <decorator-section name="body"> > + <section> > + <condition> > + <not><if-empty > field="organizationPartyId"/></not> > + </condition> > + <widgets> > + <include-menu name="PartyTopTabBar" > location="component://accounting/widget/AccountingMenus.xml"/> > + <decorator-section-include > name="body"/> > + </widgets> > + </section> > + </decorator-section> > + </decorator-screen> > + </widgets> > + </section> > + </screen> > > </screens> > \ No newline at end of file > > |
Administrator
|
Redundancy with existing CommonPartyDecorator in accouting main, isn't ?
Jacques From: "Anil Patel" <[hidden email]> > Note to myself, There is something not so good in this commit, will > review and come back to it soon. > > Thanks and Regards > Anil Patel > HotWax Media Inc > http://www.hotwaxmedia.com > http://us.apachecon.com/c/acus2009/sponsors/sponsors > > Begin forwarded message: > >> From: [hidden email] >> Date: October 24, 2009 11:49:24 AM EDT >> To: [hidden email] >> Subject: svn commit: r829392 - in /ofbiz/trunk/applications/ >> accounting/widget: ap/CommonScreens.xml ar/CommonScreens.xml >> Reply-To: [hidden email] >> >> Author: jleroux >> Date: Sat Oct 24 15:49:23 2009 >> New Revision: 829392 >> >> URL: http://svn.apache.org/viewvc?rev=829392&view=rev >> Log: >> A patch from Deepak Dixit "Could not find screen with name >> [CommonPartyDecorator]." (https://issues.apache.org/jira/browse/OFBIZ-3080 >> ) - OFBIZ-3080 >> Steps to generate error: >> 1) Go to AP/AR. >> 2) Select Invoice. >> 3) Search Invoices. >> 4) Select an Invoice. >> 5) Click on Acctg Trans Id >> >> Modified: >> ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> >> Modified: ofbiz/trunk/applications/accounting/widget/ap/ >> CommonScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> ====================================================================== >> --- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> (original) >> +++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> Sat Oct 24 15:49:23 2009 >> @@ -344,4 +344,27 @@ >> </widgets> >> </section> >> </screen> >> + <screen name="CommonPartyDecorator"> >> + <section> >> + <actions> >> + <set field="headerItem" value="companies"/> >> + <set field="organizationPartyId" from- >> field="parameters.organizationPartyId" global="true"/> >> + </actions> >> + <widgets> >> + <decorator-screen name="main-decorator" location="$ >> {parameters.mainDecoratorLocation}"> >> + <decorator-section name="body"> >> + <section> >> + <condition> >> + <not><if-empty >> field="organizationPartyId"/></not> >> + </condition> >> + <widgets> >> + <include-menu name="PartyTopTabBar" >> location="component://accounting/widget/AccountingMenus.xml"/> >> + <decorator-section-include >> name="body"/> >> + </widgets> >> + </section> >> + </decorator-section> >> + </decorator-screen> >> + </widgets> >> + </section> >> + </screen> >> </screens> >> \ No newline at end of file >> >> Modified: ofbiz/trunk/applications/accounting/widget/ar/ >> CommonScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> ====================================================================== >> --- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> (original) >> +++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> Sat Oct 24 15:49:23 2009 >> @@ -178,5 +178,28 @@ >> </widgets> >> </section> >> </screen> >> + <screen name="CommonPartyDecorator"> >> + <section> >> + <actions> >> + <set field="headerItem" value="companies"/> >> + <set field="organizationPartyId" from- >> field="parameters.organizationPartyId" global="true"/> >> + </actions> >> + <widgets> >> + <decorator-screen name="main-decorator" location="$ >> {parameters.mainDecoratorLocation}"> >> + <decorator-section name="body"> >> + <section> >> + <condition> >> + <not><if-empty >> field="organizationPartyId"/></not> >> + </condition> >> + <widgets> >> + <include-menu name="PartyTopTabBar" >> location="component://accounting/widget/AccountingMenus.xml"/> >> + <decorator-section-include >> name="body"/> >> + </widgets> >> + </section> >> + </decorator-section> >> + </decorator-screen> >> + </widgets> >> + </section> >> + </screen> >> >> </screens> >> \ No newline at end of file >> >> > > |
Yes,
Please don't worry about it, I'll fix it soon :) Thanks and Regards Anil Patel HotWax Media Inc http://www.hotwaxmedia.com http://us.apachecon.com/c/acus2009/sponsors/sponsors On Oct 24, 2009, at 6:00 PM, Jacques Le Roux wrote: > Redundancy with existing CommonPartyDecorator in accouting main, > isn't ? > > Jacques > > From: "Anil Patel" <[hidden email]> >> Note to myself, There is something not so good in this commit, will >> review and come back to it soon. >> >> Thanks and Regards >> Anil Patel >> HotWax Media Inc >> http://www.hotwaxmedia.com >> http://us.apachecon.com/c/acus2009/sponsors/sponsors >> >> Begin forwarded message: >> >>> From: [hidden email] >>> Date: October 24, 2009 11:49:24 AM EDT >>> To: [hidden email] >>> Subject: svn commit: r829392 - in /ofbiz/trunk/applications/ >>> accounting/widget: ap/CommonScreens.xml ar/CommonScreens.xml >>> Reply-To: [hidden email] >>> >>> Author: jleroux >>> Date: Sat Oct 24 15:49:23 2009 >>> New Revision: 829392 >>> >>> URL: http://svn.apache.org/viewvc?rev=829392&view=rev >>> Log: >>> A patch from Deepak Dixit "Could not find screen with name >>> [CommonPartyDecorator]." (https://issues.apache.org/jira/browse/OFBIZ-3080 >>> ) - OFBIZ-3080 >>> Steps to generate error: >>> 1) Go to AP/AR. >>> 2) Select Invoice. >>> 3) Search Invoices. >>> 4) Select an Invoice. >>> 5) Click on Acctg Trans Id >>> >>> Modified: >>> ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>> ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>> >>> Modified: ofbiz/trunk/applications/accounting/widget/ap/ >>> CommonScreens.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>> (original) >>> +++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>> Sat Oct 24 15:49:23 2009 >>> @@ -344,4 +344,27 @@ >>> </widgets> >>> </section> >>> </screen> >>> + <screen name="CommonPartyDecorator"> >>> + <section> >>> + <actions> >>> + <set field="headerItem" value="companies"/> >>> + <set field="organizationPartyId" from- >>> field="parameters.organizationPartyId" global="true"/> >>> + </actions> >>> + <widgets> >>> + <decorator-screen name="main-decorator" location="$ >>> {parameters.mainDecoratorLocation}"> >>> + <decorator-section name="body"> >>> + <section> >>> + <condition> >>> + <not><if-empty >>> field="organizationPartyId"/></not> >>> + </condition> >>> + <widgets> >>> + <include-menu name="PartyTopTabBar" >>> location="component://accounting/widget/AccountingMenus.xml"/> >>> + <decorator-section-include >>> name="body"/> >>> + </widgets> >>> + </section> >>> + </decorator-section> >>> + </decorator-screen> >>> + </widgets> >>> + </section> >>> + </screen> >>> </screens> >>> \ No newline at end of file >>> >>> Modified: ofbiz/trunk/applications/accounting/widget/ar/ >>> CommonScreens.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>> (original) >>> +++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>> Sat Oct 24 15:49:23 2009 >>> @@ -178,5 +178,28 @@ >>> </widgets> >>> </section> >>> </screen> >>> + <screen name="CommonPartyDecorator"> >>> + <section> >>> + <actions> >>> + <set field="headerItem" value="companies"/> >>> + <set field="organizationPartyId" from- >>> field="parameters.organizationPartyId" global="true"/> >>> + </actions> >>> + <widgets> >>> + <decorator-screen name="main-decorator" location="$ >>> {parameters.mainDecoratorLocation}"> >>> + <decorator-section name="body"> >>> + <section> >>> + <condition> >>> + <not><if-empty >>> field="organizationPartyId"/></not> >>> + </condition> >>> + <widgets> >>> + <include-menu name="PartyTopTabBar" >>> location="component://accounting/widget/AccountingMenus.xml"/> >>> + <decorator-section-include >>> name="body"/> >>> + </widgets> >>> + </section> >>> + </decorator-section> >>> + </decorator-screen> >>> + </widgets> >>> + </section> >>> + </screen> >>> >>> </screens> >>> \ No newline at end of file >>> >>> >> > > |
In reply to this post by Anil Patel-3
Just for information, these changes are done because when this decorator
is called, the location of decorator is given mainDecoratorLocation and in AP/AR mainDecoratorLocation is their CommonScreens.xml file. The same problem occurs with CommonOrganizationAccountingReportsDecorator and CommonAdminChecksDecorator. Thanks and Regards -- Deepak Dixit Anil Patel wrote: > Note to myself, There is something not so good in this commit, will > review and come back to it soon. > > Thanks and Regards > Anil Patel > HotWax Media Inc > http://www.hotwaxmedia.com > http://us.apachecon.com/c/acus2009/sponsors/sponsors > > Begin forwarded message: > >> From: [hidden email] >> Date: October 24, 2009 11:49:24 AM EDT >> To: [hidden email] >> Subject: svn commit: r829392 - in >> /ofbiz/trunk/applications/accounting/widget: ap/CommonScreens.xml >> ar/CommonScreens.xml >> Reply-To: [hidden email] >> >> Author: jleroux >> Date: Sat Oct 24 15:49:23 2009 >> New Revision: 829392 >> >> URL: http://svn.apache.org/viewvc?rev=829392&view=rev >> Log: >> A patch from Deepak Dixit "Could not find screen with name >> [CommonPartyDecorator]." >> (https://issues.apache.org/jira/browse/OFBIZ-3080) - OFBIZ-3080 >> Steps to generate error: >> 1) Go to AP/AR. >> 2) Select Invoice. >> 3) Search Invoices. >> 4) Select an Invoice. >> 5) Click on Acctg Trans Id >> >> Modified: >> ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> >> Modified: >> ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >> >> ============================================================================== >> >> --- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> (original) >> +++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >> Sat Oct 24 15:49:23 2009 >> @@ -344,4 +344,27 @@ >> </widgets> >> </section> >> </screen> >> + <screen name="CommonPartyDecorator"> >> + <section> >> + <actions> >> + <set field="headerItem" value="companies"/> >> + <set field="organizationPartyId" >> from-field="parameters.organizationPartyId" global="true"/> >> + </actions> >> + <widgets> >> + <decorator-screen name="main-decorator" >> location="${parameters.mainDecoratorLocation}"> >> + <decorator-section name="body"> >> + <section> >> + <condition> >> + <not><if-empty >> field="organizationPartyId"/></not> >> + </condition> >> + <widgets> >> + <include-menu name="PartyTopTabBar" >> location="component://accounting/widget/AccountingMenus.xml"/> >> + <decorator-section-include >> name="body"/> >> + </widgets> >> + </section> >> + </decorator-section> >> + </decorator-screen> >> + </widgets> >> + </section> >> + </screen> >> </screens> >> \ No newline at end of file >> >> Modified: >> ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >> >> ============================================================================== >> >> --- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> (original) >> +++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >> Sat Oct 24 15:49:23 2009 >> @@ -178,5 +178,28 @@ >> </widgets> >> </section> >> </screen> >> + <screen name="CommonPartyDecorator"> >> + <section> >> + <actions> >> + <set field="headerItem" value="companies"/> >> + <set field="organizationPartyId" >> from-field="parameters.organizationPartyId" global="true"/> >> + </actions> >> + <widgets> >> + <decorator-screen name="main-decorator" >> location="${parameters.mainDecoratorLocation}"> >> + <decorator-section name="body"> >> + <section> >> + <condition> >> + <not><if-empty >> field="organizationPartyId"/></not> >> + </condition> >> + <widgets> >> + <include-menu name="PartyTopTabBar" >> location="component://accounting/widget/AccountingMenus.xml"/> >> + <decorator-section-include >> name="body"/> >> + </widgets> >> + </section> >> + </decorator-section> >> + </decorator-screen> >> + </widgets> >> + </section> >> + </screen> >> >> </screens> >> \ No newline at end of file >> >> > > |
In reply to this post by Anil Patel-3
Fix applied to r831920.
Thanks and Regards Anil Patel HotWax Media Inc http://www.hotwaxmedia.com http://us.apachecon.com/c/acus2009/sponsors/sponsors On Oct 24, 2009, at 7:25 PM, Anil Patel wrote: > Yes, > Please don't worry about it, I'll fix it soon :) > > Thanks and Regards > Anil Patel > HotWax Media Inc > http://www.hotwaxmedia.com > http://us.apachecon.com/c/acus2009/sponsors/sponsors > > On Oct 24, 2009, at 6:00 PM, Jacques Le Roux wrote: > >> Redundancy with existing CommonPartyDecorator in accouting main, >> isn't ? >> >> Jacques >> >> From: "Anil Patel" <[hidden email]> >>> Note to myself, There is something not so good in this commit, will >>> review and come back to it soon. >>> >>> Thanks and Regards >>> Anil Patel >>> HotWax Media Inc >>> http://www.hotwaxmedia.com >>> http://us.apachecon.com/c/acus2009/sponsors/sponsors >>> >>> Begin forwarded message: >>> >>>> From: [hidden email] >>>> Date: October 24, 2009 11:49:24 AM EDT >>>> To: [hidden email] >>>> Subject: svn commit: r829392 - in /ofbiz/trunk/applications/ >>>> accounting/widget: ap/CommonScreens.xml ar/CommonScreens.xml >>>> Reply-To: [hidden email] >>>> >>>> Author: jleroux >>>> Date: Sat Oct 24 15:49:23 2009 >>>> New Revision: 829392 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=829392&view=rev >>>> Log: >>>> A patch from Deepak Dixit "Could not find screen with name >>>> [CommonPartyDecorator]." (https://issues.apache.org/jira/browse/OFBIZ-3080 >>>> ) - OFBIZ-3080 >>>> Steps to generate error: >>>> 1) Go to AP/AR. >>>> 2) Select Invoice. >>>> 3) Search Invoices. >>>> 4) Select an Invoice. >>>> 5) Click on Acctg Trans Id >>>> >>>> Modified: >>>> ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>>> ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>>> >>>> Modified: ofbiz/trunk/applications/accounting/widget/ap/ >>>> CommonScreens.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>>> (original) >>>> +++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml >>>> Sat Oct 24 15:49:23 2009 >>>> @@ -344,4 +344,27 @@ >>>> </widgets> >>>> </section> >>>> </screen> >>>> + <screen name="CommonPartyDecorator"> >>>> + <section> >>>> + <actions> >>>> + <set field="headerItem" value="companies"/> >>>> + <set field="organizationPartyId" from- >>>> field="parameters.organizationPartyId" global="true"/> >>>> + </actions> >>>> + <widgets> >>>> + <decorator-screen name="main-decorator" >>>> location="$ >>>> {parameters.mainDecoratorLocation}"> >>>> + <decorator-section name="body"> >>>> + <section> >>>> + <condition> >>>> + <not><if-empty >>>> field="organizationPartyId"/></not> >>>> + </condition> >>>> + <widgets> >>>> + <include-menu >>>> name="PartyTopTabBar" >>>> location="component://accounting/widget/AccountingMenus.xml"/> >>>> + <decorator-section-include >>>> name="body"/> >>>> + </widgets> >>>> + </section> >>>> + </decorator-section> >>>> + </decorator-screen> >>>> + </widgets> >>>> + </section> >>>> + </screen> >>>> </screens> >>>> \ No newline at end of file >>>> >>>> Modified: ofbiz/trunk/applications/accounting/widget/ar/ >>>> CommonScreens.xml >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> = >>>> =================================================================== >>>> --- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>>> (original) >>>> +++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml >>>> Sat Oct 24 15:49:23 2009 >>>> @@ -178,5 +178,28 @@ >>>> </widgets> >>>> </section> >>>> </screen> >>>> + <screen name="CommonPartyDecorator"> >>>> + <section> >>>> + <actions> >>>> + <set field="headerItem" value="companies"/> >>>> + <set field="organizationPartyId" from- >>>> field="parameters.organizationPartyId" global="true"/> >>>> + </actions> >>>> + <widgets> >>>> + <decorator-screen name="main-decorator" >>>> location="$ >>>> {parameters.mainDecoratorLocation}"> >>>> + <decorator-section name="body"> >>>> + <section> >>>> + <condition> >>>> + <not><if-empty >>>> field="organizationPartyId"/></not> >>>> + </condition> >>>> + <widgets> >>>> + <include-menu >>>> name="PartyTopTabBar" >>>> location="component://accounting/widget/AccountingMenus.xml"/> >>>> + <decorator-section-include >>>> name="body"/> >>>> + </widgets> >>>> + </section> >>>> + </decorator-section> >>>> + </decorator-screen> >>>> + </widgets> >>>> + </section> >>>> + </screen> >>>> >>>> </screens> >>>> \ No newline at end of file >>>> >>>> >>> >> >> > |
Free forum by Nabble | Edit this page |