[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
Locked
12
12
 
|
adityasharma7 opened a new pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230 1. Added gradle-node-plugin Gradle plugin for integrating NodeJS in your build (https://github.com/node-gradle/gradle-node-plugin) 2. Created NPM package.json with JS dependencies in webapp based upon https://docs.npmjs.com/files/package.json 3. Added license information in package.json based upon SPDX License List (https://spdx.org/licenses/) as supported by NPM (https://docs.npmjs.com/files/package.json#license) 4. Added package-lock.json as suggested in NPM documentation (https://github.com/npm/cli/blob/release-6.14.7/docs/content/configuring-npm/package-lock-json.md#description) 5. Added jQuery and jQuery Migrate using NPM and used it throughout ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682351106 Hi Suraj, You need to merge trunk HEAD, conflicts here and locally: C:\projectsASF\Git\ofbiz-framework>git apply 230.patch error: patch failed: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java:31 error: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java: patch does not apply error: patch failed: themes/common-theme/template/JsLanguageFilesMapping.ftl:74 error: themes/common-theme/template/JsLanguageFilesMapping.ftl: patch does not apply Else after review sounds good to me TIA ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682380868 Hi Jacques, It seems with Suraj you are referring to me here. Though there is some work left at my part: 1. Check if there are more libraries that can be used through NPM. I did it for JQuery, JQuery migrate, JQuery browser, jQuery validate and I faced some issues with JQuery UI library so we will continue to use the downloaded one. 2. Remove migrated JS distribution and updated the ReadMe with steps to download using NPM I will try to get it done in a week You can certainly test it with the current version so that if there are some inputs we will address them now only. You will have to follow these steps: 1. Execute ./gradlew npmInstall after which the libraries listed as dependencies themes/common-theme/webapp/common/js/package.json gets downloaded at themes/common-theme/webapp/common/js/node_modules/ 2. You can locate the folder for each dependency in node_modules containing the package that we usually need to manually download. 3. You can refer Network tab to check if the files are loaded from the node_modules. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682381137 THanks Suraj, It's ok here, but can't apply locally: C:\projectsASF\Git\ofbiz-framework>git pull Already up to date. C:\projectsASF\Git\ofbiz-framework>git apply 230.patch error: patch failed: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java:31 error: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java: patch does not apply error: patch failed: themes/common-theme/template/JsLanguageFilesMapping.ftl:74 error: themes/common-theme/template/JsLanguageFilesMapping.ftl: patch does not apply C:\projectsASF\Git\ofbiz-framework> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682383890 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682391079 No issues Jacques :) I will check once done the issue with applying the patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
surajkhurana commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682397339 :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-695823882 Hi Aditya, I just checked and we are still in the same situation, TIA ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-695823882 Hi Aditya, I just checked and we are still in the same situation, TIA ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-723606142 Hi Aditya, Just noticed that we are no longer using date.format in trunk, ie this line: <property name="VT_HDR_JAVASCRIPT['add']" value="/common/js/plugins/date/date.format-1.2.3-min.js"/> I'll remove it from the LICENSE file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux edited a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-723606142 Hi Aditya, Just noticed that we are no longer using date.format in trunk, ie this line: <property name="VT_HDR_JAVASCRIPT['add']" value="/common/js/plugins/date/date.format-1.2.3-min.js"/> It was removed by https://issues.apache.org/jira/browse/OFBIZ-12040 I'll remove it from the LICENSE file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591 Hi @JacquesLeRoux, This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for the front end to work I have kept the npmInstall task part of the Java build, so it executes on each tasks. Steps to verify: 1. Fetch the branch on your local 2. Start the server You will notice packages being downloaded with npmInstall task <img width="893" alt="image" src="https://user-images.githubusercontent.com/15027245/118508711-0dfd4900-b74d-11eb-8888-18863cd40dcc.png"> You will find the node_modules under the js folder <img width="257" alt="image" src="https://user-images.githubusercontent.com/15027245/118508970-4866e600-b74d-11eb-820c-2db716fd3b11.png"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
«
Return to OFBiz - Notifications
|
1 view|%1 views
| Free forum by Nabble | Edit this page |