Github PRs and Jira

[Jacques Le Roux]

Hi,

Yesterday I have a short discussion with Pierre Smits about Github PRs and Jira.

Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I answered that our workflow is to contribute patches through Jira.

I want to clearly document that in https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices

But I know that it will not be enough. The PR reflex is now an acquired behaviour. So I'll also add a notice in the top of our main README.adoc to
make it clear on our main Github page.

Before I do, please chime in if you have other ideas

Thanks

Jacques

[Jacques Le Roux]

I created https://issues.apache.org/jira/browse/OFBIZ-11301 for that

Le 29/11/2019 à 08:50, Jacques Le Roux a écrit :
> our workflow is to contribute patches through Jira.
>
> I want to clearly document that in https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>
> But I know that it will not be enough. The PR reflex is now an acquired behaviour. So I'll also add a notice in the top of our main README.adoc to
> make it clear on our main Github page.

[Rishi Solanki]

I don't have any better idea around this. But adding contributors best
practice and Readme should be good start to go with, later we can rethink
on it.

+1 Jacques and Pierre to start with.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
Intelligent Solutions
cell: [phone]

On Fri, Nov 29, 2019 at 1:28 PM Jacques Le Roux <
[hidden email]> wrote:

> I created https://issues.apache.org/jira/browse/OFBIZ-11301 for that
>
> Le 29/11/2019 à 08:50, Jacques Le Roux a écrit :
> > our workflow is to contribute patches through Jira.
> >
> > I want to clearly document that in
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
> >
> > But I know that it will not be enough. The PR reflex is now an acquired
> behaviour. So I'll also add a notice in the top of our main README.adoc to
> > make it clear on our main Github page.
>
>

[Rishi Solanki]

Hi,
Do we have committers practices document ready for git?

Sorry if I missed the discussion if already done.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
Intelligent Solutions
cell: [phone]

On Tue, Dec 3, 2019 at 10:57 AM Rishi Solanki <[hidden email]>
wrote:

> I don't have any better idea around this. But adding contributors best
> practice and Readme should be good start to go with, later we can rethink
> on it.
>
> +1 Jacques and Pierre to start with.
>
> Best Regards,
> --
> Rishi Solanki
> *CTO, Mindpath Technology*
> Intelligent Solutions
> cell: [phone]
>
> On Fri, Nov 29, 2019 at 1:28 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> I created https://issues.apache.org/jira/browse/OFBIZ-11301 for that
>>
>> Le 29/11/2019 à 08:50, Jacques Le Roux a écrit :
>> > our workflow is to contribute patches through Jira.
>> >
>> > I want to clearly document that in
>> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>> >
>> > But I know that it will not be enough. The PR reflex is now an acquired
>> behaviour. So I'll also add a notice in the top of our main README.adoc to
>> > make it clear on our main Github page.
>>
>>

[Jacopo Cappellato-3]

On Fri, Nov 29, 2019 at 8:51 AM Jacques Le Roux <
[hidden email]> wrote:

> Hi,
>
> Yesterday I have a short discussion with Pierre Smits about Github PRs and
> Jira.
>
> Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I
> answered that our workflow is to contribute patches through Jira.
>

Now that we have migrated to Git, in my opinion we should really consider
to adopt the workflow based on PR as our primary method for accepting
contributions. I understand that it is a relevant change for the community,
but I also see many advantages and a more natural (for Git) workflow for
contributors and committers. Contributors would fork from the official repo
and would submit pull requests that the committers would merge into the
official branches.

Thanks to Pierre and Jacques for starting this important topic. Only when
we will finalize this discussion and define our best practices, the
migration to Git is really complete!

Regards,

Jacopo

> I want to clearly document that in
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>
> But I know that it will not be enough. The PR reflex is now an acquired
> behaviour. So I'll also add a notice in the top of our main README.adoc to
> make it clear on our main Github page.
>
> Before I do, please chime in if you have other ideas
>
> Thanks
>
> Jacques
>
>

[Jacques Le Roux]

Hi,

Actually not, a good idea to create a sub-task of OFBIZ-11268

Thanks

Jacques

Le 03/12/2019 à 06:36, Rishi Solanki a écrit :

> Hi,
> Do we have committers practices document ready for git?
>
> Sorry if I missed the discussion if already done.
>
> Best Regards,
> --
> Rishi Solanki
> *CTO, Mindpath Technology*
> Intelligent Solutions
> cell: [phone]
>
> On Tue, Dec 3, 2019 at 10:57 AM Rishi Solanki <[hidden email]>
> wrote:
>
>> I don't have any better idea around this. But adding contributors best
>> practice and Readme should be good start to go with, later we can rethink
>> on it.
>>
>> +1 Jacques and Pierre to start with.
>>
>> Best Regards,
>> --
>> Rishi Solanki
>> *CTO, Mindpath Technology*
>> Intelligent Solutions
>> cell: [phone]
>>
>> On Fri, Nov 29, 2019 at 1:28 PM Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> I created https://issues.apache.org/jira/browse/OFBIZ-11301 for that
>>>
>>> Le 29/11/2019 à 08:50, Jacques Le Roux a écrit :
>>>> our workflow is to contribute patches through Jira.
>>>>
>>>> I want to clearly document that in
>>> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>>>> But I know that it will not be enough. The PR reflex is now an acquired
>>> behaviour. So I'll also add a notice in the top of our main README.adoc to
>>>> make it clear on our main Github page.
>>>

[Jacques Le Roux]

Le 03/12/2019 à 08:21, Jacopo Cappellato a écrit :
> Now that we have migrated to Git, in my opinion we should really consider
> to adopt the workflow based on PR as our primary method for accepting
> contributions. I understand that it is a relevant change for the community,
> but I also see many advantages and a more natural (for Git) workflow for
> contributors and committers. Contributors would fork from the official repo
> and would submit pull requests that the committers would merge into the
> official branches.
>
I tend to agree, it's simple to merge and commit. We will still maybe need Jiras when discussions are needed, or in all cases to fill the blog monthly
posts?

I guess using Github (ie Microsoft :D) is not a problem for the community?

Opinions are welcome

Jacques

[Gil Portenseigne]

+1 to use gitlab features to work around code, that will help
collaboration.

I don't know if there is an Apache alternative to get the features without
Microsoft. But having two official tools to get contribution is not desired.

I guess that using existent Github should be ok for official pull
request, if not, it's always ok to have and attached patch or
other gitlab reference.

Gil

Le 11:55 - mardi 03 déc., Jacques Le Roux a écrit :

> Le 03/12/2019 à 08:21, Jacopo Cappellato a écrit :
> > Now that we have migrated to Git, in my opinion we should really consider
> > to adopt the workflow based on PR as our primary method for accepting
> > contributions. I understand that it is a relevant change for the community,
> > but I also see many advantages and a more natural (for Git) workflow for
> > contributors and committers. Contributors would fork from the official repo
> > and would submit pull requests that the committers would merge into the
> > official branches.
> >
> I tend to agree, it's simple to merge and commit. We will still maybe need
> Jiras when discussions are needed, or in all cases to fill the blog monthly
> posts?
>
> I guess using Github (ie Microsoft :D) is not a problem for the community?
>
> Opinions are welcome
>
> Jacques
>

[Mathieu Lirzin]

Hello,

As far as I am concerned, I will never be enthousiastic regarding
adopting yet another proprietary platform.

Gil Portenseigne <[hidden email]> writes:

> +1 to use gitlab features to work around code, that will help
> collaboration.
>
> I don't know if there is an Apache alternative to get the features without
> Microsoft. But having two official tools to get contribution is not desired.

I agree that we should not have multiple workflow because contributing
process is already complex enough to not add yet another option. I think
that I we adopt Github workflow, we should abandon Jira.

In term of ethics, we would just replace an evil proprietary software
with another one, so I won't oppose. :-)

> I guess that using existent Github should be ok for official pull
> request, if not, it's always ok to have and attached patch or
> other gitlab reference.

You mean "Github reference" I guess ?

>
> Le 11:55 - mardi 03 déc., Jacques Le Roux a écrit :
>> Le 03/12/2019 à 08:21, Jacopo Cappellato a écrit :
>> > Now that we have migrated to Git, in my opinion we should really consider
>> > to adopt the workflow based on PR as our primary method for accepting
>> > contributions. I understand that it is a relevant change for the community,
>> > but I also see many advantages and a more natural (for Git) workflow for
>> > contributors and committers. Contributors would fork from the official repo
>> > and would submit pull requests that the committers would merge into the
>> > official branches.
>> >
>> I tend to agree, it's simple to merge and commit. We will still maybe need
>> Jiras when discussions are needed, or in all cases to fill the blog monthly
>> posts?
>>
>> I guess using Github (ie Microsoft :D) is not a problem for the community?
>>
>> Opinions are welcome
>>
>> Jacques
>>

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Gil Portenseigne]

Hello,


>
> > I guess that using existent Github should be ok for official pull
> > request, if not, it's always ok to have and attached patch or
> > other gitlab reference.
>
> You mean "Github reference" I guess ?
>

For this one a really mean gitlab reference like the nereide public
gitlab project we already shared (one or two time) in the past :).

Gil

[Samuel-2]

Hi all,

I see another point to consider on our workflow: running continuous
integration (checkstyle, compilation, unit test, integration test, sonar) on
every code submission (I mean before commiting on trunk!)

It seems to me that is not really complicated with github/gitlab pull
requests. But I have no idea on how to do this on jira.

Samuel

Quoting Jacques Le Roux (2019-11-29 08:50:05)

> Hi,
>
> Yesterday I have a short discussion with Pierre Smits about Github PRs and Jira.
>
> Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I answered that our workflow is to contribute patches through Jira.
>
> I want to clearly document that in https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>
> But I know that it will not be enough. The PR reflex is now an acquired behaviour. So I'll also add a notice in the top of our main README.adoc to
> make it clear on our main Github page.
>
> Before I do, please chime in if you have other ideas
>
> Thanks
>
> Jacques
>

[Jacques Le Roux]

Le 09/12/2019 à 10:21, Samuel Trégouët a écrit :

> Hi all,
>
> I see another point to consider on our workflow: running continuous
> integration (checkstyle, compilation, unit test, integration test, sonar) on
> every code submission (I mean before commiting on trunk!)
>
> It seems to me that is not really complicated with github/gitlab pull
> requests. But I have no idea on how to do this on jira.
>
> Samuel
>
> Quoting Jacques Le Roux (2019-11-29 08:50:05)
>> Hi,
>>
>> Yesterday I have a short discussion with Pierre Smits about Github PRs and Jira.
>>
>> Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I answered that our workflow is to contribute patches through Jira.
>>
>> I want to clearly document that in https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>>
>> But I know that it will not be enough. The PR reflex is now an acquired behaviour. So I'll also add a notice in the top of our main README.adoc to
>> make it clear on our main Github page.
>>
>> Before I do, please chime in if you have other ideas
>>
>> Thanks
>>
>> Jacques
>>

Hi Samuel, All,

You have maybe noticed that today in https://issues.apache.org/jira/browse/OFBIZ-11330 Daniel Watford referenced (in the description, I guess comments
are OK too) a PR he created.

This has an important effect apart letting us know about the PR itself.

If you are subscribed to GitHub notifications on ofbiz-framework and ofbiz-plugins (all committers should be IMO), you get a summary of that
https://github.com/apache/ofbiz-framework/pull/7#issuecomment-579200263 and notably this information "Kudos, SonarCloud Quality Gate passed!"

I'll work on OFBIZ-11301 and OFBIZ-11271 to clarify all that.

Clearly the GitHub PRs are a path to success!

Thanks

Jacques