Groovy Migration : createRequirementFromItemATP

[Gil Portenseigne]

Hello !

While migrating createRequirementFromItemATP, i stumbled upon a comment
from David Jones :
> NOTE DEJ20090902: this service is not called
> anywhere, instead the createATPRequirementsForOrder service (written in
> Java) is called; why this is the case I don't know... -->

I investigate a bit and find out the commit
https://github.com/apache/ofbiz-framework/commit/edc1c0398f77157f590ad99d52e90fc29e251190
That seems to refactor the service.

As createRequirementFromItemATP minilang service seems not used in
project (outside one integration test), should we not deprecated it in
next release (18.12) and remove it in trunk ?

WDYT ?

Regards,

Gil

[Pierre Smits-3]

Hi Gil,

If that other function ( createATPRequirementsForOrder service) has been in
play since 2007, we can, i would say safely, assume that the
createRequirementFromItemATP function/service can be removed from the
codebase immediately and port its removal to the 18.11 branch. No need to
slate it deprecated and leave it in and forgotten.


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer


On Fri, Mar 6, 2020 at 6:04 PM Gil Portenseigne <[hidden email]>
wrote:

> Hello !
>
> While migrating createRequirementFromItemATP, i stumbled upon a comment
> from David Jones :
> > NOTE DEJ20090902: this service is not called
> > anywhere, instead the createATPRequirementsForOrder service (written in
> > Java) is called; why this is the case I don't know... -->
>
> I investigate a bit and find out the commit
>
> https://github.com/apache/ofbiz-framework/commit/edc1c0398f77157f590ad99d52e90fc29e251190
> That seems to refactor the service.
>
> As createRequirementFromItemATP minilang service seems not used in
> project (outside one integration test), should we not deprecated it in
> next release (18.12) and remove it in trunk ?
>
> WDYT ?
>
> Regards,
>
> Gil
>

[Jacopo Cappellato-3]

On Fri, Mar 6, 2020 at 7:31 PM Pierre Smits <[hidden email]> wrote:

> Hi Gil,
>
> If that other function ( createATPRequirementsForOrder service) has been in
> play since 2007, we can, i would say safely, assume that the
> createRequirementFromItemATP function/service can be removed from the
> codebase immediately and port its removal to the 18.11 branch. No need to
> slate it deprecated and leave it in and forgotten.
>

+1

Jacopo

>
>

[Jacques Le Roux]

Le 07/03/2020 à 10:42, Jacopo Cappellato a écrit :

> On Fri, Mar 6, 2020 at 7:31 PM Pierre Smits <[hidden email]> wrote:
>
>> Hi Gil,
>>
>> If that other function ( createATPRequirementsForOrder service) has been in
>> play since 2007, we can, i would say safely, assume that the
>> createRequirementFromItemATP function/service can be removed from the
>> codebase immediately and port its removal to the 18.11 branch. No need to
>> slate it deprecated and leave it in and forgotten.
>>
> +1
>
> Jacopo

+1, also with all related to createRequirementFromItemATP string (labels & test)

Thanks

Jacques