Happy new failing test suite year!

[Mathieu Lirzin]

Hello,

On my system I am noticing that the integration tests are failing with
the following error snippet:

--8<---------------cut here---------------start------------->8---
$ ./gradlew "ofbiz --test component=accounting --test suitename=accountingtests"
[...]
2020-01-02 19:15:11,829 |main                 |TestRunContainer              |I| --> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest): Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
2020-01-02 19:15:11,829 |main                 |TestRunContainer              |I| junit.framework.AssertionFailedError: Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
        at org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
        at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
        at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
        at org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
        at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
        at org.apache.ofbiz.base.start.Start.main(Start.java:90)
--8<---------------cut here---------------end--------------->8---

I was neither able to understand the issue nor bisect to find the origin
of that failure. Since I remember running the integration tests less
than a week ago, I am suspecting that this might be related to new
year...  I hope this is not actually the case.

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Jacques Le Roux]

Hi Mathieu,

Thank you for your good wishes :D

It's strange that's it does not reproduce on Buildbot https://ci.apache.org/builders/ofbizTrunkFramework

Any ideas?

Jacques

Le 02/01/2020 à 19:32, Mathieu Lirzin a écrit :

> Hello,
>
> On my system I am noticing that the integration tests are failing with
> the following error snippet:
>
> --8<---------------cut here---------------start------------->8---
> $ ./gradlew "ofbiz --test component=accounting --test suitename=accountingtests"
> [...]
> 2020-01-02 19:15:11,829 |main                 |TestRunContainer              |I| --> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest): Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
> 2020-01-02 19:15:11,829 |main                 |TestRunContainer              |I| junit.framework.AssertionFailedError: Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
> at org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
> at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
> at org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
> at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
> at org.apache.ofbiz.base.start.Start.main(Start.java:90)
> --8<---------------cut here---------------end--------------->8---
>
> I was neither able to understand the issue nor bisect to find the origin
> of that failure. Since I remember running the integration tests less
> than a week ago, I am suspecting that this might be related to new
> year...  I hope this is not actually the case.
>

[Jacopo Cappellato-3]

Hi Mathieu,

it is actually probably related to the new Year... the demo data for the
financial period has a thruDate="2020-01-01 23:59:59.000"
I can have a look at this later today.

Jacopo


On Thu, Jan 2, 2020 at 7:32 PM Mathieu Lirzin <[hidden email]>
wrote:

> Hello,
>
> On my system I am noticing that the integration tests are failing with
> the following error snippet:
>
> --8<---------------cut here---------------start------------->8---
> $ ./gradlew "ofbiz --test component=accounting --test
> suitename=accountingtests"
> [...]
> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>   |I| -->
> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest):
> Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals
> ERROR_JOURNAL as
> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>   |I| junit.framework.AssertionFailedError: Assertion failed:
> [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
>         at
> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
>         at junit.framework.TestSuite.runTest(TestSuite.java:252)
>         at junit.framework.TestSuite.run(TestSuite.java:247)
>         at
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
>         at
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
>         at
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
>         at
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
>         at
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
>         at org.apache.ofbiz.base.start.Start.main(Start.java:90)
> --8<---------------cut here---------------end--------------->8---
>
> I was neither able to understand the issue nor bisect to find the origin
> of that failure. Since I remember running the integration tests less
> than a week ago, I am suspecting that this might be related to new
> year...  I hope this is not actually the case.
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>

[Jacques Le Roux]

Right, it's now failing on Buildbot https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/

The last one passed the 1st because, as mentioned Jacopo, it's almost the 2nd of January

Jacques

Le 03/01/2020 à 09:15, Jacopo Cappellato a écrit :

> Hi Mathieu,
>
> it is actually probably related to the new Year... the demo data for the
> financial period has a thruDate="2020-01-01 23:59:59.000"
> I can have a look at this later today.
>
> Jacopo
>
>
> On Thu, Jan 2, 2020 at 7:32 PM Mathieu Lirzin <[hidden email]>
> wrote:
>
>> Hello,
>>
>> On my system I am noticing that the integration tests are failing with
>> the following error snippet:
>>
>> --8<---------------cut here---------------start------------->8---
>> $ ./gradlew "ofbiz --test component=accounting --test
>> suitename=accountingtests"
>> [...]
>> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>>    |I| -->
>> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest):
>> Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals
>> ERROR_JOURNAL as
>> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>>    |I| junit.framework.AssertionFailedError: Assertion failed:
>> [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
>>          at
>> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
>>          at junit.framework.TestSuite.runTest(TestSuite.java:252)
>>          at junit.framework.TestSuite.run(TestSuite.java:247)
>>          at
>> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
>>          at
>> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
>>          at
>> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
>>          at
>> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
>>          at
>> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
>>          at org.apache.ofbiz.base.start.Start.main(Start.java:90)
>> --8<---------------cut here---------------end--------------->8---
>>
>> I was neither able to understand the issue nor bisect to find the origin
>> of that failure. Since I remember running the integration tests less
>> than a week ago, I am suspecting that this might be related to new
>> year...  I hope this is not actually the case.
>>
>> --
>> Mathieu Lirzin
>> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>>

[Jacopo Cappellato-3]

I have committed a fix for the trunk, all tests should pass now. Still
needs to be backported to the active release branches.

Jacopo


On Fri, Jan 3, 2020 at 9:46 AM Jacques Le Roux <[hidden email]>
wrote:

> Right, it's now failing on Buildbot
> https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/
>
> The last one passed the 1st because, as mentioned Jacopo, it's almost the
> 2nd of January
>
> Jacques
>
> Le 03/01/2020 à 09:15, Jacopo Cappellato a écrit :
> > Hi Mathieu,
> >
> > it is actually probably related to the new Year... the demo data for the
> > financial period has a thruDate="2020-01-01 23:59:59.000"
> > I can have a look at this later today.
> >
> > Jacopo
> >
> >
> > On Thu, Jan 2, 2020 at 7:32 PM Mathieu Lirzin <[hidden email]
> >
> > wrote:
> >
> >> Hello,
> >>
> >> On my system I am noticing that the integration tests are failing with
> >> the following error snippet:
> >>
> >> --8<---------------cut here---------------start------------->8---
> >> $ ./gradlew "ofbiz --test component=accounting --test
> >> suitename=accountingtests"
> >> [...]
> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
> >>    |I| -->
> >>
> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest):
> >> Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals
> >> ERROR_JOURNAL as
> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
> >>    |I| junit.framework.AssertionFailedError: Assertion failed:
> >> [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
> >>          at
> >>
> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
> >>          at junit.framework.TestSuite.runTest(TestSuite.java:252)
> >>          at junit.framework.TestSuite.run(TestSuite.java:247)
> >>          at
> >>
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> >>          at
> >>
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
> >>          at
> >>
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
> >>          at
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
> >>          at
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
> >>          at org.apache.ofbiz.base.start.Start.main(Start.java:90)
> >> --8<---------------cut here---------------end--------------->8---
> >>
> >> I was neither able to understand the issue nor bisect to find the origin
> >> of that failure. Since I remember running the integration tests less
> >> than a week ago, I am suspecting that this might be related to new
> >> year...  I hope this is not actually the case.
> >>
> >> --
> >> Mathieu Lirzin
> >> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >>
>

[Mathieu Lirzin]

Hello Jacopo,

Thanks for taking care of that.

Jacopo Cappellato <[hidden email]> writes:

> I have committed a fix for the trunk, all tests should pass now. Still
> needs to be backported to the active release branches.
>
> Jacopo
>
>
> On Fri, Jan 3, 2020 at 9:46 AM Jacques Le Roux <[hidden email]>
> wrote:
>
>> Right, it's now failing on Buildbot
>> https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/
>>
>> The last one passed the 1st because, as mentioned Jacopo, it's almost the
>> 2nd of January
>>
>> Jacques
>>
>> Le 03/01/2020 à 09:15, Jacopo Cappellato a écrit :
>> > Hi Mathieu,
>> >
>> > it is actually probably related to the new Year... the demo data for the
>> > financial period has a thruDate="2020-01-01 23:59:59.000"
>> > I can have a look at this later today.
>> >
>> > Jacopo
>> >
>> >
>> > On Thu, Jan 2, 2020 at 7:32 PM Mathieu Lirzin <[hidden email]
>> >
>> > wrote:
>> >
>> >> Hello,
>> >>
>> >> On my system I am noticing that the integration tests are failing with
>> >> the following error snippet:
>> >>
>> >> --8<---------------cut here---------------start------------->8---
>> >> $ ./gradlew "ofbiz --test component=accounting --test
>> >> suitename=accountingtests"
>> >> [...]
>> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>> >>    |I| -->
>> >>
>> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest):
>> >> Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals
>> >> ERROR_JOURNAL as
>> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
>> >>    |I| junit.framework.AssertionFailedError: Assertion failed:
>> >> [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
>> >>          at
>> >>
>> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
>> >>          at junit.framework.TestSuite.runTest(TestSuite.java:252)
>> >>          at junit.framework.TestSuite.run(TestSuite.java:247)
>> >>          at
>> >>
>> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
>> >>          at
>> >>
>> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
>> >>          at
>> >>
>> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
>> >>          at
>> >>
>> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
>> >>          at
>> >>
>> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
>> >>          at org.apache.ofbiz.base.start.Start.main(Start.java:90)
>> >> --8<---------------cut here---------------end--------------->8---
>> >>
>> >> I was neither able to understand the issue nor bisect to find the origin
>> >> of that failure. Since I remember running the integration tests less
>> >> than a week ago, I am suspecting that this might be related to new
>> >> year...  I hope this is not actually the case.
>> >>
>> >> --
>> >> Mathieu Lirzin
>> >> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>> >>
>>

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Jacopo Cappellato-3]

I have now backported the same (or equivalent) fix to all the active
release branches.

Happy new failing test suite year! :-)

Jacopo

On Fri, Jan 3, 2020 at 2:21 PM Mathieu Lirzin <[hidden email]>
wrote:

> Hello Jacopo,
>
> Thanks for taking care of that.
>
> Jacopo Cappellato <[hidden email]> writes:
>
> > I have committed a fix for the trunk, all tests should pass now. Still
> > needs to be backported to the active release branches.
> >
> > Jacopo
> >
> >
> > On Fri, Jan 3, 2020 at 9:46 AM Jacques Le Roux <
> [hidden email]>
> > wrote:
> >
> >> Right, it's now failing on Buildbot
> >> https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/
> >>
> >> The last one passed the 1st because, as mentioned Jacopo, it's almost
> the
> >> 2nd of January
> >>
> >> Jacques
> >>
> >> Le 03/01/2020 à 09:15, Jacopo Cappellato a écrit :
> >> > Hi Mathieu,
> >> >
> >> > it is actually probably related to the new Year... the demo data for
> the
> >> > financial period has a thruDate="2020-01-01 23:59:59.000"
> >> > I can have a look at this later today.
> >> >
> >> > Jacopo
> >> >
> >> >
> >> > On Thu, Jan 2, 2020 at 7:32 PM Mathieu Lirzin <
> [hidden email]
> >> >
> >> > wrote:
> >> >
> >> >> Hello,
> >> >>
> >> >> On my system I am noticing that the integration tests are failing
> with
> >> >> the following error snippet:
> >> >>
> >> >> --8<---------------cut here---------------start------------->8---
> >> >> $ ./gradlew "ofbiz --test component=accounting --test
> >> >> suitename=accountingtests"
> >> >> [...]
> >> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
> >> >>    |I| -->
> >> >>
> >>
> auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier(org.apache.ofbiz.testtools.SimpleMethodTest):
> >> >> Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals
> >> >> ERROR_JOURNAL as
> >> >> 2020-01-02 19:15:11,829 |main                 |TestRunContainer
> >> >>    |I| junit.framework.AssertionFailedError: Assertion failed:
> >> >> [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals ERROR_JOURNAL as
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:98)
> >> >>          at junit.framework.TestSuite.runTest(TestSuite.java:252)
> >> >>          at junit.framework.TestSuite.run(TestSuite.java:247)
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:160)
> >> >>          at
> >> >>
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
> >> >>          at org.apache.ofbiz.base.start.Start.main(Start.java:90)
> >> >> --8<---------------cut here---------------end--------------->8---
> >> >>
> >> >> I was neither able to understand the issue nor bisect to find the
> origin
> >> >> of that failure. Since I remember running the integration tests less
> >> >> than a week ago, I am suspecting that this might be related to new
> >> >> year...  I hope this is not actually the case.
> >> >>
> >> >> --
> >> >> Mathieu Lirzin
> >> >> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >> >>
> >>
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>