OFBiz › OFBiz - User

Hard-code currency for shipment Option

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Simon Hutchinson-2

Hard-code currency for shipment Option

Hi,

In check-out process for eCommerce the descriptions of the shipment options include a price, however this always displayed as $ despite the uom for the shipment estimate being set to GBP.

I have looked at getShipOptions in CustomerEvents.xml and it appears that the currency symbol is hard-coded at the moment - notice the extra $ before $${shippingEst}

<set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>

I am happy to fix this but was hoping that someone could please point me in the right direction for getting the correct currency symbol.

I have seen the @ofbizCurrency tag used in freemarker templats however I would need something equivalent from Minilang to solve here as the result of getShipOptions is simply returned as json to a javascript function in checkoutProcess.js

Note: The getShipOptions simple method uses this

<call-object-method obj-field="shoppingCart" method-name="getCurrency" ret-field="currency"/>

which returns the ISO value, in my case GBP -
Can I call something to get the £ symbol for this ISO code perhaps?

Regards

Simon

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

Have you set the currency.uom.id.default to GBP in general.properties

On Fri, Sep 25, 2009 at 4:07 PM, Simon Hutchinson <
[hidden email]> wrote:

> Hi,
>
> In check-out process for eCommerce the descriptions of the shipment options
> include a price, however this always displayed as $ despite the uom for the
> shipment estimate being set to GBP.
>
> I have looked at getShipOptions in CustomerEvents.xml and it appears that
> the currency symbol is hard-coded at the moment - notice the extra $ before
> $${shippingEst}
>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> ${carrierShipmentMethod.description} - $${shippingEst}"/>
>
> I am happy to fix this but was hoping that someone could please point me in
> the right direction for getting the correct currency symbol.
>
> I have seen the @ofbizCurrency tag used in freemarker templats however I
> would need something equivalent from Minilang to solve here as the result of
> getShipOptions is simply returned as json to a javascript function in
> checkoutProcess.js
>
> Note: The getShipOptions simple method uses this
>
> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
> ret-field="currency"/>
>
> which returns the ISO value, in my case GBP -
> Can I call something to get the £ symbol for this ISO code perhaps?
>
> Regards
>
> Simon
>

Simon Hutchinson-2

RE: Hard-code currency for shipment Option

Thanks Abdullah

I hadn't set that, however I don't think that this alone will solve the problem as the simple-method is simple entering $ as text. Do you know how I can get the correct symbol programatically?

BR

Simon

-----Original Message-----
From: [hidden email] on behalf of Abdullah Shaikh
Sent: Fri 9/25/2009 11:43 AM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

Have you set the currency.uom.id.default to GBP in general.properties

On Fri, Sep 25, 2009 at 4:07 PM, Simon Hutchinson <
[hidden email]> wrote:

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

Simon,

There are, I don't remember exactly, I guess configuration settings in 2
places, payment.properties & under Store > Localisation, you need to set
Default Locale String to en_GB & Default Currency Uom Id to GBP - British
Pound.

I guess these settings should do, just clear your browser cache and try with
these settings.

On Fri, Sep 25, 2009 at 4:17 PM, Simon Hutchinson <
[hidden email]> wrote:

> Thanks Abdullah
>
> I hadn't set that, however I don't think that this alone will solve the
> problem as the simple-method is simple entering $ as text. Do you know how I
> can get the correct symbol programatically?
>
> BR
>
> Simon
>
>
> -----Original Message-----
> From: [hidden email] on behalf of Abdullah Shaikh
> Sent: Fri 9/25/2009 11:43 AM
> To: [hidden email]
> Subject: Re: Hard-code currency for shipment Option
>
> Have you set the currency.uom.id.default to GBP in general.properties
>
> On Fri, Sep 25, 2009 at 4:07 PM, Simon Hutchinson <
> [hidden email]> wrote:
>
> > Hi,
> >
> > In check-out process for eCommerce the descriptions of the shipment
> options
> > include a price, however this always displayed as $ despite the uom for
> the
> > shipment estimate being set to GBP.
> >
> > I have looked at getShipOptions in CustomerEvents.xml and it appears that
> > the currency symbol is hard-coded at the moment - notice the extra $
> before
> > $${shippingEst}
> >
> > <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> > ${carrierShipmentMethod.description} - $${shippingEst}"/>
> >
> > I am happy to fix this but was hoping that someone could please point me
> in
> > the right direction for getting the correct currency symbol.
> >
> > I have seen the @ofbizCurrency tag used in freemarker templats however I
> > would need something equivalent from Minilang to solve here as the result
> of
> > getShipOptions is simply returned as json to a javascript function in
> > checkoutProcess.js
> >
> > Note: The getShipOptions simple method uses this
> >
> > <call-object-method obj-field="shoppingCart" method-name="getCurrency"
> > ret-field="currency"/>
> >
> > which returns the ISO value, in my case GBP -
> > Can I call something to get the £ symbol for this ISO code perhaps?
> >
> > Regards
> >
> > Simon
> >
>
>

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

Hi Simon,

I have just checked it out with the ecommerce application, it optional to
set the currency.uom.id.default in general.properties, but you need to set
the settings in store > localisation as mentioned before.

To test checkout with these new settings, I added the GBP price to the Tiny
Chrome Widget, added it to the cart and went for quick checkout, there
shipping estimates were displayed in £.

I hope this helps.

On Fri, Sep 25, 2009 at 4:29 PM, Abdullah Shaikh <
[hidden email]> wrote:

> Simon,
>
> There are, I don't remember exactly, I guess configuration settings in 2
> places, payment.properties & under Store > Localisation, you need to set
> Default Locale String to en_GB & Default Currency Uom Id to GBP - British
> Pound.
>
> I guess these settings should do, just clear your browser cache and try
> with these settings.
>
>
>
> On Fri, Sep 25, 2009 at 4:17 PM, Simon Hutchinson <
> [hidden email]> wrote:
>
>> Thanks Abdullah
>>
>> I hadn't set that, however I don't think that this alone will solve the
>> problem as the simple-method is simple entering $ as text. Do you know how I
>> can get the correct symbol programatically?
>>
>> BR
>>
>> Simon
>>
>>
>> -----Original Message-----
>> From: [hidden email] on behalf of Abdullah Shaikh
>> Sent: Fri 9/25/2009 11:43 AM
>> To: [hidden email]
>> Subject: Re: Hard-code currency for shipment Option
>>
>> Have you set the currency.uom.id.default to GBP in general.properties
>>
>> On Fri, Sep 25, 2009 at 4:07 PM, Simon Hutchinson <
>> [hidden email]> wrote:
>>
>> > Hi,
>> >
>> > In check-out process for eCommerce the descriptions of the shipment
>> options
>> > include a price, however this always displayed as $ despite the uom for
>> the
>> > shipment estimate being set to GBP.
>> >
>> > I have looked at getShipOptions in CustomerEvents.xml and it appears
>> that
>> > the currency symbol is hard-coded at the moment - notice the extra $
>> before
>> > $${shippingEst}
>> >
>> > <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>> > ${carrierShipmentMethod.description} - $${shippingEst}"/>
>> >
>> > I am happy to fix this but was hoping that someone could please point me
>> in
>> > the right direction for getting the correct currency symbol.
>> >
>> > I have seen the @ofbizCurrency tag used in freemarker templats however I
>> > would need something equivalent from Minilang to solve here as the
>> result of
>> > getShipOptions is simply returned as json to a javascript function in
>> > checkoutProcess.js
>> >
>> > Note: The getShipOptions simple method uses this
>> >
>> > <call-object-method obj-field="shoppingCart" method-name="getCurrency"
>> > ret-field="currency"/>
>> >
>> > which returns the ISO value, in my case GBP -
>> > Can I call something to get the £ symbol for this ISO code perhaps?
>> >
>> > Regards
>> >
>> > Simon
>> >
>>
>>
>

Simon Hutchinson-2

RE: Hard-code currency for shipment Option

hi Abdullah,

Thanks for your time on this.

I have made the changes that you suggested but while the £ is displayed correctly for product, totals etc .... the description of the shipping options a still shown in $.

The attached image should clarify - Note that the figures in the cost summary at the top show correctly in £ but the options in the select box for the shipping method are still shown as $.

I think that the dollar sign will always be shown here as it is hard-coded in the CustomEvents.xml file.

Can you confirm the decriptions options in your select box for shipping options?

Regards,

Simon

-----Original Message-----
From: [hidden email] on behalf of Abdullah Shaikh
Sent: Fri 9/25/2009 12:38 PM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

Hi Simon,

I have just checked it out with the ecommerce application, it optional to
set the currency.uom.id.default in general.properties, but you need to set
the settings in store > localisation as mentioned before.

To test checkout with these new settings, I added the GBP price to the Tiny
Chrome Widget, added it to the cart and went for quick checkout, there
shipping estimates were displayed in £.

I hope this helps.

On Fri, Sep 25, 2009 at 4:29 PM, Abdullah Shaikh <
[hidden email]> wrote:

Simon Hutchinson-2

RE: Hard-code currency for shipment Option (with attached image)

In reply to this post by Abdullah Shaikh-3

Here is the screenshot. I forgot to attach it before

-----Original Message-----
From: [hidden email] on behalf of Abdullah Shaikh
Sent: Fri 9/25/2009 12:38 PM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

Hi Simon,

I have just checked it out with the ecommerce application, it optional to
set the currency.uom.id.default in general.properties, but you need to set
the settings in store > localisation as mentioned before.

To test checkout with these new settings, I added the GBP price to the Tiny
Chrome Widget, added it to the cart and went for quick checkout, there
shipping estimates were displayed in £.

I hope this helps.

On Fri, Sep 25, 2009 at 4:29 PM, Abdullah Shaikh <
[hidden email]> wrote:

Jacques Le Roux

Re: Hard-code currency for shipment Option (with attached image)

Administrator

You cant't attach in this thread. You may use Nabble for that.
What you are looking for is the macro <@ofbizcurrency>, look for usage in code. A Jira would be welcome

Thanks

Jacques

From: "Simon Hutchinson" <[hidden email]>
Here is the screenshot. I forgot to attach it before

-----Original Message-----
From: [hidden email] on behalf of Abdullah Shaikh
Sent: Fri 9/25/2009 12:38 PM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

Hi Simon,

I have just checked it out with the ecommerce application, it optional to
set the currency.uom.id.default in general.properties, but you need to set
the settings in store > localisation as mentioned before.

To test checkout with these new settings, I added the GBP price to the Tiny
Chrome Widget, added it to the cart and went for quick checkout, there
shipping estimates were displayed in £.

I hope this helps.

On Fri, Sep 25, 2009 at 4:29 PM, Abdullah Shaikh <
[hidden email]> wrote:

Adrian Crum

Re: Hard-code currency for shipment Option

In reply to this post by Simon Hutchinson-2

Simon,

You will need to use the ?currency(String IsoCode) string expansion
modifier in the set element:

<set field="shippingDesc" value="${carrierShipmentMethod.partyId}
${carrierShipmentMethod.description} - ${shippingEst?currency(String
IsoCode)}"/>

Search the existing XML files for "?currency(" and you will see how it
is used.

Once you have the problem corrected, supply a patch to Jira and we will
see to it that it is included in the project.

-Adrian

Simon Hutchinson wrote:

> Hi,
>
> In check-out process for eCommerce the descriptions of the shipment options include a price, however this always displayed as $ despite the uom for the shipment estimate being set to GBP.
>
> I have looked at getShipOptions in CustomerEvents.xml and it appears that the currency symbol is hard-coded at the moment - notice the extra $ before $${shippingEst}
>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>
>
> I am happy to fix this but was hoping that someone could please point me in the right direction for getting the correct currency symbol.
>
> I have seen the @ofbizCurrency tag used in freemarker templats however I would need something equivalent from Minilang to solve here as the result of getShipOptions is simply returned as json to a javascript function in checkoutProcess.js
>
> Note: The getShipOptions simple method uses this
>
> <call-object-method obj-field="shoppingCart" method-name="getCurrency" ret-field="currency"/>
>
> which returns the ISO value, in my case GBP -
> Can I call something to get the £ symbol for this ISO code perhaps?
>
> Regards
>
> Simon
>

Abdullah Shaikh

Re: Hard-code currency for shipment Option

In reply to this post by Simon Hutchinson-2

Yes you are right, the $ symbol gets displayed in the description. I was
trying out with the checkout & quick checkout option, but the select box
appears in the One Page Checkout option.

On Fri, Sep 25, 2009 at 5:24 PM, Simon Hutchinson <
[hidden email]> wrote:

> hi Abdullah,
>
> Thanks for your time on this.
>
> I have made the changes that you suggested but while the £ is displayed
> correctly for product, totals etc .... the description of the shipping
> options a still shown in $.
>
> The attached image should clarify - Note that the figures in the cost
> summary at the top show correctly in £ but the options in the select box for
> the shipping method are still shown as $.
>
> I think that the dollar sign will always be shown here as it is hard-coded
> in the CustomEvents.xml file.
>
> Can you confirm the decriptions options in your select box for shipping
> options?
>
> Regards,
>
> Simon
>
>
> -----Original Message-----
> From: [hidden email] on behalf of Abdullah Shaikh
> Sent: Fri 9/25/2009 12:38 PM
> To: [hidden email]
> Subject: Re: Hard-code currency for shipment Option
>
> Hi Simon,
>
> I have just checked it out with the ecommerce application, it optional to
> set the currency.uom.id.default in general.properties, but you need to set
> the settings in store > localisation as mentioned before.
>
> To test checkout with these new settings, I added the GBP price to the Tiny
> Chrome Widget, added it to the cart and went for quick checkout, there
> shipping estimates were displayed in £.
>
> I hope this helps.
>
>
> On Fri, Sep 25, 2009 at 4:29 PM, Abdullah Shaikh <
> [hidden email]> wrote:
>
> > Simon,
> >
> > There are, I don't remember exactly, I guess configuration settings in 2
> > places, payment.properties & under Store > Localisation, you need to set
> > Default Locale String to en_GB & Default Currency Uom Id to GBP - British
> > Pound.
> >
> > I guess these settings should do, just clear your browser cache and try
> > with these settings.
> >
> >
> >
> > On Fri, Sep 25, 2009 at 4:17 PM, Simon Hutchinson <
> > [hidden email]> wrote:
> >
> >> Thanks Abdullah
> >>
> >> I hadn't set that, however I don't think that this alone will solve the
> >> problem as the simple-method is simple entering $ as text. Do you know
> how I
> >> can get the correct symbol programatically?
> >>
> >> BR
> >>
> >> Simon
> >>
> >>
> >> -----Original Message-----
> >> From: [hidden email] on behalf of Abdullah Shaikh
> >> Sent: Fri 9/25/2009 11:43 AM
> >> To: [hidden email]
> >> Subject: Re: Hard-code currency for shipment Option
> >>
> >> Have you set the currency.uom.id.default to GBP in general.properties
> >>
> >> On Fri, Sep 25, 2009 at 4:07 PM, Simon Hutchinson <
> >> [hidden email]> wrote:
> >>
> >> > Hi,
> >> >
> >> > In check-out process for eCommerce the descriptions of the shipment
> >> options
> >> > include a price, however this always displayed as $ despite the uom
> for
> >> the
> >> > shipment estimate being set to GBP.
> >> >
> >> > I have looked at getShipOptions in CustomerEvents.xml and it appears
> >> that
> >> > the currency symbol is hard-coded at the moment - notice the extra $
> >> before
> >> > $${shippingEst}
> >> >
> >> > <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> >> > ${carrierShipmentMethod.description} - $${shippingEst}"/>
> >> >
> >> > I am happy to fix this but was hoping that someone could please point
> me
> >> in
> >> > the right direction for getting the correct currency symbol.
> >> >
> >> > I have seen the @ofbizCurrency tag used in freemarker templats however
> I
> >> > would need something equivalent from Minilang to solve here as the
> >> result of
> >> > getShipOptions is simply returned as json to a javascript function in
> >> > checkoutProcess.js
> >> >
> >> > Note: The getShipOptions simple method uses this
> >> >
> >> > <call-object-method obj-field="shoppingCart" method-name="getCurrency"
> >> > ret-field="currency"/>
> >> >
> >> > which returns the ISO value, in my case GBP -
> >> > Can I call something to get the £ symbol for this ISO code perhaps?
> >> >
> >> > Regards
> >> >
> >> > Simon
> >> >
> >>
> >>
> >
>
>

Simon Hutchinson-2

RE: Hard-code currency for shipment Option

Thanks Abdullah,

I have logged this in Jira and will fix shortly.

https://issues.apache.org/jira/browse/OFBIZ-2971

Simon

-----Original Message-----
From: Abdullah Shaikh [mailto:[hidden email]]
Sent: Fri 9/25/2009 3:49 PM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

Yes you are right, the $ symbol gets displayed in the description. I was
trying out with the checkout & quick checkout option, but the select box
appears in the One Page Checkout option.

On Fri, Sep 25, 2009 at 5:24 PM, Simon Hutchinson <
[hidden email]> wrote:

Adrian Crum

Re: Hard-code currency for shipment Option

In reply to this post by Adrian Crum

Oops, that example should be:

<set field="shippingDesc" value="${carrierShipmentMethod.partyId}
${carrierShipmentMethod.description} - ${shippingEst?currency(isoCode)}"/>

-Adrian

Adrian Crum wrote:

> Simon,
>
> You will need to use the ?currency(String IsoCode) string expansion
> modifier in the set element:
>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> ${carrierShipmentMethod.description} - ${shippingEst?currency(String
> IsoCode)}"/>
>
> Search the existing XML files for "?currency(" and you will see how it
> is used.
>
> Once you have the problem corrected, supply a patch to Jira and we will
> see to it that it is included in the project.
>
> -Adrian
>
>
> Simon Hutchinson wrote:
>> Hi,
>>
>> In check-out process for eCommerce the descriptions of the shipment
>> options include a price, however this always displayed as $ despite
>> the uom for the shipment estimate being set to GBP.
>>
>> I have looked at getShipOptions in CustomerEvents.xml and it appears
>> that the currency symbol is hard-coded at the moment - notice the
>> extra $ before $${shippingEst}
>>
>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>> ${carrierShipmentMethod.description} - $${shippingEst}"/>
>>
>> I am happy to fix this but was hoping that someone could please point
>> me in the right direction for getting the correct currency symbol.
>>
>> I have seen the @ofbizCurrency tag used in freemarker templats however
>> I would need something equivalent from Minilang to solve here as the
>> result of getShipOptions is simply returned as json to a javascript
>> function in checkoutProcess.js
>>
>> Note: The getShipOptions simple method uses this
>> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
>> ret-field="currency"/>
>>
>> which returns the ISO value, in my case GBP - Can I call something to
>> get the £ symbol for this ISO code perhaps?
>>
>> Regards
>>
>> Simon
>

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

Adrian, you missed the ${} around isoCode, but even that doesn't work, it
displays the $ symbol, probably the isoCode is not getting updated.

On Fri, Sep 25, 2009 at 8:27 PM, Adrian Crum <[hidden email]> wrote:

> Oops, that example should be:
>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> ${carrierShipmentMethod.description} - ${shippingEst?currency(isoCode)}"/>
>
> -Adrian
>
>
> Adrian Crum wrote:
>
>> Simon,
>>
>> You will need to use the ?currency(String IsoCode) string expansion
>> modifier in the set element:
>>
>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>> ${carrierShipmentMethod.description} - ${shippingEst?currency(String
>> IsoCode)}"/>
>>
>> Search the existing XML files for "?currency(" and you will see how it is
>> used.
>>
>> Once you have the problem corrected, supply a patch to Jira and we will
>> see to it that it is included in the project.
>>
>> -Adrian
>>
>>
>> Simon Hutchinson wrote:
>>
>>> Hi,
>>>
>>> In check-out process for eCommerce the descriptions of the shipment
>>> options include a price, however this always displayed as $ despite the uom
>>> for the shipment estimate being set to GBP.
>>>
>>> I have looked at getShipOptions in CustomerEvents.xml and it appears that
>>> the currency symbol is hard-coded at the moment - notice the extra $ before
>>> $${shippingEst}
>>>
>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>> ${carrierShipmentMethod.description} - $${shippingEst}"/>
>>>
>>> I am happy to fix this but was hoping that someone could please point me
>>> in the right direction for getting the correct currency symbol.
>>>
>>> I have seen the @ofbizCurrency tag used in freemarker templats however I
>>> would need something equivalent from Minilang to solve here as the result of
>>> getShipOptions is simply returned as json to a javascript function in
>>> checkoutProcess.js
>>>
>>> Note: The getShipOptions simple method uses this
>>> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
>>> ret-field="currency"/>
>>>
>>> which returns the ISO value, in my case GBP - Can I call something to get
>>> the £ symbol for this ISO code perhaps?
>>>
>>> Regards
>>>
>>> Simon
>>>
>>
>>

Adrian Crum

Re: Hard-code currency for shipment Option

There is no doubt the ISO code needs to be set up prior to the set
element. That is why I suggested using existing implementations as a guide.

-Adrian

Abdullah Shaikh wrote:

> Adrian, you missed the ${} around isoCode, but even that doesn't work, it
> displays the $ symbol, probably the isoCode is not getting updated.
>
>
> On Fri, Sep 25, 2009 at 8:27 PM, Adrian Crum <[hidden email]> wrote:
>
>> Oops, that example should be:
>>
>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>> ${carrierShipmentMethod.description} - ${shippingEst?currency(isoCode)}"/>
>>
>> -Adrian
>>
>>
>> Adrian Crum wrote:
>>
>>> Simon,
>>>
>>> You will need to use the ?currency(String IsoCode) string expansion
>>> modifier in the set element:
>>>
>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>> ${carrierShipmentMethod.description} - ${shippingEst?currency(String
>>> IsoCode)}"/>
>>>
>>> Search the existing XML files for "?currency(" and you will see how it is
>>> used.
>>>
>>> Once you have the problem corrected, supply a patch to Jira and we will
>>> see to it that it is included in the project.
>>>
>>> -Adrian
>>>
>>>
>>> Simon Hutchinson wrote:
>>>
>>>> Hi,
>>>>
>>>> In check-out process for eCommerce the descriptions of the shipment
>>>> options include a price, however this always displayed as $ despite the uom
>>>> for the shipment estimate being set to GBP.
>>>>
>>>> I have looked at getShipOptions in CustomerEvents.xml and it appears that
>>>> the currency symbol is hard-coded at the moment - notice the extra $ before
>>>> $${shippingEst}
>>>>
>>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>>> ${carrierShipmentMethod.description} - $${shippingEst}"/>
>>>>
>>>> I am happy to fix this but was hoping that someone could please point me
>>>> in the right direction for getting the correct currency symbol.
>>>>
>>>> I have seen the @ofbizCurrency tag used in freemarker templats however I
>>>> would need something equivalent from Minilang to solve here as the result of
>>>> getShipOptions is simply returned as json to a javascript function in
>>>> checkoutProcess.js
>>>>
>>>> Note: The getShipOptions simple method uses this
>>>> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
>>>> ret-field="currency"/>
>>>>
>>>> which returns the ISO value, in my case GBP - Can I call something to get
>>>> the £ symbol for this ISO code perhaps?
>>>>
>>>> Regards
>>>>
>>>> Simon
>>>>
>>>
>

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

oh I thought that the isoCode is already set earlier somewhere in the flow

On Fri, Sep 25, 2009 at 8:43 PM, Adrian Crum <[hidden email]> wrote:

> There is no doubt the ISO code needs to be set up prior to the set element.
> That is why I suggested using existing implementations as a guide.
>
> -Adrian
>
>
> Abdullah Shaikh wrote:
>
>> Adrian, you missed the ${} around isoCode, but even that doesn't work, it
>> displays the $ symbol, probably the isoCode is not getting updated.
>>
>>
>> On Fri, Sep 25, 2009 at 8:27 PM, Adrian Crum <[hidden email]> wrote:
>>
>> Oops, that example should be:
>>>
>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>> ${carrierShipmentMethod.description} -
>>> ${shippingEst?currency(isoCode)}"/>
>>>
>>> -Adrian
>>>
>>>
>>> Adrian Crum wrote:
>>>
>>> Simon,
>>>>
>>>> You will need to use the ?currency(String IsoCode) string expansion
>>>> modifier in the set element:
>>>>
>>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>>> ${carrierShipmentMethod.description} - ${shippingEst?currency(String
>>>> IsoCode)}"/>
>>>>
>>>> Search the existing XML files for "?currency(" and you will see how it
>>>> is
>>>> used.
>>>>
>>>> Once you have the problem corrected, supply a patch to Jira and we will
>>>> see to it that it is included in the project.
>>>>
>>>> -Adrian
>>>>
>>>>
>>>> Simon Hutchinson wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> In check-out process for eCommerce the descriptions of the shipment
>>>>> options include a price, however this always displayed as $ despite the
>>>>> uom
>>>>> for the shipment estimate being set to GBP.
>>>>>
>>>>> I have looked at getShipOptions in CustomerEvents.xml and it appears
>>>>> that
>>>>> the currency symbol is hard-coded at the moment - notice the extra $
>>>>> before
>>>>> $${shippingEst}
>>>>>
>>>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
>>>>> ${carrierShipmentMethod.description} - $${shippingEst}"/>
>>>>>
>>>>> I am happy to fix this but was hoping that someone could please point
>>>>> me
>>>>> in the right direction for getting the correct currency symbol.
>>>>>
>>>>> I have seen the @ofbizCurrency tag used in freemarker templats however
>>>>> I
>>>>> would need something equivalent from Minilang to solve here as the
>>>>> result of
>>>>> getShipOptions is simply returned as json to a javascript function in
>>>>> checkoutProcess.js
>>>>>
>>>>> Note: The getShipOptions simple method uses this
>>>>> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
>>>>> ret-field="currency"/>
>>>>>
>>>>> which returns the ISO value, in my case GBP - Can I call something to
>>>>> get
>>>>> the £ symbol for this ISO code perhaps?
>>>>>
>>>>> Regards
>>>>>
>>>>> Simon
>>>>>
>>>>>
>>>>
>>

Simon Hutchinson-2

RE: Hard-code currency for shipment Option

The isoCode of the currency for the cart seems to be be available

<call-object-method obj-field="shoppingCart" method-name="getCurrency" ret-field="currency"/>

Such that this would work

${shippingEst?currency(${currency})}${shippingEst}

Is the currency code of the shoppingCart acceptable to use here as I see that the ShipmentCostEstimate entity has a priceUomId field.

Simon

-----Original Message-----
From: [hidden email] on behalf of Abdullah Shaikh
Sent: Fri 9/25/2009 4:19 PM
To: [hidden email]
Subject: Re: Hard-code currency for shipment Option

oh I thought that the isoCode is already set earlier somewhere in the flow

On Fri, Sep 25, 2009 at 8:43 PM, Adrian Crum <[hidden email]> wrote:

Abdullah Shaikh-3

Re: Hard-code currency for shipment Option

I guess you can go with the shoppingCart currency code as the shoppingCart
has the configured currency code.

On Fri, Sep 25, 2009 at 9:03 PM, Simon Hutchinson <
[hidden email]> wrote:

> The isoCode of the currency for the cart seems to be be available
>
> <call-object-method obj-field="shoppingCart" method-name="getCurrency"
> ret-field="currency"/>
>
> Such that this would work
>
> ${shippingEst?currency(${currency})}${shippingEst}
>
> Is the currency code of the shoppingCart acceptable to use here as I see
> that the ShipmentCostEstimate entity has a priceUomId field.
>
> Simon
>
>
> -----Original Message-----
> From: [hidden email] on behalf of Abdullah Shaikh
> Sent: Fri 9/25/2009 4:19 PM
> To: [hidden email]
> Subject: Re: Hard-code currency for shipment Option
>
> oh I thought that the isoCode is already set earlier somewhere in the flow
>
> On Fri, Sep 25, 2009 at 8:43 PM, Adrian Crum <[hidden email]> wrote:
>
> > There is no doubt the ISO code needs to be set up prior to the set
> element.
> > That is why I suggested using existing implementations as a guide.
> >
> > -Adrian
> >
> >
> > Abdullah Shaikh wrote:
> >
> >> Adrian, you missed the ${} around isoCode, but even that doesn't work,
> it
> >> displays the $ symbol, probably the isoCode is not getting updated.
> >>
> >>
> >> On Fri, Sep 25, 2009 at 8:27 PM, Adrian Crum <[hidden email]>
> wrote:
> >>
> >> Oops, that example should be:
> >>>
> >>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> >>> ${carrierShipmentMethod.description} -
> >>> ${shippingEst?currency(isoCode)}"/>
> >>>
> >>> -Adrian
> >>>
> >>>
> >>> Adrian Crum wrote:
> >>>
> >>> Simon,
> >>>>
> >>>> You will need to use the ?currency(String IsoCode) string expansion
> >>>> modifier in the set element:
> >>>>
> >>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> >>>> ${carrierShipmentMethod.description} - ${shippingEst?currency(String
> >>>> IsoCode)}"/>
> >>>>
> >>>> Search the existing XML files for "?currency(" and you will see how it
> >>>> is
> >>>> used.
> >>>>
> >>>> Once you have the problem corrected, supply a patch to Jira and we
> will
> >>>> see to it that it is included in the project.
> >>>>
> >>>> -Adrian
> >>>>
> >>>>
> >>>> Simon Hutchinson wrote:
> >>>>
> >>>> Hi,
> >>>>>
> >>>>> In check-out process for eCommerce the descriptions of the shipment
> >>>>> options include a price, however this always displayed as $ despite
> the
> >>>>> uom
> >>>>> for the shipment estimate being set to GBP.
> >>>>>
> >>>>> I have looked at getShipOptions in CustomerEvents.xml and it appears
> >>>>> that
> >>>>> the currency symbol is hard-coded at the moment - notice the extra $
> >>>>> before
> >>>>> $${shippingEst}
> >>>>>
> >>>>> <set field="shippingDesc" value="${carrierShipmentMethod.partyId}
> >>>>> ${carrierShipmentMethod.description} - $${shippingEst}"/>
> >>>>>
> >>>>> I am happy to fix this but was hoping that someone could please point
> >>>>> me
> >>>>> in the right direction for getting the correct currency symbol.
> >>>>>
> >>>>> I have seen the @ofbizCurrency tag used in freemarker templats
> however
> >>>>> I
> >>>>> would need something equivalent from Minilang to solve here as the
> >>>>> result of
> >>>>> getShipOptions is simply returned as json to a javascript function in
> >>>>> checkoutProcess.js
> >>>>>
> >>>>> Note: The getShipOptions simple method uses this
> >>>>> <call-object-method obj-field="shoppingCart"
> method-name="getCurrency"
> >>>>> ret-field="currency"/>
> >>>>>
> >>>>> which returns the ISO value, in my case GBP - Can I call something to
> >>>>> get
> >>>>> the £ symbol for this ISO code perhaps?
> >>>>>
> >>>>> Regards
> >>>>>
> >>>>> Simon
> >>>>>
> >>>>>
> >>>>
> >>
>
>