I unsubscribed but keep getting mails

[Bellave Jayaram]

Can someone please unsubscribe me from these two lists or tell me how to do
it?

Thanks,
Jayaram


I think any code (or entity) intended for removal should be marked
"deprecated" for some period so that anyone using them have time to change
their implementation. Subsequently, it should be simply removed.

Regards,
Vinay Agarwal


-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Friday, June 23, 2006 2:24 PM
To: [hidden email]
Subject: Re: removing some code from the SVN

I agree with BJ

Jacques

> I would like to see both on additions, changes, removing, a comment
> left in the code.
> in your case a simple removed see such and such.
> Also like to see a Jira with the deleted code so someone could uses it
> if they wanted.
>
> Si Chen sent the following on 6/23/06 12:07 PM:
> > Hi.  What should be our policy for removing code when we have a  
> > better implementation?  We originally put some code in OrderServices  
> > for auto-exploding marketing packages, but now with Jacopo's new
> > auto production run that code is no longer needed by us at least.  I
> > was also never fully satisfied with the code -- it caused all sorts
> > of problems when there were fractions or adjustments, so I'd like to
> > remove.  Is that OK?
> >
> > Si
> >

    [ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417561 ]

Vinay Agarwal commented on OFBIZ-47:
------------------------------------

Jacques,

That sequence actually makes sense. A sale is recognized (GAAP) when the item is shipped. Therefore, an invoice can only be generated after that. Any payment received before invoice generation is simply an advance. Once the invoice is generated, a payment can be applied to that invoice.

Also, from order application, in OrderTypeData.xml, you can see the valid status change sequences as follows:

    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_PROCESSING" transitionName="Process Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_SENT" transitionName="Send Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_PROCESSING" transitionName="Hold Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_COMPLETED" transitionName="Complete Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_COMPLETED" transitionName="Order Completed"/>
    <StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_CANCELLED" transitionName="Order Cancelled"/>

Regards,
Vinay

> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
>          Key: OFBIZ-47
>          URL: http://issues.apache.org/jira/browse/OFBIZ-47
>      Project: The Open For Business Project
>         Type: Bug

>   Components: order
>     Versions: SVN trunk
>  Environment: svn 7817
>     Reporter: Jacques Le Roux
>     Assignee: Si Chen
>     Priority: Blocker
>      Fix For: SVN trunk
>  Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira