[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-47) createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-47?page=comments#action_12417561 ]

Vinay Agarwal commented on OFBIZ-47:
------------------------------------

Jacques,

That sequence actually makes sense. A sale is recognized (GAAP) when the item is shipped. Therefore, an invoice can only be generated after that. Any payment received before invoice generation is simply an advance. Once the invoice is generated, a payment can be applied to that invoice.

Also, from order application, in OrderTypeData.xml, you can see the valid status change sequences as follows:

    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_PROCESSING" transitionName="Process Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
    <StatusValidChange condition="" statusId="ORDER_CREATED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_APPROVED" transitionName="Approve Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_REJECTED" transitionName="Reject Order"/>
    <StatusValidChange condition="" statusId="ORDER_PROCESSING" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_SENT" transitionName="Send Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_PROCESSING" transitionName="Hold Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_COMPLETED" transitionName="Complete Order"/>
    <StatusValidChange condition="" statusId="ORDER_APPROVED" statusIdTo="ORDER_CANCELLED" transitionName="Cancel Order"/>
    <StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_COMPLETED" transitionName="Order Completed"/>
    <StatusValidChange condition="" statusId="ORDER_SENT" statusIdTo="ORDER_CANCELLED" transitionName="Order Cancelled"/>

Regards,
Vinay

> createCommissionInvoices throws a "BigInteger divide by zero" in case of Quick Ship Order and "Mail Check/Money Order" paiement
> -------------------------------------------------------------------------------------------------------------------------------
>
>          Key: OFBIZ-47
>          URL: http://issues.apache.org/jira/browse/OFBIZ-47
>      Project: The Open For Business Project
>         Type: Bug

>   Components: order
>     Versions: SVN trunk
>  Environment: svn 7817
>     Reporter: Jacques Le Roux
>     Assignee: Si Chen
>     Priority: Blocker
>      Fix For: SVN trunk
>  Attachments: 06-06-22 CommDivZ.patch
>
> Make an order from ecommerce, pay by "Mail Check/Money Order", receive paiement, try "Quick Ship Order" : createCommissionInvoices throws a "BigInteger divide by zero"
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira