IMPROVEMENT: Checkstyle formatting issues

[Suraj Khurana-2]

Hello Devs,

Hope you are doing good !!

Currently, there are many checkstyle issues in code base which are due to
formatting best practices, like indentation, using spaces before/after
symbols etc.

We can solve many thousands of such issues by correcting all such
occurrences. Please share your thoughts on this.

A known thing is that we will lose the last history of such codebase while
doing this re-factoring.

Any other ideas to solve the problem are most welcome.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant

[Jacques Le Roux]

Hi Suraj,

I tend to agree, most of the time the history can be rebuild with blame using lines around, or even looking into commits.

Jacques

Le 30/05/2020 à 18:25, Suraj Khurana a écrit :

> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant

[Michael Brohl-3]

Hi Suraj,

+1 for the refactoring in general. What history do we lose while
refactoring?

Thanks,

Michael


Am 30.05.20 um 18:25 schrieb Suraj Khurana:

> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>

[Jacques Le Roux]

Hi Michael,

Information from Git history and blame mostly, I'd say

Jacques

Le 01/06/2020 à 11:13, Michael Brohl a écrit :

> Hi Suraj,
>
> +1 for the refactoring in general. What history do we lose while refactoring?
>
> Thanks,
>
> Michael
>
>
> Am 30.05.20 um 18:25 schrieb Suraj Khurana:
>> Hello Devs,
>>
>> Hope you are doing good !!
>>
>> Currently, there are many checkstyle issues in code base which are due to
>> formatting best practices, like indentation, using spaces before/after
>> symbols etc.
>>
>> We can solve many thousands of such issues by correcting all such
>> occurrences. Please share your thoughts on this.
>>
>> A known thing is that we will lose the last history of such codebase while
>> doing this re-factoring.
>>
>> Any other ideas to solve the problem are most welcome.
>> --
>> Best Regards,
>> Suraj Khurana
>> Senior Technical Consultant
>>
>

[Suraj Khurana-2]

Hello Michael,

Just the very last commit on that particular line that we check while
annotating. Nothing else. As Jacques mentioned most of the time the history
can be rebuilt with blame using lines around.

--
Best Regards,
Suraj Khurana
SENIOR TECHNICAL CONSULTANT
mobile: [phone]
email: [hidden email]
*www.hotwax.co <http://www.hotwax.co/>*


On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl <[hidden email]>
wrote:

> Hi Suraj,
>
> +1 for the refactoring in general. What history do we lose while
> refactoring?
>
> Thanks,
>
> Michael
>
>
> Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> > Hello Devs,
> >
> > Hope you are doing good !!
> >
> > Currently, there are many checkstyle issues in code base which are due to
> > formatting best practices, like indentation, using spaces before/after
> > symbols etc.
> >
> > We can solve many thousands of such issues by correcting all such
> > occurrences. Please share your thoughts on this.
> >
> > A known thing is that we will lose the last history of such codebase
> while
> > doing this re-factoring.
> >
> > Any other ideas to solve the problem are most welcome.
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
>
>

[adityasharma]

+1

Thanks and regards,
Aditya Sharma

On Mon, Jun 1, 2020 at 5:09 PM Suraj Khurana <[hidden email]>
wrote:

> Hello Michael,
>
> Just the very last commit on that particular line that we check while
> annotating. Nothing else. As Jacques mentioned most of the time the history
> can be rebuilt with blame using lines around.
>
> --
> Best Regards,
> Suraj Khurana
> SENIOR TECHNICAL CONSULTANT
> mobile: [phone]
> email: [hidden email]
> *www.hotwax.co <http://www.hotwax.co/>*
>
>
> On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl <[hidden email]>
> wrote:
>
> > Hi Suraj,
> >
> > +1 for the refactoring in general. What history do we lose while
> > refactoring?
> >
> > Thanks,
> >
> > Michael
> >
> >
> > Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> > > Hello Devs,
> > >
> > > Hope you are doing good !!
> > >
> > > Currently, there are many checkstyle issues in code base which are due
> to
> > > formatting best practices, like indentation, using spaces before/after
> > > symbols etc.
> > >
> > > We can solve many thousands of such issues by correcting all such
> > > occurrences. Please share your thoughts on this.
> > >
> > > A known thing is that we will lose the last history of such codebase
> > while
> > > doing this re-factoring.
> > >
> > > Any other ideas to solve the problem are most welcome.
> > > --
> > > Best Regards,
> > > Suraj Khurana
> > > Senior Technical Consultant
> > >
> >
> >
>

[Mridul Pathak-4]

+1

Thanks.
--
Mridul Pathak

> On 30-May-2020, at 9:55 PM, Suraj Khurana <[hidden email]> wrote:
>
> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant

[Suraj Khurana-2]

Thanks everyone for your inputs.

Here [1] is the ticket created for the same.

[1] : https://issues.apache.org/jira/browse/OFBIZ-11805

--
Best Regards,
Suraj Khurana
Senior Technical Consultant

On Wed, Jun 3, 2020 at 7:55 PM Mridul Pathak <
[hidden email]> wrote:

> +1
>
> Thanks.
> --
> Mridul Pathak
>
>
> > On 30-May-2020, at 9:55 PM, Suraj Khurana <[hidden email]>
> wrote:
> >
> > Hello Devs,
> >
> > Hope you are doing good !!
> >
> > Currently, there are many checkstyle issues in code base which are due to
> > formatting best practices, like indentation, using spaces before/after
> > symbols etc.
> >
> > We can solve many thousands of such issues by correcting all such
> > occurrences. Please share your thoughts on this.
> >
> > A known thing is that we will lose the last history of such codebase
> while
> > doing this re-factoring.
> >
> > Any other ideas to solve the problem are most welcome.
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
>
>