Issue with html specific code in ModelFormField

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue with html specific code in ModelFormField

Jacopo Cappellato
In the ModelFormField class, two getDescription(...) methods returns the
string " " if no description is found.
IMO this is not a correct because it is html specific and in fact is
causing problems when the form is rendered as PDF.
What is the best way to fix this?
Maybe changing " " to " "?

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: Issue with html specific code in ModelFormField

David E Jones-2

I guess we could even just return an empty String, but space or empty  
seems fine either way.

-David


On Nov 27, 2006, at 6:48 AM, Jacopo Cappellato wrote:

> In the ModelFormField class, two getDescription(...) methods  
> returns the string " " if no description is found.
> IMO this is not a correct because it is html specific and in fact  
> is causing problems when the form is rendered as PDF.
> What is the best way to fix this?
> Maybe changing " " to " "?
>
> Jacopo

Reply | Threaded
Open this post in threaded view
|

Re: Issue with html specific code in ModelFormField

Jacopo Cappellato
Thanks David,

following your suggestion, in rev 479931 I've replaced the " "
string with the empty "" one.

Jacopo

David E Jones wrote:

>
> I guess we could even just return an empty String, but space or empty
> seems fine either way.
>
> -David
>
>
> On Nov 27, 2006, at 6:48 AM, Jacopo Cappellato wrote:
>
>> In the ModelFormField class, two getDescription(...) methods returns
>> the string " " if no description is found.
>> IMO this is not a correct because it is html specific and in fact is
>> causing problems when the form is rendered as PDF.
>> What is the best way to fix this?
>> Maybe changing " " to " "?
>>
>> Jacopo