Can't validate an order from the backEnd
---------------------------------------- Key: OFBIZ-497 URL: http://issues.apache.org/jira/browse/OFBIZ-497 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: ecommerce Environment: 0.9.2 version of Opentaps on windows Reporter: Nicolas Passalacqua I switch the "Auto Save Cart" fields to Yes in the store "OFBiz E-Commerce store". I add a product in the cart (FrontEnd) under a user. I go to the backend look at this user profil. I see the product I just add in the shopping list and click on "edit". From there (backend) I want to purchase this order. So I click in the "Shopping List Detail - autoSave" tab on "New Order". And there I've got this error: at Line: 50 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : shoppingCart .getCurrency ( ) The Currency UOM is not set in the shopping cart, this is not a valid state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=all ]
Jacques Le Roux updated OFBIZ-497: ---------------------------------- Fix Version/s: SVN trunk Affects Version/s: SVN trunk Environment: 0.9.2 version of Opentaps on windows Apache trunk as well was: 0.9.2 version of Opentaps on windows Priority: Minor (was: Major) I downgrade to minor because I think it's not very often used. > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Priority: Minor > Fix For: SVN trunk > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=all ]
Scott Gray updated OFBIZ-497: ----------------------------- Attachment: autosave.patch This patch should fix the issue but I'm not sure if it's the best way to fix it. We could either be setting the currency before the shopping list is saved or otherwise we can default the new cart's currency to match the product store currency if nothing has been saved with the shopping list. I went for the second option with this patch. Regards Scott > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Priority: Minor > Fix For: SVN trunk > > Attachments: autosave.patch > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=comments#action_12453836 ]
Jacopo Cappellato commented on OFBIZ-497: ----------------------------------------- Scott, your patch is good. Just to points that could be improved are: 1) shoppingList.getRelatedOne("ProductStore") could be null, causing a NPE; we should check for this 2) if no currency is found in the product store, as a last resort we could use the one set in the framework/common/config/general.properties (the property name is "currency.uom.id.default"); there are many examples on how to retrieve it in the classes of the order component (if I'm not wrong, just do a search for the string "currency.uom.id.default") Jacopo > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Priority: Minor > Fix For: SVN trunk > > Attachments: autosave.patch > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=all ]
Scott Gray updated OFBIZ-497: ----------------------------- Attachment: autosave2.patch Hi Jacopo Thanks for the tips, the changes you suggested are included in this patch. Regards Scott > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Priority: Minor > Fix For: SVN trunk > > Attachments: autosave.patch, autosave2.patch > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=all ]
Jacopo Cappellato reassigned OFBIZ-497: --------------------------------------- Assignee: Jacopo Cappellato > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Assigned To: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: autosave.patch, autosave2.patch > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-497?page=all ]
Jacopo Cappellato closed OFBIZ-497. ----------------------------------- Resolution: Fixed Thanks Scott, your patch is in svn with rev. 479978 Again, thanks. > Can't validate an order from the backEnd > ---------------------------------------- > > Key: OFBIZ-497 > URL: http://issues.apache.org/jira/browse/OFBIZ-497 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk > Environment: 0.9.2 version of Opentaps on windows > Apache trunk as well > Reporter: Nicolas Passalacqua > Assigned To: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: autosave.patch, autosave2.patch > > > I switch the "Auto Save Cart" fields to Yes in the store "OFBiz > E-Commerce store". > I add a product in the cart (FrontEnd) under a user. > I go to the backend look at this user profil. > I see the product I just add in the shopping list and click on "edit". > From there (backend) I want to purchase this order. > So I click in the "Shopping List Detail - autoSave" tab on "New Order". > And there I've got this error: > at Line: 50 : in file: > component://order/webapp/ordermgr/WEB-INF/actions/entry/showcart.bsh : > shoppingCart .getCurrency ( ) > The Currency UOM is not set in the shopping cart, this is not a valid > state, it should always be passed in when the cart is created. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |